Re: make update-changes failure on MacOS

2021-02-01 Thread Ruediger Pluem



On 2/1/21 10:02 AM, Stefan Eissing wrote:
> MacOS BS:
> 
>> make update-changes
> D changes-entries/proxy_hcheck_concurrent.txt
> D changes-entries/no_empty_bind_password.txt
> Index: CHANGES
> ===
> --- CHANGES   (Revision 1886093)
> +++ CHANGES   (Arbeitskopie)
> @@ -1,6 +1,12 @@
>   -*- coding: utf-8 
> -*-
>  Changes with Apache 2.5.1
> 
> +  *) mod_authnz_ldap: Prevent authentications with empty passwords for the
> + initial bind to fail with status 500. [Ruediger Pluem]
> +
> +  *) mod_proxy_hcheck: Don't pile up health checks if the previous one did
> + not finish before hcinterval.  PR 63010.  [Yann Ylavic]
> +
>*) mod_auth_digest: Fast validation of the nonce's base64 to fail early if
>   the format can't match anyway.  [Yann Ylavic]


Thanks for testing. r1886098 and backport proposal as r1886099.

Regards

Rüdiger



Re: make update-changes failure on MacOS

2021-02-01 Thread Stefan Eissing
MacOS BS:

> make update-changes
D changes-entries/proxy_hcheck_concurrent.txt
D changes-entries/no_empty_bind_password.txt
Index: CHANGES
===
--- CHANGES (Revision 1886093)
+++ CHANGES (Arbeitskopie)
@@ -1,6 +1,12 @@
  -*- coding: utf-8 -*-
 Changes with Apache 2.5.1

+  *) mod_authnz_ldap: Prevent authentications with empty passwords for the
+ initial bind to fail with status 500. [Ruediger Pluem]
+
+  *) mod_proxy_hcheck: Don't pile up health checks if the previous one did
+ not finish before hcinterval.  PR 63010.  [Yann Ylavic]
+
   *) mod_auth_digest: Fast validation of the nonce's base64 to fail early if
  the format can't match anyway.  [Yann Ylavic]



> Am 29.01.2021 um 21:04 schrieb Ruediger Pluem :
> 
> 
> 
> On 1/21/21 11:37 AM, Ruediger Pluem wrote:
>> 
>> 
>> On 1/16/21 2:43 PM, Graham Leggett wrote:
>>> Hi all,
>>> 
>>> A quick heads up on the update-changes mechanism, on MacOS the mechanism 
>>> fails as follows, and the CHANGES file is lost (but retrievable from svn):
>>> 
>>> Little-Net:httpd-2.4.x-3 minfrin$ make update-changes
>>> awk: invalid -v option
>>> 
>>> awk: invalid -v option
>>> 
>>> It looks like the -v option is not portable?
>> 
>> Can you please try if the below patch fixes the issue on MacOs (for a quick 
>> check I guess you could apply it directly to Makefile)?
>> 
>> Index: Makefile.in
>> ===
>> --- Makefile.in  (revision 1885229)
>> +++ Makefile.in  (working copy)
>> @@ -169,7 +169,7 @@
>> update-changes:
>>  @for i in `find changes-entries -type f`; do \
>>  cp CHANGES CHANGES.tmp ; \
>> -awk -vfname=$$i 'BEGIN{done = 0} \
>> +awk -v fname=$$i 'BEGIN{done = 0} \
>>  done == 0 && /^Changes with Apache /{ active = 1; 
>> print; next}; \
>>  /^ *\*/ && active == 1 && done == 0{rec=$$0; 
>> while(getline> "\n";print rec; active = 0; done = 1; next} //;' \
>>  CHANGES.tmp > CHANGES ; \
>> 
>> 
> 
> Can anyone using MacOS confirm whether this fixes the issue?
> 
> Regards
> 
> Rüdiger



Re: make update-changes failure on MacOS

2021-01-29 Thread Ruediger Pluem



On 1/21/21 11:37 AM, Ruediger Pluem wrote:
> 
> 
> On 1/16/21 2:43 PM, Graham Leggett wrote:
>> Hi all,
>>
>> A quick heads up on the update-changes mechanism, on MacOS the mechanism 
>> fails as follows, and the CHANGES file is lost (but retrievable from svn):
>>
>> Little-Net:httpd-2.4.x-3 minfrin$ make update-changes
>> awk: invalid -v option
>>
>> awk: invalid -v option
>>
>> It looks like the -v option is not portable?
> 
> Can you please try if the below patch fixes the issue on MacOs (for a quick 
> check I guess you could apply it directly to Makefile)?
> 
> Index: Makefile.in
> ===
> --- Makefile.in   (revision 1885229)
> +++ Makefile.in   (working copy)
> @@ -169,7 +169,7 @@
>  update-changes:
>   @for i in `find changes-entries -type f`; do \
>   cp CHANGES CHANGES.tmp ; \
> - awk -vfname=$$i 'BEGIN{done = 0} \
> + awk -v fname=$$i 'BEGIN{done = 0} \
>   done == 0 && /^Changes with Apache /{ active = 1; 
> print; next}; \
>   /^ *\*/ && active == 1 && done == 0{rec=$$0; 
> while(getline "\n";print rec; active = 0; done = 1; next} //;' \
>   CHANGES.tmp > CHANGES ; \
> 
> 

Can anyone using MacOS confirm whether this fixes the issue?

Regards

Rüdiger


Re: make update-changes failure on MacOS

2021-01-21 Thread Ruediger Pluem



On 1/16/21 2:43 PM, Graham Leggett wrote:
> Hi all,
> 
> A quick heads up on the update-changes mechanism, on MacOS the mechanism 
> fails as follows, and the CHANGES file is lost (but retrievable from svn):
> 
> Little-Net:httpd-2.4.x-3 minfrin$ make update-changes
> awk: invalid -v option
> 
> awk: invalid -v option
> 
> It looks like the -v option is not portable?

Can you please try if the below patch fixes the issue on MacOs (for a quick 
check I guess you could apply it directly to Makefile)?

Index: Makefile.in
===
--- Makefile.in (revision 1885229)
+++ Makefile.in (working copy)
@@ -169,7 +169,7 @@
 update-changes:
@for i in `find changes-entries -type f`; do \
cp CHANGES CHANGES.tmp ; \
-   awk -vfname=$$i 'BEGIN{done = 0} \
+   awk -v fname=$$i 'BEGIN{done = 0} \
done == 0 && /^Changes with Apache /{ active = 1; 
print; next}; \
/^ *\*/ && active == 1 && done == 0{rec=$$0; 
while(getline CHANGES ; \


Regards

Rüdiger