Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-28 Thread Ruediger Pluem
On 05/27/2011 09:50 AM, Greg Stein wrote: On Wed, May 25, 2011 at 02:53, Ruediger Pluem rpl...@apache.org wrote: ... Thanks. IMHO this is a design flaw in the DAV provider API in conjunction with the current filter API: dav_error * (*deliver)(const dav_resource *resource,

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-27 Thread Ruediger Pluem
On 05/27/2011 06:11 AM, Justin Erenkrantz wrote: On Tue, May 24, 2011 at 8:53 PM, Ruediger Pluem rpl...@apache.org wrote: Thanks. IMHO this is a design flaw in the DAV provider API in conjunction with the current filter API: dav_error * (*deliver)(const dav_resource *resource,

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-27 Thread Greg Stein
On Wed, May 25, 2011 at 02:53, Ruediger Pluem rpl...@apache.org wrote: ... Thanks. IMHO this is a design flaw in the DAV provider API in conjunction with the current filter API:  dav_error * (*deliver)(const dav_resource *resource,                           ap_filter_t *output); deliver is

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-26 Thread Justin Erenkrantz
On Tue, May 24, 2011 at 8:53 PM, Ruediger Pluem rpl...@apache.org wrote: On 05/24/2011 07:41 PM, Justin Erenkrantz wrote: On Mon, May 23, 2011 at 8:08 PM, Ruediger Pluem rpl...@apache.org wrote: Indeed this sounds like a general problem, but ap_remove_output_filter does adjust r-output_filters

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-25 Thread Ruediger Pluem
On 05/24/2011 07:41 PM, Justin Erenkrantz wrote: On Mon, May 23, 2011 at 8:08 PM, Ruediger Pluem rpl...@apache.org wrote: Indeed this sounds like a general problem, but ap_remove_output_filter does adjust r-output_filters if f-r is set and the filter is the first one in the chain. Which

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-24 Thread Ruediger Pluem
On 05/23/2011 06:11 PM, Justin Erenkrantz wrote: On Mon, May 23, 2011 at 6:00 AM, Graham Leggett minf...@sharp.fm wrote: On 23 May 2011, at 5:57 PM, Justin Erenkrantz wrote: mod_dav uses r-output_filters - but, the pointer never gets updated when it is the first one in the chain. Hence, we

RE: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-24 Thread Yehezkel Horowitz
- /httpd/httpd/trunk/modules/filters/mod_deflate.c On 05/23/2011 06:11 PM, Justin Erenkrantz wrote: On Mon, May 23, 2011 at 6:00 AM, Graham Leggett minf...@sharp.fm wrote: On 23 May 2011, at 5:57 PM, Justin Erenkrantz wrote: mod_dav uses r-output_filters - but, the pointer never gets updated when

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-24 Thread Justin Erenkrantz
On Mon, May 23, 2011 at 8:08 PM, Ruediger Pluem rpl...@apache.org wrote: Indeed this sounds like a general problem, but ap_remove_output_filter does adjust r-output_filters if f-r is set and the filter is the first one in the chain. Which responses exactly suffer from this behaviour? Use

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-23 Thread Ruediger Pluem
On 05/15/2011 01:05 PM, jerenkra...@apache.org wrote: Author: jerenkrantz Date: Sun May 15 11:05:36 2011 New Revision: 1103315 URL: http://svn.apache.org/viewvc?rev=1103315view=rev Log: Fix memory leak in mod_deflate.c when SetOutputFilter is enabled and DEFLATE is the first filter in

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-23 Thread Justin Erenkrantz
On Mon, May 23, 2011 at 4:54 AM, Ruediger Pluem rpl...@apache.org wrote: Hm, why is it not sufficient that we call ap_remove_output_filter and remove the filter from the chain if we do not initialize? Does ap_remove_output_filter not remove the filter when it is the first one in the chain?

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-23 Thread Graham Leggett
On 23 May 2011, at 5:57 PM, Justin Erenkrantz wrote: mod_dav uses r-output_filters - but, the pointer never gets updated when it is the first one in the chain. Hence, we call mod_deflate all the time even on a request that can't support it - so we have to avoid repeated memory allocations in

Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c

2011-05-23 Thread Justin Erenkrantz
On Mon, May 23, 2011 at 6:00 AM, Graham Leggett minf...@sharp.fm wrote: On 23 May 2011, at 5:57 PM, Justin Erenkrantz wrote: mod_dav uses r-output_filters - but, the pointer never gets updated when it is the first one in the chain.  Hence, we call mod_deflate all the time even on a request