Re: svn commit: r1918685 - in /httpd/test/framework/trunk/t: conf/proxy.conf.in modules/proxy_fcgi.t
On Wed, Jun 26, 2024 at 9:34 PM Rainer Jung wrote: > > Am 27.06.24 um 03:15 schrieb Eric Covener: > > On Wed, Jun 26, 2024 at 8:59 PM Rainer Jung wrote: > >> > >> Am 26.06.24 um 23:31 schrieb [email protected]: > >>> Author: covener > >>> Date: Wed Jun 26 21:31:37 2024 > >>> New Revision: 1918685 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1918685&view=rev > >>> Log: > >>> use t/logs/ for socket > >> > >> I ran into path length restrictions for UDS. Other than normal path > >> lengths, UDS seem to be restricted to 108 chars, at least that's what > >> internet wisdom claims. > >> > >> In my setup, I have a lot of library version in my install path and the > >> socket path gets too long. As a result the web server does not start for > >> unit tests. > >> > >> I switched back to a fixed tmp path locally, so not a problem here. In > >> most cases the 108 chars will suffice. > > > > That's interesting, I wonder if I setup Yann for the same as he hit a > > similar limit earlier. That would make a big % of people running > > tests! > > > > Anyone hate the use of /tmp/ here? Otherwise I would just put it back. > > AFAICT It is not left around during the normal course of testing. > > For me /tmp is fine, since I do not run multiple servers with the unit > tests in parallel on the same machine. I am not actually sure, whether > it is possible to run the test suite multiple times in parallel (ports > etc.). If not, then a fixed /tmp path might be fine. I am not totally > sure about containers and such though. > Reverted in 1918688, better to save someone the trouble of rediscovering it.
Re: svn commit: r1918685 - in /httpd/test/framework/trunk/t: conf/proxy.conf.in modules/proxy_fcgi.t
Am 27.06.24 um 03:15 schrieb Eric Covener: On Wed, Jun 26, 2024 at 8:59 PM Rainer Jung wrote: Am 26.06.24 um 23:31 schrieb [email protected]: Author: covener Date: Wed Jun 26 21:31:37 2024 New Revision: 1918685 URL: http://svn.apache.org/viewvc?rev=1918685&view=rev Log: use t/logs/ for socket I ran into path length restrictions for UDS. Other than normal path lengths, UDS seem to be restricted to 108 chars, at least that's what internet wisdom claims. In my setup, I have a lot of library version in my install path and the socket path gets too long. As a result the web server does not start for unit tests. I switched back to a fixed tmp path locally, so not a problem here. In most cases the 108 chars will suffice. That's interesting, I wonder if I setup Yann for the same as he hit a similar limit earlier. That would make a big % of people running tests! Anyone hate the use of /tmp/ here? Otherwise I would just put it back. AFAICT It is not left around during the normal course of testing. For me /tmp is fine, since I do not run multiple servers with the unit tests in parallel on the same machine. I am not actually sure, whether it is possible to run the test suite multiple times in parallel (ports etc.). If not, then a fixed /tmp path might be fine. I am not totally sure about containers and such though. Best regards, Rainer
Re: svn commit: r1918685 - in /httpd/test/framework/trunk/t: conf/proxy.conf.in modules/proxy_fcgi.t
On Wed, Jun 26, 2024 at 8:59 PM Rainer Jung wrote: > > Am 26.06.24 um 23:31 schrieb [email protected]: > > Author: covener > > Date: Wed Jun 26 21:31:37 2024 > > New Revision: 1918685 > > > > URL: http://svn.apache.org/viewvc?rev=1918685&view=rev > > Log: > > use t/logs/ for socket > > I ran into path length restrictions for UDS. Other than normal path > lengths, UDS seem to be restricted to 108 chars, at least that's what > internet wisdom claims. > > In my setup, I have a lot of library version in my install path and the > socket path gets too long. As a result the web server does not start for > unit tests. > > I switched back to a fixed tmp path locally, so not a problem here. In > most cases the 108 chars will suffice. That's interesting, I wonder if I setup Yann for the same as he hit a similar limit earlier. That would make a big % of people running tests! Anyone hate the use of /tmp/ here? Otherwise I would just put it back. AFAICT It is not left around during the normal course of testing.
Re: svn commit: r1918685 - in /httpd/test/framework/trunk/t: conf/proxy.conf.in modules/proxy_fcgi.t
Am 26.06.24 um 23:31 schrieb [email protected]: Author: covener Date: Wed Jun 26 21:31:37 2024 New Revision: 1918685 URL: http://svn.apache.org/viewvc?rev=1918685&view=rev Log: use t/logs/ for socket I ran into path length restrictions for UDS. Other than normal path lengths, UDS seem to be restricted to 108 chars, at least that's what internet wisdom claims. In my setup, I have a lot of library version in my install path and the socket path gets too long. As a result the web server does not start for unit tests. I switched back to a fixed tmp path locally, so not a problem here. In most cases the 108 chars will suffice. Best regards and many thanks for doing all the complex release work! Rainer Modified: httpd/test/framework/trunk/t/conf/proxy.conf.in httpd/test/framework/trunk/t/modules/proxy_fcgi.t Modified: httpd/test/framework/trunk/t/conf/proxy.conf.in URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/conf/proxy.conf.in?rev=1918685&r1=1918684&r2=1918685&view=diff == --- httpd/test/framework/trunk/t/conf/proxy.conf.in (original) +++ httpd/test/framework/trunk/t/conf/proxy.conf.in Wed Jun 26 21:31:37 2024 @@ -193,10 +193,10 @@ -ProxyPass /modules/proxy/fcgi-uds "unix:/tmp/apache-test-builtinfcgi.sock|fcgi://unused" +ProxyPass /modules/proxy/fcgi-uds "unix:@SERVERROOT@/logs/fcgi.sock|fcgi://unused" Alias /modules/proxy/fcgi-uds-sethandler @SERVERROOT@/htdocs/modules/proxy/fcgi -SetHandler "proxy:unix:/tmp/apache-test-builtinfcgi.sock|fcgi://unused" +SetHandler "proxy:unix:@SERVERROOT@/logs/fcgi.sock|fcgi://unused" Modified: httpd/test/framework/trunk/t/modules/proxy_fcgi.t URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/modules/proxy_fcgi.t?rev=1918685&r1=1918684&r2=1918685&view=diff == --- httpd/test/framework/trunk/t/modules/proxy_fcgi.t (original) +++ httpd/test/framework/trunk/t/modules/proxy_fcgi.t Wed Jun 26 21:31:37 2024 @@ -315,7 +315,8 @@ if (have_module('actions')) { $envs = run_fcgi_envvar_request($fcgi_port, "/modules/proxy/fcgi/index.php"); ok t_cmp($envs->{'SCRIPT_NAME'}, '/modules/proxy/fcgi/index.php', "Server sets correct SCRIPT_NAME by default"); +my $uds_sock = Apache::Test::vars('serverroot')."/logs/fcgi.sock"; foreach my $url (@udstests) { -$envs = run_fcgi_envvar_request("/tmp/apache-test-builtinfcgi.sock", "$url"); +$envs = run_fcgi_envvar_request($uds_sock, $url); ok t_cmp($envs->{'SCRIPT_NAME'}, "$url", "Server sets correct SCRIPT_NAME by default"); }
