Re: h2 backport proposal

[Stefan Eissing]

> Am 13.03.2019 um 15:41 schrieb Yann Ylavic :
> 
> Got Jim's and my votes, could be merged now ;)
> Please note that the CHANGES entries from the patch are slightly mixed
> with unrelated changes, should be cleaned up when backporting.
> Nice changes otherwise, thanks!

Thanks, Yann! Will do!


> On Wed, Mar 13, 2019 at 2:05 PM Stefan Eissing
>  wrote:
>> 
>> Proposal updated in 1855417.
>> 
>>> Am 13.03.2019 um 13:46 schrieb Stefan Eissing 
>>> :
>>> 
>>> 
 Am 13.03.2019 um 13:32 schrieb Yann Ylavic :
 
 On Wed, Mar 13, 2019 at 12:55 PM Yann Ylavic  wrote:
> 
> On Wed, Mar 13, 2019 at 12:49 PM Stefan Eissing
>  wrote:
>> 
>> It would be nice if 2 people could find the time to have a look at it.
> 
> I'm currently reviewing it, looks good so far, nice!
 
 Looks like the proposal reverts r1852989, normal?
>>> 
>>> Nicely caught! I forgot to bring this over to github, so my recent merge 
>>> over did revert it.
>>> 
>>> Re-added to trunk in: r1855411. Will add to backport proposal.
>>> 
>>> Thanks, Yann!
>>> 
>> 

Re: h2 backport proposal

[Yann Ylavic]

Got Jim's and my votes, could be merged now ;)
Please note that the CHANGES entries from the patch are slightly mixed
with unrelated changes, should be cleaned up when backporting.
Nice changes otherwise, thanks!

On Wed, Mar 13, 2019 at 2:05 PM Stefan Eissing
 wrote:
>
> Proposal updated in 1855417.
>
> > Am 13.03.2019 um 13:46 schrieb Stefan Eissing 
> > :
> >
> >
> >> Am 13.03.2019 um 13:32 schrieb Yann Ylavic :
> >>
> >> On Wed, Mar 13, 2019 at 12:55 PM Yann Ylavic  wrote:
> >>>
> >>> On Wed, Mar 13, 2019 at 12:49 PM Stefan Eissing
> >>>  wrote:
> 
>  It would be nice if 2 people could find the time to have a look at it.
> >>>
> >>> I'm currently reviewing it, looks good so far, nice!
> >>
> >> Looks like the proposal reverts r1852989, normal?
> >
> > Nicely caught! I forgot to bring this over to github, so my recent merge 
> > over did revert it.
> >
> > Re-added to trunk in: r1855411. Will add to backport proposal.
> >
> > Thanks, Yann!
> >
>

Re: h2 backport proposal

[Stefan Eissing]

Proposal updated in 1855417.

> Am 13.03.2019 um 13:46 schrieb Stefan Eissing :
> 
> 
>> Am 13.03.2019 um 13:32 schrieb Yann Ylavic :
>> 
>> On Wed, Mar 13, 2019 at 12:55 PM Yann Ylavic  wrote:
>>> 
>>> On Wed, Mar 13, 2019 at 12:49 PM Stefan Eissing
>>>  wrote:
 
 It would be nice if 2 people could find the time to have a look at it.
>>> 
>>> I'm currently reviewing it, looks good so far, nice!
>> 
>> Looks like the proposal reverts r1852989, normal?
> 
> Nicely caught! I forgot to bring this over to github, so my recent merge over 
> did revert it.
> 
> Re-added to trunk in: r1855411. Will add to backport proposal.
> 
> Thanks, Yann!
> 

Re: h2 backport proposal

[Stefan Eissing]

> Am 13.03.2019 um 13:32 schrieb Yann Ylavic :
> 
> On Wed, Mar 13, 2019 at 12:55 PM Yann Ylavic  wrote:
>> 
>> On Wed, Mar 13, 2019 at 12:49 PM Stefan Eissing
>>  wrote:
>>> 
>>> It would be nice if 2 people could find the time to have a look at it.
>> 
>> I'm currently reviewing it, looks good so far, nice!
> 
> Looks like the proposal reverts r1852989, normal?

Nicely caught! I forgot to bring this over to github, so my recent merge over 
did revert it.

Re-added to trunk in: r1855411. Will add to backport proposal.

Thanks, Yann!

Re: h2 backport proposal

[Yann Ylavic]

On Wed, Mar 13, 2019 at 12:55 PM Yann Ylavic  wrote:
>
> On Wed, Mar 13, 2019 at 12:49 PM Stefan Eissing
>  wrote:
> >
> > It would be nice if 2 people could find the time to have a look at it.
>
> I'm currently reviewing it, looks good so far, nice!

Looks like the proposal reverts r1852989, normal?

Re: h2 backport proposal

[Yann Ylavic]

On Wed, Mar 13, 2019 at 12:49 PM Stefan Eissing
 wrote:
>
> It would be nice if 2 people could find the time to have a look at it.

I'm currently reviewing it, looks good so far, nice!

Cheers.

h2 backport proposal

[Stefan Eissing]

There is a mod_http2/mod_proxy_http2 backport proposal in 2.4.x/STATUS
that accumulates this years changes from the github version. This
includes several bugfixes, 2 of which from Michael Kaufmann (Thanks!), 
for issues reported:

  *) mod_http2: HEAD requests to some module such as mod_cgid caused the stream 
to
 terminate improperly and cause a HTTP/2 PROTOCOL_ERROR. 
 Fixes . [Michael Kaufmann]
  *) mod_http2: when SSL renegotiation is inhibited and a 403 ErrorDocument is
 in play, the proper HTTP/2 stream reset did not trigger with 
H2_ERR_HTTP_1_1_REQUIRED.
 Fixed. [Michael Kaufmann] 
  *) mod_proxy_http2: changed mod_proxy_http2 implementation and fixed several 
bugs which
 resolve PR63170. The proxy module does now a single h2 request on the 
(reused)
 connection and returns. [Stefan Eissing]
  *) mod_http2: enable re-use of slave connections again. Fixed slave connection
 keepalives counter. [Stefan Eissing]

Two features have also been implemented:

  *) mod_http2: new configuration directive: ```H2Padding numbits``` to control 
 padding of HTTP/2 payload frames. 'numbits' is a number from 0-8,
 controlling the range of padding bytes added to a frame. The actual number
 added is chosen randomly per frame. This applies to HEADERS, DATA and 
PUSH_PROMISE
 frames equally. The default continues to be 0, e.g. no padding. [Stefan 
Eissing] 
  *) mod_http2: Configuration directives H2Push and H2Upgrade can now be 
specified per 
 Location/Directory, e.g. disabling PUSH for a specific set of resources. 
[Stefan Eissing]

For the H2Padding, I also wrote a blog at: 
https://icing.github.io/mod_h2/padding.html

It would be nice if 2 people could find the time to have a look at it. 

Cheers, Stefan