[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-992183368 Closing this and continuing in #2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989259177 > How are we going to move forward with this PR? If we move to the `next` branch, is this PR for the `main` branch still needed? If a `next` branch is created I can re-open this PR against that. Or alternatively we could merge this, open a PR `main -> next`, merge that, set `next` as the default branch and then delete `main`. We would also have to remove the `main` directory from the `asf-site` branch, I can follow up with a PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-987600519 > It looks like the Apache 2.0 license header is missing for some README and script files, please check and add, thanks! > > For Python script, it seems like indentation is off at some places. If we do not set up lint in this PR, please make sure we have a task to set it up later. Thanks for catching this! I added the Apache 2.0 license headers everywhere. I did a quick auto format of the python scripts with black. I'll follow up this PR with a tox file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986415495 Updated to not include the javadocs and also to include the theme as a submodule. An overview of the important directories/files. - `content/docs` directory includes all of the markdown pages - `config.toml` includes the hugo site configuration - `.github/workflows/deploy.yml` includes the github workflow for deploying versioned sites to the `asf-site` branch - `asciinema` directory includes a README and a helper python script to easily generate asciinema recordings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986319585 Ah, my bad that's from two things: - Didn't realize I included all of the javadocs, (which accounts for 3,310 files) - I included the theme repo in this actual repo but it can be added as a submodule as described [here](https://github.com/alex-shpak/hugo-book#install-as-git-submodule) (which accounts for 177 files) Converting this to a draft for now while I fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986105830 @rdblue @jackye1995 @kbendick @ajantha-bhat @RussellSpitzer @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
