Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Dmitriy Pavlov
Hi Denis, Sure, since code freeze is planned for today, I don't mind to include this bug. Ivan, could you complete this issue by 20 August? BTW #1, Dmitriy Govoruchnin, please reply about commit for https://issues.apache.org/jira/browse/IGNITE-11953?src=confmacro BTW #2, FYI, release page is

Re: Coding guidelines. Useless JavaDoc comments.

2019-08-15 Thread Nikolay Izhikov
Hello, Anton. > I'd like to propose to have only non-obvious params explained at > non-public method's Javadoc. Non-obvious for whom? Please, remember about guys who just came into Ignite community. В Чт, 15/08/2019 в 10:05 +0300, Anton Vinogradov пишет: > My +1 to optional Javadoc at

[jira] [Created] (IGNITE-12075) Wrong table alias when SUM used inside CASE WHEN

2019-08-15 Thread Ilya Kasnacheev (JIRA)
Ilya Kasnacheev created IGNITE-12075: Summary: Wrong table alias when SUM used inside CASE WHEN Key: IGNITE-12075 URL: https://issues.apache.org/jira/browse/IGNITE-12075 Project: Ignite

[jira] [Created] (IGNITE-12076) Optimistic transaction initiated from client node and parallel cache stop may lead to node hang on the final phase of PME.

2019-08-15 Thread Vyacheslav Koptilin (JIRA)
Vyacheslav Koptilin created IGNITE-12076: Summary: Optimistic transaction initiated from client node and parallel cache stop may lead to node hang on the final phase of PME. Key: IGNITE-12076 URL:

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Павлухин Иван
Dmitriy, > Ivan, could you complete this issue by 20 August? Yes, almost for sure. чт, 15 авг. 2019 г. в 16:05, Denis Magda : > > Dmitry, > > It would be better for us to put off the Spark upgrade until 2.8 as Nikolay > suggested. Let's release 2.7.6 as quickly as possible to let roll out fixes

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Nikolay Izhikov
Hello, Igniters. I try to upgrade Spark version but failed. Seems, internal Spark API(External Catalog, SQL planner) that we use changed a lot. So it will take some time to upgrade version. For now, I work hard to complete the second phase of IEP-35 so I postpone upgrade Spark version to

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Denis Magda
Dmitry, It would be better for us to put off the Spark upgrade until 2.8 as Nikolay suggested. Let's release 2.7.6 as quickly as possible to let roll out fixes for the critical issues from the scope. - Denis On Thu, Aug 15, 2019 at 3:29 PM Dmitriy Pavlov wrote: > Nikolay, how long does it

Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Zhenya Stanilovsky
yep, i`l try to call someone who probably familiar with this problem. > > >Ok, I've removed Spark from the scope. > >What about the unassigned issue related to ODBC? It is not looking like >somebody will fix it before release. > >Evgeniy Stanilovsky, what about

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Dmitriy Pavlov
Nikolay, how long does it take to update? I will be traveling from 28 Aug till 16 Sept. We can select new dates for release if the majority of fixes can be done by 16 Sept, but can't be by 20 Aug. Denis, please share your vision about selecting new dates. *Voting Date: *Sept 18, 2019 *Release

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Dmitriy Pavlov
Ok, I've removed Spark from the scope. What about the unassigned issue related to ODBC? It is not looking like somebody will fix it before release. Evgeniy Stanilovsky, what about https://issues.apache.org/jira/browse/IGNITE-12061

Re: Coding guidelines. Useless JavaDoc comments.

2019-08-15 Thread Anton Vinogradov
My +1 to optional Javadoc at private methods, fields, and classes. The reviewer should guaranty that everything is clear. But, in case everything is clear without redundant Javadoc there is no need to have it. So, my proposal is to allow /** */ for non-public fields and methods (to keep

Re: Coding guidelines. Useless JavaDoc comments.

2019-08-15 Thread Anton Vinogradov
Nikolay, Params like * @param tx Cache transaction. * @param val Value to set. * @param oldVal Old value. * @param topVer Topology version. * @param taskName Task name. seems to be obvious to everyone. No reason to hove the documented. In case you doubt it obvious, just document it. On Thu, Aug

Re: Re[2]: Asynchronous registration of binary metadata

2019-08-15 Thread Sergey Chugunov
Denis, Thanks for bringing this issue up, decision to write binary metadata from discovery thread was really a tough decision to make. I don't think that moving metadata to metastorage is a silver bullet here as this approach also has its drawbacks and is not an easy change. In addition to

Re: Thin client: transactions support

2019-08-15 Thread Alex Plehanov
Hi Pavel, Thank you for the review! Igniters, Also, I want to bring here a discussion about configuring limit for active transactions per thin client connection. I see two ways to configure such limit: 1. A new system property 2. A new ClientConnectorConfiguration class property. In the

Re: SQL query timeout: in progress or abandoned

2019-08-15 Thread Павлухин Иван
Saikat, Denis, I left comments in the ticket [1]. [1] https://issues.apache.org/jira/browse/IGNITE-7285 вт, 13 авг. 2019 г. в 21:53, Denis Magda : > > Hi Saikat, > > Thanks for a quick turnaround! Ivan, could you please step in and do a > review? > > - > Denis > > > On Sun, Aug 11, 2019 at 6:26

Re: Thin client: transactions support

2019-08-15 Thread Павлухин Иван
Hi Alex, Could you please elaborate about thin client protocol versioning. As I see 1.5.0 is supposed to be a version supporting transactions. And we already have a version 1.4.0 with affinity awareness support. I forgot, does Java thin client support affinity awareness? Will it work properly if

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Denis Magda
An Ignite user just reported a silly issue that needs to be fixed in 2.7.6: https://issues.apache.org/jira/browse/IGNITE-12068 More details and context: https://stackoverflow.com/questions/57479636/simple-select-query-missing-rows-in-ignite Ivan, please help us to make it to the release. -

Re: IGNITE-7285 Add default query timeout

2019-08-15 Thread Павлухин Иван
Just to keep history connected. The discussion continued in http://apache-ignite-developers.2346864.n4.nabble.com/SQL-query-timeout-in-progress-or-abandoned-td42964.html вт, 18 июн. 2019 г. в 12:22, Павлухин Иван : > > Hi Saikat, > > Thank you for driving it. I left my comments [1]. > > [1]

Re: Do I have to use --illegal-access=permit for Java thin client and JDBC with JDK 9/10/11.

2019-08-15 Thread Denis Magda
Denis, Does it mean we don't need to pass any flags from this list [1] at all for the JDBC and thin clients? [1] https://apacheignite.readme.io/docs/getting-started#section-running-ignite-with-java-9-10-11 - Denis On Wed, Aug 14, 2019 at 5:56 PM Denis Mekhanikov wrote: > Hi! > > There are

Re: Thin client: transactions support

2019-08-15 Thread Alex Plehanov
Hi Ivan, Java thin client doesn't support affinity awareness yet (ticket [1] is in progress now), but changes to correctly work with protocol version 1.4.0 was made, so java thin client will work properly with 1.4.0 and 1.5.0 protocol versions. [1]:

Re: Thin client: transactions support

2019-08-15 Thread Pavel Tupitsyn
Hi Alex, I've checked the patch, protocol changes look good to me. See reply in Jira. But we certainly need more eyes on this. On Thu, Aug 15, 2019 at 10:36 AM Alex Plehanov wrote: > Hi Ivan, > > Java thin client doesn't support affinity awareness yet (ticket [1] is in > progress now), but

Re[2]: Asynchronous registration of binary metadata

2019-08-15 Thread Zhenya Stanilovsky
> >> 1. Yes, only on OS failures. In such case data will be received from alive >> nodes later. What behavior would be in case of one node ? I suppose someone can obtain cache data without unmarshalling schema, what in this case would be with grid  operability? > >> 2. Yes, for walmode=FSYNC

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Ilya Kasnacheev
Hello! I suggest also including IGNITE-11736, otherwise we are going to run into problems each time TC is invoked. https://issues.apache.org/jira/browse/IGNITE-11736 Regards, -- Ilya Kasnacheev чт, 15 авг. 2019 г. в 16:56, Zhenya Stanilovsky : > yep, i`l try to call someone who probably

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Dmitriy Pavlov
Hi Ilya, I bypassed this problem in the Tc bot by "triggerBuild": true, "triggerBuildQuietPeriod": 480, //triggering quiet period in minutes, 2 builds per day "triggerParameters": [ { "name": "reverse.dep.*.IGNITE_LOGGING_OPTS", "value": "-DIGNITE_QUIET=false" } ] But if is test

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Zhenya Stanilovsky
Dmitriy, review passed, plz proceed. thanks ! I removed https://issues.apache.org/jira/browse/IGNITE-12032 until nobody volunteer to complete the task. Evgeniy, please keep me updated about IGNITE-12061. чт, 15 авг. 2019 г. в 16:56, Zhenya Stanilovsky : yep, i`l try to call someone

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Dmitriy Pavlov
I removed https://issues.apache.org/jira/browse/IGNITE-12032 until nobody volunteer to complete the task. Evgeniy, please keep me updated about IGNITE-12061. чт, 15 авг. 2019 г. в 16:56, Zhenya Stanilovsky : > yep, i`l try to call someone who probably familiar with this problem. > > > > > >

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Dmitriy Pavlov
Sorry, it was too easy to do, no need to ask Maxim. Cherry-picked to 2.7.6, https://github.com/apache/ignite/commit/891e49fe1eeb28bc6b655024086c3f4d1324fda4 чт, 15 авг. 2019 г. в 19:02, Dmitriy Pavlov : > Hi Ilya, > > I bypassed this problem in the Tc bot by > "triggerBuild": true, >

[jira] [Created] (IGNITE-12077) Improve Checkstyle or other inspections profile to avoid using GG- reference in Ignite code base

2019-08-15 Thread Dmitriy Pavlov (JIRA)
Dmitriy Pavlov created IGNITE-12077: --- Summary: Improve Checkstyle or other inspections profile to avoid using GG- reference in Ignite code base Key: IGNITE-12077 URL: