Amelchev Nikita created IGNITE-12423:
Summary: PME duration histogram updates only if log info enabled
Key: IGNITE-12423
URL: https://issues.apache.org/jira/browse/IGNITE-12423
Project: Ignite
Hello, Igniters.
We have confusing API in `BinaryObjectBuilder` class.
The code below leads to the `ClassCastException`
The cause is java method resolution rules [1]
> There may be more than one such method, in which case the most specific one
> is chosen
I suggest to deprecate
Nikolay,
It seems to me, that the real cause of the issue is a contract:
public T getField(String name);
Which can lead to class cast to any type. Consequently, a user gets
runtime type checks instead of compile time checks.
On the other hand, your proposal could be handy in practice, have
Hello!
I can see where you are getting at, can we call it "setFieldNested" instead
or something like that?
setBinaryField is confusing because we're not passing anything especially
binary, just a nested BinaryObjectBuilder.
Regards,
--
Ilya Kasnacheev
пт, 6 дек. 2019 г. в 13:17, Николай
Hello, Ilya.
I don’t get your point
> We don’t passing … binary, just a … BinaryObjeсtBuilder.
May be we should go with `setBinaryObjectBuilderField` or
`setBinaryObjectField`?
> 6 дек. 2019 г., в 13:38, Ilya Kasnacheev
> написал(а):
>
> Hello!
>
> I can see where you are getting at, can
Hello Maxim,
I found two issues that should be included in the upcoming AI 2.8, I think.
[1] https://issues.apache.org/jira/browse/IGNITE-12409 - Already done and
can be cherry-picked into the release branch.
[2] https://issues.apache.org/jira/browse/IGNITE-12419 - This one looks
like a blocker
aitc-lin08 was handled as well.
пт, 6 дек. 2019 г. в 10:41, Maxim Muzafarov :
>
> Ivan,
>
> And another one.
> Starting the build on the agent "aitc-lin08_01"
> Failed to download file 'ignite.zip': No space left on device
>
> [1]
>
listed agents seem to be broken too:
aitc-lin11_02
aitc-lin10_02
aitc-lin05_01
aitc-lin04_04
On Fri, Dec 6, 2019 at 2:22 PM Ivan Pavlukhin wrote:
> aitc-lin08 was handled as well.
>
> пт, 6 дек. 2019 г. в 10:41, Maxim Muzafarov :
> >
> > Ivan,
> >
> > And another one.
> > Starting the build on
Hello!
I think that repeating argument type name in method name is a code smell.
Rather, we should describe how this method is different from other methods
of its bunch.
In this case, it is different since it allows you to create nested binary
objects, i.e., ones with non-flat structure.
I wonder why signature is not
setField(String name, BinaryObject obj)
пт, 6 дек. 2019 г. в 15:00, Ilya Kasnacheev :
> Hello!
>
> I think that repeating argument type name in method name is a code smell.
> Rather, we should describe how this method is different from other methods
> of its bunch.
I’m too, Alex.
But, this signature leads to the same error as I mentioned.
> 6 дек. 2019 г., в 15:53, Alexei Scherbakov
> написал(а):
>
> I wonder why signature is not
>
> setField(String name, BinaryObject obj)
>
> пт, 6 дек. 2019 г. в 15:00, Ilya Kasnacheev :
>
>> Hello!
>>
>> I think
Looks like it's already possible to pass binary object as value using
BinaryObjectBuilder setField(String name, Object val);
If it works we can remove a signature with BinaryObjectBuilder.
The API is truly confusing.
пт, 6 дек. 2019 г. в 15:55, Николай Ижиков :
> I’m too, Alex.
>
> But, this
Hi Igniters,
I've detected some new issue on TeamCity to be handled. You are more than
welcomed to help.
If your changes can lead to this failure(s): We're grateful that you were a
volunteer to make the contribution to this project, but things change and you
may no longer be able to
Slava,
Thanks for noticing. I think we can include both of them.
Do you need any help from my side?
On Fri, 6 Dec 2019 at 14:02, Вячеслав Коптилин wrote:
>
> Hello Maxim,
>
> I found two issues that should be included in the upcoming AI 2.8, I think.
> [1]
Hello Ignite Users, Enthusiasts and Contributors,
If you have an apache.org email, you should have received an email with an
invitation to take the 2020 ASF Community Survey. Please take 15 minutes to
complete it.
If you do not have an apache.org email address or you didn’t receive a
link,
15 matches
Mail list logo
