Request for contributors permissions

2020-05-19 Thread Max Timonin
Hi all, my name is Maksim Timonin, I'm going to contribute to Ignite. Could you please grant contributors permissions to *timonin.maksim *account? Regards, Maksim

Broken test in master: BasicIndexTest

2020-10-08 Thread Max Timonin
Hi, Igniters! I was discovering how indexes work and found a failed test. BasicIndexTest#testInlineSizeChange is broken in master and it's not a flaky case [1]. But it has been failing since 25/09 only. I discovered that it happened after the IGNITE-13207 ticket merged (Checkpointer code

[DISCUSS] Missed (non-suited) tests

2020-10-19 Thread Max Timonin
Hi Igniters! I made a research into tests that aren't included in any test suite. As TeamCity runs tests by suites so there could be tests that never run on TC. So I tried implementing a simple check for such tests and include it in Ignite's travis config. The check runs while "mvn test" command

Re: [DISCUSS] Missed (non-suited) tests

2020-10-19 Thread Max Timonin
mented. > > пн, 19 окт. 2020 г. в 16:33, Ivan Pavlukhin : > > > Hi Max, > > > > There is an existing effort about "abandoned" tests > > https://issues.apache.org/jira/browse/IGNITE-9210 > > > > 2020-10-19 16:25 GMT+03:00, Max Timonin : > &g

Re: Thin Client Kubernetes discovery

2020-08-13 Thread Max Timonin
t is > deployed outside of a K8S environment. > > @Vladimir Pligin , could you please join the thread. > I've seen you joined the discussion in JIRA. > > - > Denis > > > On Wed, Aug 12, 2020 at 12:06 PM Max Timonin > wrote: > > > Hi, Igniters > >

Thin Client Kubernetes discovery

2020-08-12 Thread Max Timonin
Hi, Igniters I'm now discovering the issue https://issues.apache.org/jira/browse/IGNITE-13204 and wondering what is a case that requires a client to be able to discover a cluster? I believe that discovery is a goal of kubernetes itself. We could assign a DNS name for a Service [1] and then any

Re: Thin Client Kubernetes discovery

2020-08-13 Thread Max Timonin
ak some internal state of the > > connection on the client-side and lead to unpredictable behavior. Also, > if > > the partition-awareness feature is enabled, then the thin client will > start > > bypassing the Service for most of the key-value requests connecting to > the

Re: Thin Client Kubernetes discovery

2020-08-13 Thread Max Timonin
Hi, StatefulSet provides predictable naming, then it should be easy to configure a client with addresses ignite-1,ignite-2...ignite-N. So there is no need in custom discovery, IPs etc. I think it corresponds to k8s patterns, as some pods are different from others as they store specific partitions

Proposal of new event QUERY_EXECUTION_EVENT

2020-07-10 Thread Max Timonin
Hi Igniters! We're going to protocol all input SQL queries from our users. Currently there is no such mechanism in Ignite to use for it. So we're proposing to add a new event: QUERY_EXECUITION_EVENT. Requirements for the event: 1. If this event fires it means that a query is correct and will be

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-15 Thread Max Timonin
> On Fri, Jul 10, 2020 at 3:54 AM Max Timonin > wrote: > > > Hi Igniters! > > > > We're going to protocol all input SQL queries from our users. Currently > > there is no such mechanism in Ignite to use for it. So we're proposing to > > add a new event: QUERY_EX

Event for failed queries

2020-06-29 Thread Max Timonin
Hi Igniters, I'm looking for a technique that can provide SQL clauses for an external observer. There is an event 'CacheQueryExecutedEvent' (maps to EVT_CACHE_QUERY_EXECUTED) that contains the clause. But as I can see it's produced only for success queries and there is no any event if a query

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-20 Thread Max Timonin
> > Stan > > > > > On 16 Jul 2020, at 18:49, Denis Magda wrote: > > > > > > Taras, Yury, Ivan, > > > > > > Could you please join this thread and share your thoughts? Do we > already > > > have any plans on tracking of the DDL

Re: [DISCUSS] Missed (non-suited) tests

2020-11-27 Thread Max Timonin
and its tests are also included in all other modules' tests > classpath since it provides GridAbstractTest. > > Regards, > -- > Ilya Kasnacheev > > > пт, 27 нояб. 2020 г. в 01:24, Max Timonin : > > > Hi, Ilya! > > > > So, I've updated PR, fixed comments and

Re: [DISCUSS] Missed (non-suited) tests

2020-11-27 Thread Max Timonin
gurations, suite names are simple class names, not FQ, so no > changes may be needed at all. > > Regards, > -- > Ilya Kasnacheev > > > пт, 27 нояб. 2020 г. в 13:03, Max Timonin : > > > Hi, sorry for the misleading. I mean "adding ignite-core module *suites*

Re: [DISCUSS] Missed (non-suited) tests

2020-11-24 Thread Max Timonin
6. and some others. On Wed, Nov 18, 2020 at 12:38 PM Max Timonin wrote: > Hi Ilya! Thank you for up the topic. I will come back with fixes and > comments in a couple of days. > > On Tue, Nov 17, 2020 at 4:26 PM Ilya Kasnacheev > wrote: > >> Hello! >> >> I

Re: [DISCUSS] Missed (non-suited) tests

2020-11-26 Thread Max Timonin
run these tests > from IDEA by specifying other module as classpath. No need to move the > classes around. > > I will check the PR. > > Regards, > -- > Ilya Kasnacheev > > > ср, 25 нояб. 2020 г. в 00:22, Max Timonin : > > > Ilya, Anton, Ivan, hi! > > &

Re: [DISCUSS] Missed (non-suited) tests

2020-12-02 Thread Max Timonin
ot sure, but I think it's an issue due to usage of Classworlds. So, using dependency from .m2 is the only way. [1] https://ci.ignite.apache.org/viewLog.html?buildId=5770727=IgniteTests24Java8_Queries1=buildParameters On Fri, Nov 27, 2020 at 3:55 PM Max Timonin wrote: > Sure, I'll do that. &

Re: [DISCUSS] Missed (non-suited) tests

2020-12-02 Thread Max Timonin
what's included and what's not. > > Regards, > -- > Ilya Kasnacheev > > > ср, 2 дек. 2020 г. в 15:56, Max Timonin : > > > Hi, Ilya! > > > > I've checked testsuites. There is an issue. For example > > *IgniteBinaryCacheQueryTestSuite* suite is now in 2

Re: [DISCUSS] Missed (non-suited) tests

2020-11-18 Thread Max Timonin
-- > Ilya Kasnacheev > > > вт, 3 нояб. 2020 г. в 00:03, Max Timonin : > > > Hi! > > > > I've updated PR: https://github.com/apache/ignite/pull/8367. Anton, > Ivan, > > Ivan could you please review it? > > > > Some moments to mention:

Re: [DISCUSS] Missed (non-suited) tests

2020-11-02 Thread Max Timonin
ctionAfterRestartTest -- yes we need it. This test failed > because > > > of race (test shold be rewritten a little bit) > > > > > > пт, 30 окт. 2020 г. в 16:15, Max Timonin : > > > > > >> Hi! > > >> > > >> Yes, you're corr

Re: [DISCUSS] Missed (non-suited) tests

2020-10-30 Thread Max Timonin
ility to automate check using Travis. > > On Tue, Oct 20, 2020 at 12:06 PM Ivan Pavlukhin > wrote: > > > Max, Ivan, > > > > Using explicit @Ignore and the automated check sounds good to me. If > > nobody has arguments against it I think we should do it. > >

Re: [DISCUSS] Missed (non-suited) tests

2020-12-25 Thread Max Timonin
onder if we can drop this requirement, check all the modules > > transitively for used/unused tests. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > ср, 2 дек. 2020 г. в 18:23, Max Timonin : > > > > > Hi, > > > > >

Re: [DISCUSS] Missed (non-suited) tests

2021-01-25 Thread Max Timonin
> > Regards, > -- > Ilya Kasnacheev > > > пт, 25 дек. 2020 г. в 17:19, Max Timonin : > > > Hi! > > > > Ilya thanks for the reply! I agree that it's a valid case when a test is > > part of multiple suites in different modules. But it is definitely a bug &g

Re:

2021-02-02 Thread Max Timonin
Closed. I've recreated a topic, as forget about the topic title there. On Tue, Feb 2, 2021 at 6:17 PM Max Timonin wrote: > Hi, Igniters! > > Last week I investigated a bug [1]. It's about an incorrect result for > non-colocated joins. For such joins it's requir

[DISCUSSION] Fail on non-colocated join

2021-02-02 Thread Max Timonin
Hi, Igniters! Last week I investigated a bug [1]. It's about an incorrect result for non-colocated joins. For such joins it's required to set up the "distributedJoin" flag, or try to make joined tables colocated. It is covered in docs [2]. But it's not obvious and some users don't read that or

Re: [DISCUSS] Missed (non-suited) tests

2021-02-07 Thread Max Timonin
er the new ML suites make sense? > > math/distances/DistancesTestSuite.java > > naivebayes/NaiveBayesTestSuite.java > > > > Would we need to add them to some TC runs? > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > пн, 25 янв

Re: [DISCCUSS] Ignite 2.9.2. Index compatibility issue 2.x -> 2.9

2021-03-01 Thread Max Timonin
> Ilya Kasnacheev > > > пт, 26 февр. 2021 г. в 11:32, Max Timonin : > > > Hi, Igniters! > > > > There was a compatibility issue [1] with upgrading an old version of > Ignite > > to 2.9. Inlined JavaObjects just are skipped and then it

Re: [DISCUSS] Missed (non-suited) tests

2021-02-24 Thread Max Timonin
ent in the target branch. > >>> > >>> This includes e.g. 2.10 nightlies. > >>> > >>> What can we do to avoid that? Is specifying -DskipTests sufficient? Any > >>> chance that it will break the missed tests check? > >>> >

Re: TeamCity agent aitc-lin07_04 fails to run Build

2021-02-24 Thread Max Timonin
/IgniteTests24Java8_BuildApacheIgnite/5890154 On Wed, Feb 24, 2021 at 10:10 AM Max Timonin wrote: > Hi! > > My "Build" runs on TC fail with on 1 (Step: Cleanup local maven > repository (Command Line)) > > Error is related to AI 3.0.0: > > + rm -rfv /opt/buildagent/.m2/repositor

Re: Re[2]: [DISCUSSION] Apache Ignite Release 2.10 (time, scope, manager)

2021-02-26 Thread Max Timonin
e/IGNITE-14204 > > > > > > > > On Thu, 18 Feb 2021 at 18:35, Igor Sapego > wrote: > > > > > > > > > > Maxim, > > > > > > > > > > I believe I could fix the ticket [1] by the end of the next week. > > > &

[DISCCUSS] Ignite 2.9.2. Index compatibility issue 2.x -> 2.9

2021-02-26 Thread Max Timonin
Hi, Igniters! There was a compatibility issue [1] with upgrading an old version of Ignite to 2.9. Inlined JavaObjects just are skipped and then it leads to undefined behavior: 1. In best case it just fails with BPlusTreeCorruptedException; 2. But in some cases Ignite may *silently* make a wrong

Re: [DISCUSS] Missed (non-suited) tests

2021-03-03 Thread Max Timonin
; Head of IT > IT & Development Solutions | GRIDGAIN SYSTEMS > +7 (911) 945-00-59 > > > On 25 Feb 2021, at 13:23, Max Timonin wrote: > > > > Yes, it's correct that "mvn install" runs also the "mvn test" command, > and > > th

Re: [DISCUSS] Missed (non-suited) tests

2021-03-03 Thread Max Timonin
of the [Sanity Checks] job. If the check job fails then a test job won't be started. 5. Users can disable the [Sanity Checks] job with a selector on the Parameters tab of custom TC build. If no one has objections I will create a JIRA ticket for that. On Wed, Mar 3, 2021 at 5:11 PM Max Timonin

Re: [DISCUSS] Missed (non-suited) tests

2021-03-03 Thread Max Timonin
Yes, they can be performed as parallel, as doesn't depend on each other. There is an overhead for running git + mvn test twice, but it is a cost for the flexibility. On Wed, Mar 3, 2021 at 8:55 PM Max Timonin wrote: > I mean that any TC job with tests depends on both [Build], [Sanity >

Re: [DISCUSS] Missed (non-suited) tests

2021-03-03 Thread Max Timonin
cks] runs in parallel with > [Build]'? AFAIK the checks need the build results to run themselves. > > On Wed, 3 Mar 2021 at 18:48, Max Timonin wrote: > > > > Discussed with Petr privately. Proposal is: > > > > 1. The [Build] job runs without any checks. > > 2. Th

Re: [DISCUSS] Missed (non-suited) tests

2021-02-24 Thread Max Timonin
heck, group > all sanity checks in single Run All, and make tests depend on it's > successful pass. > > > Regards, > *Petr Ivanov* > Head of IT > IT & Development Solutions | > *GRIDGAIN SYSTEMS*+7 (911) 945-00-59 > > On 24 Feb 2021, at 19:58, Max Timonin w

Re: [DISCUSS] Missed (non-suited) tests

2021-02-25 Thread Max Timonin
the absence of -DskipTests flag trigger ALL the tests for all >> modules? >> This flag was added intentionally. >> >> Instead, I'd put Non-Suited tests into some kind of sanity check, group >> all sanity checks in single Run All, and make tests depend on it's >> suc

TeamCity agent aitc-lin07_04 fails to run Build

2021-02-23 Thread Max Timonin
Hi! My "Build" runs on TC fail with on 1 (Step: Cleanup local maven repository (Command Line)) Error is related to AI 3.0.0: + rm -rfv /opt/buildagent/.m2/repository/org/apache/ignite rm: cannot remove '/opt/buildagent/.m2/repository/org/apache/ignite/ignite-configuration/

Re: Re[2]: [DISCUSSION] Apache Ignite Release 2.10 (time, scope, manager)

2021-02-18 Thread Max Timonin
Hi! I've today found an issue [1], there is wrong handling of inlined POJO. This bug appeared in 2.9.0 and makes it impossible to work with multi-column indexes created on old AI versions that contain inlined POJO keys in the middle. I'm working on the fix and asked Konstantin Orlov to review it.