Re: IGNITE-6879: Support Spring Data 2.0

[Dmitry Pavlov]

Hi Roman, Igniters,

I've merged these changes to master and it goes to 2.6.

Roman, thank you for contribution and your reminders about review.

Peter Ivanov, thank you for setting up tests.

Alexey Kukushkin, Dmitriy Ryabov, thank you for review.

Igniters, please note Spring Data suite may fail for PRs because
of ignite-spring-data_2.0 module is absent in these branches.

Sincerely,
Dmitriy Pavlov

вт, 8 мая 2018 г. в 15:55, Dmitry Pavlov :

> Hi Roman,
>
> now TC passes for 1.0. In the same time new suite is not executed on TC.
>
> I've asked Peter Ivanov to assist in TC run set up for Spring Data 2.0.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 7 мая 2018 г. в 18:23, Роман Меерсон :
>
>> Dmitry, I leave comment at issue. As i may see localy problem with tests
>> was fixed
>>
>> пн, 7 мая 2018 г. в 17:24, Dmitry Pavlov :
>>
>>> Hi, I've replied to ticket, seems old tests are now failing after
>>> applying patch locally.
>>>
>>> I've also added 2 suites to TC
>>> TEST_SUITE =IgniteSpringDataTestSuite,IgniteSpringData2TestSuite
>>> to
>>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpringData
>>>
>>> so this suite will check both integrations. Ideally we could run this
>>> suite one more time before merge.
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> пн, 7 мая 2018 г. в 15:46, Dmitry Pavlov :
>>>
 Hi Roman,

 Currently I'm checking the changes. Because of applying idea to copy
 all changes and upsource problem with this branch it is quite complex to
 locate actual changes. It is now required to check all copied files before
 merge.

 Sincerely,
 Dmitriy Pavlov

 пн, 7 мая 2018 г. в 11:07, Роман Меерсон :

> Hello Dmitry!
>
> was review successfull? Or there are any points to change?
>
> сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :
>
>> Ok! I believe in community and that things would change!
>> Looking forward for news
>> сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :
>>
>>> I hope so!
>>>
>>> There was several posts related to review time, and AI community is
>>> now trying to reduce it. Now it is about 70 tickets waiting to be merged
>>> more than 1month. This defenetely should be changed. And I hope all 
>>> Ignite
>>> committers and maintainters would continue to assist in this.
>>>
>>> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>>>
 Hi all!

 Soon we'll celebrate 2 months of my PR :)
 Maybe it could be merged?
 пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :

> No, nothing yet. I'm going to look to new version.
>
> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>
>> Hi all!
>>
>> Are there any news about PR merging?
>>
>> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон > >:
>>
>>> Denis,
>>>
>>> module naming fixed
>>>
>>> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>>>
 Roman,

 In my last reply, I voted for your approach - using
 "spring-data*_*2.0" for
 the new Spring version. However, please note that we use "_"
 symbol instead
 of "-" to separate a version from the package name.

 --
 Denis

 On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон <
 homich1...@gmail.com> wrote:

 > Hi all!
 >
 > So guys let’s make a decision. We leave code in current state
 as I suggest
 > or change module naming according Dmitry’s suggestion.
 > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
 >
 > > Roman,
 > >
 > > Your suggestion sounds reasonable to me. Backing it up.
 > >
 > > --
 > > Denis
 > >
 > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
 homich1...@gmail.com>
 > > wrote:
 > >
 > > > Hi all!
 > > >
 > > > IMHO if we do so we'll produce big pain for everybody
 while migrating
 > on
 > > > new version, because ones should change method and others
 should change
 > > > their poms. This change would be backward incompatible so
 it probably
 > > > should follow with major version upgrade, but I'm not
 sure about it.
 > > >
 > > > Otherwise if we leave current state( spring-data 

[GitHub] ignite pull request #3704: IGNITE-6879 and migration to spring-data 2.0.5.RE...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3704


---

Re: IGNITE-6879

[Dmitry Pavlov]

Hi Roman,

now TC passes for 1.0. In the same time new suite is not executed on TC.

I've asked Peter Ivanov to assist in TC run set up for Spring Data 2.0.

Sincerely,
Dmitriy Pavlov

пн, 7 мая 2018 г. в 18:23, Роман Меерсон :

> Dmitry, I leave comment at issue. As i may see localy problem with tests
> was fixed
>
> пн, 7 мая 2018 г. в 17:24, Dmitry Pavlov :
>
>> Hi, I've replied to ticket, seems old tests are now failing after
>> applying patch locally.
>>
>> I've also added 2 suites to TC
>> TEST_SUITE =IgniteSpringDataTestSuite,IgniteSpringData2TestSuite
>> to
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpringData
>>
>> so this suite will check both integrations. Ideally we could run this
>> suite one more time before merge.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пн, 7 мая 2018 г. в 15:46, Dmitry Pavlov :
>>
>>> Hi Roman,
>>>
>>> Currently I'm checking the changes. Because of applying idea to copy all
>>> changes and upsource problem with this branch it is quite complex to locate
>>> actual changes. It is now required to check all copied files before merge.
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> пн, 7 мая 2018 г. в 11:07, Роман Меерсон :
>>>
 Hello Dmitry!

 was review successfull? Or there are any points to change?

 сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :

> Ok! I believe in community and that things would change!
> Looking forward for news
> сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :
>
>> I hope so!
>>
>> There was several posts related to review time, and AI community is
>> now trying to reduce it. Now it is about 70 tickets waiting to be merged
>> more than 1month. This defenetely should be changed. And I hope all 
>> Ignite
>> committers and maintainters would continue to assist in this.
>>
>> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>>
>>> Hi all!
>>>
>>> Soon we'll celebrate 2 months of my PR :)
>>> Maybe it could be merged?
>>> пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
>>>
 No, nothing yet. I'm going to look to new version.

 пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :

> Hi all!
>
> Are there any news about PR merging?
>
> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>
>> Denis,
>>
>> module naming fixed
>>
>> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>>
>>> Roman,
>>>
>>> In my last reply, I voted for your approach - using
>>> "spring-data*_*2.0" for
>>> the new Spring version. However, please note that we use "_"
>>> symbol instead
>>> of "-" to separate a version from the package name.
>>>
>>> --
>>> Denis
>>>
>>> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон <
>>> homich1...@gmail.com> wrote:
>>>
>>> > Hi all!
>>> >
>>> > So guys let’s make a decision. We leave code in current state
>>> as I suggest
>>> > or change module naming according Dmitry’s suggestion.
>>> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>>> >
>>> > > Roman,
>>> > >
>>> > > Your suggestion sounds reasonable to me. Backing it up.
>>> > >
>>> > > --
>>> > > Denis
>>> > >
>>> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
>>> homich1...@gmail.com>
>>> > > wrote:
>>> > >
>>> > > > Hi all!
>>> > > >
>>> > > > IMHO if we do so we'll produce big pain for everybody
>>> while migrating
>>> > on
>>> > > > new version, because ones should change method and others
>>> should change
>>> > > > their poms. This change would be backward incompatible so
>>> it probably
>>> > > > should follow with major version upgrade, but I'm not sure
>>> about it.
>>> > > >
>>> > > > Otherwise if we leave current state( spring-data for old
>>> and
>>> > > > spring-data-2.0 for new) we could support old users who
>>> probably use
>>> > > spring
>>> > > > data 1.0 (because spring data 2.0 release was not so long
>>> ago) and
>>> > > provide
>>> > > > new functionality for users who want to use new spring
>>> data.
>>> > > > In this case old users wouldn't change any in their code
>>> except ignite
>>> > > > version, and new users would include ignite in their Pom
>>> anyway and
>>> > could
>>> > > > choose which module of spring 

Re: IGNITE-6879

[Роман Меерсон]

Dmitry, I leave comment at issue. As i may see localy problem with tests
was fixed

пн, 7 мая 2018 г. в 17:24, Dmitry Pavlov :

> Hi, I've replied to ticket, seems old tests are now failing after applying
> patch locally.
>
> I've also added 2 suites to TC
> TEST_SUITE =IgniteSpringDataTestSuite,IgniteSpringData2TestSuite
> to
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpringData
>
> so this suite will check both integrations. Ideally we could run this
> suite one more time before merge.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 7 мая 2018 г. в 15:46, Dmitry Pavlov :
>
>> Hi Roman,
>>
>> Currently I'm checking the changes. Because of applying idea to copy all
>> changes and upsource problem with this branch it is quite complex to locate
>> actual changes. It is now required to check all copied files before merge.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пн, 7 мая 2018 г. в 11:07, Роман Меерсон :
>>
>>> Hello Dmitry!
>>>
>>> was review successfull? Or there are any points to change?
>>>
>>> сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :
>>>
 Ok! I believe in community and that things would change!
 Looking forward for news
 сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :

> I hope so!
>
> There was several posts related to review time, and AI community is
> now trying to reduce it. Now it is about 70 tickets waiting to be merged
> more than 1month. This defenetely should be changed. And I hope all Ignite
> committers and maintainters would continue to assist in this.
>
> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>
>> Hi all!
>>
>> Soon we'll celebrate 2 months of my PR :)
>> Maybe it could be merged?
>> пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
>>
>>> No, nothing yet. I'm going to look to new version.
>>>
>>> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>>>
 Hi all!

 Are there any news about PR merging?

 пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :

> Denis,
>
> module naming fixed
>
> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>
>> Roman,
>>
>> In my last reply, I voted for your approach - using
>> "spring-data*_*2.0" for
>> the new Spring version. However, please note that we use "_"
>> symbol instead
>> of "-" to separate a version from the package name.
>>
>> --
>> Denis
>>
>> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон <
>> homich1...@gmail.com> wrote:
>>
>> > Hi all!
>> >
>> > So guys let’s make a decision. We leave code in current state
>> as I suggest
>> > or change module naming according Dmitry’s suggestion.
>> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>> >
>> > > Roman,
>> > >
>> > > Your suggestion sounds reasonable to me. Backing it up.
>> > >
>> > > --
>> > > Denis
>> > >
>> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
>> homich1...@gmail.com>
>> > > wrote:
>> > >
>> > > > Hi all!
>> > > >
>> > > > IMHO if we do so we'll produce big pain for everybody while
>> migrating
>> > on
>> > > > new version, because ones should change method and others
>> should change
>> > > > their poms. This change would be backward incompatible so
>> it probably
>> > > > should follow with major version upgrade, but I'm not sure
>> about it.
>> > > >
>> > > > Otherwise if we leave current state( spring-data for old and
>> > > > spring-data-2.0 for new) we could support old users who
>> probably use
>> > > spring
>> > > > data 1.0 (because spring data 2.0 release was not so long
>> ago) and
>> > > provide
>> > > > new functionality for users who want to use new spring data.
>> > > > In this case old users wouldn't change any in their code
>> except ignite
>> > > > version, and new users would include ignite in their Pom
>> anyway and
>> > could
>> > > > choose which module of spring data to bring.
>> > > >
>> > > > After some time (probably on 3.0 release) we could change
>> naming as
>> > Denis
>> > > > suggested.
>> > > >
>> > > > Anyway I leave this decision up to you, just tell me what
>> is the way to
>> > > > finish this PR.
>> > > >
>> > > > Regards, Roman.
>> > > >
>> > > > ср, 11 

Re: IGNITE-6879

[Dmitry Pavlov]

Hi, I've replied to ticket, seems old tests are now failing after applying
patch locally.

I've also added 2 suites to TC
TEST_SUITE =IgniteSpringDataTestSuite,IgniteSpringData2TestSuite
to
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpringData

so this suite will check both integrations. Ideally we could run this suite
one more time before merge.

Sincerely,
Dmitriy Pavlov

пн, 7 мая 2018 г. в 15:46, Dmitry Pavlov :

> Hi Roman,
>
> Currently I'm checking the changes. Because of applying idea to copy all
> changes and upsource problem with this branch it is quite complex to locate
> actual changes. It is now required to check all copied files before merge.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 7 мая 2018 г. в 11:07, Роман Меерсон :
>
>> Hello Dmitry!
>>
>> was review successfull? Or there are any points to change?
>>
>> сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :
>>
>>> Ok! I believe in community and that things would change!
>>> Looking forward for news
>>> сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :
>>>
 I hope so!

 There was several posts related to review time, and AI community is now
 trying to reduce it. Now it is about 70 tickets waiting to be merged more
 than 1month. This defenetely should be changed. And I hope all Ignite
 committers and maintainters would continue to assist in this.

 сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :

> Hi all!
>
> Soon we'll celebrate 2 months of my PR :)
> Maybe it could be merged?
> пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
>
>> No, nothing yet. I'm going to look to new version.
>>
>> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>>
>>> Hi all!
>>>
>>> Are there any news about PR merging?
>>>
>>> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>>>
 Denis,

 module naming fixed

 пн, 16 апр. 2018 г. в 19:24, Denis Magda :

> Roman,
>
> In my last reply, I voted for your approach - using
> "spring-data*_*2.0" for
> the new Spring version. However, please note that we use "_"
> symbol instead
> of "-" to separate a version from the package name.
>
> --
> Denis
>
> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон <
> homich1...@gmail.com> wrote:
>
> > Hi all!
> >
> > So guys let’s make a decision. We leave code in current state as
> I suggest
> > or change module naming according Dmitry’s suggestion.
> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
> >
> > > Roman,
> > >
> > > Your suggestion sounds reasonable to me. Backing it up.
> > >
> > > --
> > > Denis
> > >
> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
> homich1...@gmail.com>
> > > wrote:
> > >
> > > > Hi all!
> > > >
> > > > IMHO if we do so we'll produce big pain for everybody while
> migrating
> > on
> > > > new version, because ones should change method and others
> should change
> > > > their poms. This change would be backward incompatible so it
> probably
> > > > should follow with major version upgrade, but I'm not sure
> about it.
> > > >
> > > > Otherwise if we leave current state( spring-data for old and
> > > > spring-data-2.0 for new) we could support old users who
> probably use
> > > spring
> > > > data 1.0 (because spring data 2.0 release was not so long
> ago) and
> > > provide
> > > > new functionality for users who want to use new spring data.
> > > > In this case old users wouldn't change any in their code
> except ignite
> > > > version, and new users would include ignite in their Pom
> anyway and
> > could
> > > > choose which module of spring data to bring.
> > > >
> > > > After some time (probably on 3.0 release) we could change
> naming as
> > Denis
> > > > suggested.
> > > >
> > > > Anyway I leave this decision up to you, just tell me what is
> the way to
> > > > finish this PR.
> > > >
> > > > Regards, Roman.
> > > >
> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
> > > >
> > > > > In our Hibernate integration we define following two
> modules to
> > > > > distinguish incompatible versions:
> > > > >
> > > > >- ignite-hiberbate_4.2
> > > > >- 

Re: IGNITE-6879

[Dmitry Pavlov]

Hi Roman,

Currently I'm checking the changes. Because of applying idea to copy all
changes and upsource problem with this branch it is quite complex to locate
actual changes. It is now required to check all copied files before merge.

Sincerely,
Dmitriy Pavlov

пн, 7 мая 2018 г. в 11:07, Роман Меерсон :

> Hello Dmitry!
>
> was review successfull? Or there are any points to change?
>
> сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :
>
>> Ok! I believe in community and that things would change!
>> Looking forward for news
>> сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :
>>
>>> I hope so!
>>>
>>> There was several posts related to review time, and AI community is now
>>> trying to reduce it. Now it is about 70 tickets waiting to be merged more
>>> than 1month. This defenetely should be changed. And I hope all Ignite
>>> committers and maintainters would continue to assist in this.
>>>
>>> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>>>
 Hi all!

 Soon we'll celebrate 2 months of my PR :)
 Maybe it could be merged?
 пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :

> No, nothing yet. I'm going to look to new version.
>
> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>
>> Hi all!
>>
>> Are there any news about PR merging?
>>
>> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>>
>>> Denis,
>>>
>>> module naming fixed
>>>
>>> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>>>
 Roman,

 In my last reply, I voted for your approach - using
 "spring-data*_*2.0" for
 the new Spring version. However, please note that we use "_" symbol
 instead
 of "-" to separate a version from the package name.

 --
 Denis

 On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон <
 homich1...@gmail.com> wrote:

 > Hi all!
 >
 > So guys let’s make a decision. We leave code in current state as
 I suggest
 > or change module naming according Dmitry’s suggestion.
 > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
 >
 > > Roman,
 > >
 > > Your suggestion sounds reasonable to me. Backing it up.
 > >
 > > --
 > > Denis
 > >
 > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
 homich1...@gmail.com>
 > > wrote:
 > >
 > > > Hi all!
 > > >
 > > > IMHO if we do so we'll produce big pain for everybody while
 migrating
 > on
 > > > new version, because ones should change method and others
 should change
 > > > their poms. This change would be backward incompatible so it
 probably
 > > > should follow with major version upgrade, but I'm not sure
 about it.
 > > >
 > > > Otherwise if we leave current state( spring-data for old and
 > > > spring-data-2.0 for new) we could support old users who
 probably use
 > > spring
 > > > data 1.0 (because spring data 2.0 release was not so long
 ago) and
 > > provide
 > > > new functionality for users who want to use new spring data.
 > > > In this case old users wouldn't change any in their code
 except ignite
 > > > version, and new users would include ignite in their Pom
 anyway and
 > could
 > > > choose which module of spring data to bring.
 > > >
 > > > After some time (probably on 3.0 release) we could change
 naming as
 > Denis
 > > > suggested.
 > > >
 > > > Anyway I leave this decision up to you, just tell me what is
 the way to
 > > > finish this PR.
 > > >
 > > > Regards, Roman.
 > > >
 > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
 > > >
 > > > > In our Hibernate integration we define following two
 modules to
 > > > > distinguish incompatible versions:
 > > > >
 > > > >- ignite-hiberbate_4.2
 > > > >- ignite-hibernate_5.1
 > > > >
 > > > > In Spark we have:
 > > > >
 > > > >- ignite-spark
 > > > >- ignite-spark_2.10
 > > > >
 > > > > After thinking this over, I would do the following with
 Spring Data:
 > > > >
 > > > >- ignite-spring-data for the latest Sprind Data 2.0
 > > > >- ignite-spring-data_1.0
 > > > >
 > > > > What do you think?
 > > > >
 > > > > --
 > > > > Denis
 > > > >
 > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
 

Re: IGNITE-6879

[Роман Меерсон]

Hello Dmitry!

was review successfull? Or there are any points to change?

сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :

> Ok! I believe in community and that things would change!
> Looking forward for news
> сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :
>
>> I hope so!
>>
>> There was several posts related to review time, and AI community is now
>> trying to reduce it. Now it is about 70 tickets waiting to be merged more
>> than 1month. This defenetely should be changed. And I hope all Ignite
>> committers and maintainters would continue to assist in this.
>>
>> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>>
>>> Hi all!
>>>
>>> Soon we'll celebrate 2 months of my PR :)
>>> Maybe it could be merged?
>>> пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
>>>
 No, nothing yet. I'm going to look to new version.

 пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :

> Hi all!
>
> Are there any news about PR merging?
>
> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>
>> Denis,
>>
>> module naming fixed
>>
>> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>>
>>> Roman,
>>>
>>> In my last reply, I voted for your approach - using
>>> "spring-data*_*2.0" for
>>> the new Spring version. However, please note that we use "_" symbol
>>> instead
>>> of "-" to separate a version from the package name.
>>>
>>> --
>>> Denis
>>>
>>> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
>>> wrote:
>>>
>>> > Hi all!
>>> >
>>> > So guys let’s make a decision. We leave code in current state as I
>>> suggest
>>> > or change module naming according Dmitry’s suggestion.
>>> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>>> >
>>> > > Roman,
>>> > >
>>> > > Your suggestion sounds reasonable to me. Backing it up.
>>> > >
>>> > > --
>>> > > Denis
>>> > >
>>> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
>>> homich1...@gmail.com>
>>> > > wrote:
>>> > >
>>> > > > Hi all!
>>> > > >
>>> > > > IMHO if we do so we'll produce big pain for everybody while
>>> migrating
>>> > on
>>> > > > new version, because ones should change method and others
>>> should change
>>> > > > their poms. This change would be backward incompatible so it
>>> probably
>>> > > > should follow with major version upgrade, but I'm not sure
>>> about it.
>>> > > >
>>> > > > Otherwise if we leave current state( spring-data for old and
>>> > > > spring-data-2.0 for new) we could support old users who
>>> probably use
>>> > > spring
>>> > > > data 1.0 (because spring data 2.0 release was not so long ago)
>>> and
>>> > > provide
>>> > > > new functionality for users who want to use new spring data.
>>> > > > In this case old users wouldn't change any in their code
>>> except ignite
>>> > > > version, and new users would include ignite in their Pom
>>> anyway and
>>> > could
>>> > > > choose which module of spring data to bring.
>>> > > >
>>> > > > After some time (probably on 3.0 release) we could change
>>> naming as
>>> > Denis
>>> > > > suggested.
>>> > > >
>>> > > > Anyway I leave this decision up to you, just tell me what is
>>> the way to
>>> > > > finish this PR.
>>> > > >
>>> > > > Regards, Roman.
>>> > > >
>>> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
>>> > > >
>>> > > > > In our Hibernate integration we define following two modules
>>> to
>>> > > > > distinguish incompatible versions:
>>> > > > >
>>> > > > >- ignite-hiberbate_4.2
>>> > > > >- ignite-hibernate_5.1
>>> > > > >
>>> > > > > In Spark we have:
>>> > > > >
>>> > > > >- ignite-spark
>>> > > > >- ignite-spark_2.10
>>> > > > >
>>> > > > > After thinking this over, I would do the following with
>>> Spring Data:
>>> > > > >
>>> > > > >- ignite-spring-data for the latest Sprind Data 2.0
>>> > > > >- ignite-spring-data_1.0
>>> > > > >
>>> > > > > What do you think?
>>> > > > >
>>> > > > > --
>>> > > > > Denis
>>> > > > >
>>> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
>>> > dpavlov@gmail.com>
>>> > > > > wrote:
>>> > > > >
>>> > > > >> Thank you, Roman.
>>> > > > >>
>>> > > > >> Igniters,
>>> > > > >>
>>> > > > >> IMO we should consider one more alternative - renaming of
>>> old module
>>> > > and
>>> > > > >> package names. Users, which prefer to stay on previous
>>> version will
>>> > be
>>> > > > >> requiered to update their pom's. In the same time users
>>> which are

Re: IGNITE-6879

[Роман Меерсон]

Ok! I believe in community and that things would change!
Looking forward for news
сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :

> I hope so!
>
> There was several posts related to review time, and AI community is now
> trying to reduce it. Now it is about 70 tickets waiting to be merged more
> than 1month. This defenetely should be changed. And I hope all Ignite
> committers and maintainters would continue to assist in this.
>
> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>
>> Hi all!
>>
>> Soon we'll celebrate 2 months of my PR :)
>> Maybe it could be merged?
>> пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
>>
>>> No, nothing yet. I'm going to look to new version.
>>>
>>> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>>>
 Hi all!

 Are there any news about PR merging?

 пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :

> Denis,
>
> module naming fixed
>
> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>
>> Roman,
>>
>> In my last reply, I voted for your approach - using
>> "spring-data*_*2.0" for
>> the new Spring version. However, please note that we use "_" symbol
>> instead
>> of "-" to separate a version from the package name.
>>
>> --
>> Denis
>>
>> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
>> wrote:
>>
>> > Hi all!
>> >
>> > So guys let’s make a decision. We leave code in current state as I
>> suggest
>> > or change module naming according Dmitry’s suggestion.
>> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>> >
>> > > Roman,
>> > >
>> > > Your suggestion sounds reasonable to me. Backing it up.
>> > >
>> > > --
>> > > Denis
>> > >
>> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
>> homich1...@gmail.com>
>> > > wrote:
>> > >
>> > > > Hi all!
>> > > >
>> > > > IMHO if we do so we'll produce big pain for everybody while
>> migrating
>> > on
>> > > > new version, because ones should change method and others
>> should change
>> > > > their poms. This change would be backward incompatible so it
>> probably
>> > > > should follow with major version upgrade, but I'm not sure
>> about it.
>> > > >
>> > > > Otherwise if we leave current state( spring-data for old and
>> > > > spring-data-2.0 for new) we could support old users who
>> probably use
>> > > spring
>> > > > data 1.0 (because spring data 2.0 release was not so long ago)
>> and
>> > > provide
>> > > > new functionality for users who want to use new spring data.
>> > > > In this case old users wouldn't change any in their code except
>> ignite
>> > > > version, and new users would include ignite in their Pom anyway
>> and
>> > could
>> > > > choose which module of spring data to bring.
>> > > >
>> > > > After some time (probably on 3.0 release) we could change
>> naming as
>> > Denis
>> > > > suggested.
>> > > >
>> > > > Anyway I leave this decision up to you, just tell me what is
>> the way to
>> > > > finish this PR.
>> > > >
>> > > > Regards, Roman.
>> > > >
>> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
>> > > >
>> > > > > In our Hibernate integration we define following two modules
>> to
>> > > > > distinguish incompatible versions:
>> > > > >
>> > > > >- ignite-hiberbate_4.2
>> > > > >- ignite-hibernate_5.1
>> > > > >
>> > > > > In Spark we have:
>> > > > >
>> > > > >- ignite-spark
>> > > > >- ignite-spark_2.10
>> > > > >
>> > > > > After thinking this over, I would do the following with
>> Spring Data:
>> > > > >
>> > > > >- ignite-spring-data for the latest Sprind Data 2.0
>> > > > >- ignite-spring-data_1.0
>> > > > >
>> > > > > What do you think?
>> > > > >
>> > > > > --
>> > > > > Denis
>> > > > >
>> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
>> > dpavlov@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > >> Thank you, Roman.
>> > > > >>
>> > > > >> Igniters,
>> > > > >>
>> > > > >> IMO we should consider one more alternative - renaming of
>> old module
>> > > and
>> > > > >> package names. Users, which prefer to stay on previous
>> version will
>> > be
>> > > > >> requiered to update their pom's. In the same time users
>> which are
>> > > ready
>> > > > to
>> > > > >> migrate to spring data 2.0 will need to update methods
>> naming.
>> > > > >>
>> > > > >> Denis M, what would you say?
>> > > > >>
>> > > > >> Sincerely,
>> > > > >> Dmitriy Pavlov
>> > > > >>
>> > > > >> вт, 10 

Re: IGNITE-6879

[Dmitry Pavlov]

I hope so!

There was several posts related to review time, and AI community is now
trying to reduce it. Now it is about 70 tickets waiting to be merged more
than 1month. This defenetely should be changed. And I hope all Ignite
committers and maintainters would continue to assist in this.

сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :

> Hi all!
>
> Soon we'll celebrate 2 months of my PR :)
> Maybe it could be merged?
> пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
>
>> No, nothing yet. I'm going to look to new version.
>>
>> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>>
>>> Hi all!
>>>
>>> Are there any news about PR merging?
>>>
>>> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>>>
 Denis,

 module naming fixed

 пн, 16 апр. 2018 г. в 19:24, Denis Magda :

> Roman,
>
> In my last reply, I voted for your approach - using
> "spring-data*_*2.0" for
> the new Spring version. However, please note that we use "_" symbol
> instead
> of "-" to separate a version from the package name.
>
> --
> Denis
>
> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
> wrote:
>
> > Hi all!
> >
> > So guys let’s make a decision. We leave code in current state as I
> suggest
> > or change module naming according Dmitry’s suggestion.
> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
> >
> > > Roman,
> > >
> > > Your suggestion sounds reasonable to me. Backing it up.
> > >
> > > --
> > > Denis
> > >
> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
> homich1...@gmail.com>
> > > wrote:
> > >
> > > > Hi all!
> > > >
> > > > IMHO if we do so we'll produce big pain for everybody while
> migrating
> > on
> > > > new version, because ones should change method and others should
> change
> > > > their poms. This change would be backward incompatible so it
> probably
> > > > should follow with major version upgrade, but I'm not sure about
> it.
> > > >
> > > > Otherwise if we leave current state( spring-data for old and
> > > > spring-data-2.0 for new) we could support old users who probably
> use
> > > spring
> > > > data 1.0 (because spring data 2.0 release was not so long ago)
> and
> > > provide
> > > > new functionality for users who want to use new spring data.
> > > > In this case old users wouldn't change any in their code except
> ignite
> > > > version, and new users would include ignite in their Pom anyway
> and
> > could
> > > > choose which module of spring data to bring.
> > > >
> > > > After some time (probably on 3.0 release) we could change naming
> as
> > Denis
> > > > suggested.
> > > >
> > > > Anyway I leave this decision up to you, just tell me what is the
> way to
> > > > finish this PR.
> > > >
> > > > Regards, Roman.
> > > >
> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
> > > >
> > > > > In our Hibernate integration we define following two modules to
> > > > > distinguish incompatible versions:
> > > > >
> > > > >- ignite-hiberbate_4.2
> > > > >- ignite-hibernate_5.1
> > > > >
> > > > > In Spark we have:
> > > > >
> > > > >- ignite-spark
> > > > >- ignite-spark_2.10
> > > > >
> > > > > After thinking this over, I would do the following with Spring
> Data:
> > > > >
> > > > >- ignite-spring-data for the latest Sprind Data 2.0
> > > > >- ignite-spring-data_1.0
> > > > >
> > > > > What do you think?
> > > > >
> > > > > --
> > > > > Denis
> > > > >
> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
> > dpavlov@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> Thank you, Roman.
> > > > >>
> > > > >> Igniters,
> > > > >>
> > > > >> IMO we should consider one more alternative - renaming of old
> module
> > > and
> > > > >> package names. Users, which prefer to stay on previous
> version will
> > be
> > > > >> requiered to update their pom's. In the same time users which
> are
> > > ready
> > > > to
> > > > >> migrate to spring data 2.0 will need to update methods naming.
> > > > >>
> > > > >> Denis M, what would you say?
> > > > >>
> > > > >> Sincerely,
> > > > >> Dmitriy Pavlov
> > > > >>
> > > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон <
> homich1...@gmail.com>:
> > > > >>
> > > > >>> Hi Dmitry!
> > > > >>>
> > > > >>> I`ve just commited new fix. I renamed package of new module
> to
> > > > >>> springdata20, it helps us to separate old implementation
> from new
> > and
> > > > 

Re: IGNITE-6879

[Роман Меерсон]

Hi all!

Soon we'll celebrate 2 months of my PR :)
Maybe it could be merged?
пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :

> No, nothing yet. I'm going to look to new version.
>
> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>
>> Hi all!
>>
>> Are there any news about PR merging?
>>
>> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>>
>>> Denis,
>>>
>>> module naming fixed
>>>
>>> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>>>
 Roman,

 In my last reply, I voted for your approach - using "spring-data*_*2.0"
 for
 the new Spring version. However, please note that we use "_" symbol
 instead
 of "-" to separate a version from the package name.

 --
 Denis

 On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
 wrote:

 > Hi all!
 >
 > So guys let’s make a decision. We leave code in current state as I
 suggest
 > or change module naming according Dmitry’s suggestion.
 > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
 >
 > > Roman,
 > >
 > > Your suggestion sounds reasonable to me. Backing it up.
 > >
 > > --
 > > Denis
 > >
 > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <
 homich1...@gmail.com>
 > > wrote:
 > >
 > > > Hi all!
 > > >
 > > > IMHO if we do so we'll produce big pain for everybody while
 migrating
 > on
 > > > new version, because ones should change method and others should
 change
 > > > their poms. This change would be backward incompatible so it
 probably
 > > > should follow with major version upgrade, but I'm not sure about
 it.
 > > >
 > > > Otherwise if we leave current state( spring-data for old and
 > > > spring-data-2.0 for new) we could support old users who probably
 use
 > > spring
 > > > data 1.0 (because spring data 2.0 release was not so long ago) and
 > > provide
 > > > new functionality for users who want to use new spring data.
 > > > In this case old users wouldn't change any in their code except
 ignite
 > > > version, and new users would include ignite in their Pom anyway
 and
 > could
 > > > choose which module of spring data to bring.
 > > >
 > > > After some time (probably on 3.0 release) we could change naming
 as
 > Denis
 > > > suggested.
 > > >
 > > > Anyway I leave this decision up to you, just tell me what is the
 way to
 > > > finish this PR.
 > > >
 > > > Regards, Roman.
 > > >
 > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
 > > >
 > > > > In our Hibernate integration we define following two modules to
 > > > > distinguish incompatible versions:
 > > > >
 > > > >- ignite-hiberbate_4.2
 > > > >- ignite-hibernate_5.1
 > > > >
 > > > > In Spark we have:
 > > > >
 > > > >- ignite-spark
 > > > >- ignite-spark_2.10
 > > > >
 > > > > After thinking this over, I would do the following with Spring
 Data:
 > > > >
 > > > >- ignite-spring-data for the latest Sprind Data 2.0
 > > > >- ignite-spring-data_1.0
 > > > >
 > > > > What do you think?
 > > > >
 > > > > --
 > > > > Denis
 > > > >
 > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
 > dpavlov@gmail.com>
 > > > > wrote:
 > > > >
 > > > >> Thank you, Roman.
 > > > >>
 > > > >> Igniters,
 > > > >>
 > > > >> IMO we should consider one more alternative - renaming of old
 module
 > > and
 > > > >> package names. Users, which prefer to stay on previous version
 will
 > be
 > > > >> requiered to update their pom's. In the same time users which
 are
 > > ready
 > > > to
 > > > >> migrate to spring data 2.0 will need to update methods naming.
 > > > >>
 > > > >> Denis M, what would you say?
 > > > >>
 > > > >> Sincerely,
 > > > >> Dmitriy Pavlov
 > > > >>
 > > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон <
 homich1...@gmail.com>:
 > > > >>
 > > > >>> Hi Dmitry!
 > > > >>>
 > > > >>> I`ve just commited new fix. I renamed package of new module to
 > > > >>> springdata20, it helps us to separate old implementation from
 new
 > and
 > > > also
 > > > >>> should fix all compilation errors.
 > > > >>>
 > > > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон <
 homich1...@gmail.com>:
 > > > >>>
 > > >  Ok, I'll check it, but I haven't face this problem.
 > > >  If I'll find same issue, what is the proper way? Renaming to
 > > something
 > > >  like Ignite2QueryGenerator or module removing?
 > > >  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov <
 dpavlov@gmail.com
 > >:
 > > > 
 > > > > 

Re: IGNITE-6879

[Dmitry Pavlov]

No, nothing yet. I'm going to look to new version.

пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :

> Hi all!
>
> Are there any news about PR merging?
>
> пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
>
>> Denis,
>>
>> module naming fixed
>>
>> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>>
>>> Roman,
>>>
>>> In my last reply, I voted for your approach - using "spring-data*_*2.0"
>>> for
>>> the new Spring version. However, please note that we use "_" symbol
>>> instead
>>> of "-" to separate a version from the package name.
>>>
>>> --
>>> Denis
>>>
>>> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
>>> wrote:
>>>
>>> > Hi all!
>>> >
>>> > So guys let’s make a decision. We leave code in current state as I
>>> suggest
>>> > or change module naming according Dmitry’s suggestion.
>>> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>>> >
>>> > > Roman,
>>> > >
>>> > > Your suggestion sounds reasonable to me. Backing it up.
>>> > >
>>> > > --
>>> > > Denis
>>> > >
>>> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон >> >
>>> > > wrote:
>>> > >
>>> > > > Hi all!
>>> > > >
>>> > > > IMHO if we do so we'll produce big pain for everybody while
>>> migrating
>>> > on
>>> > > > new version, because ones should change method and others should
>>> change
>>> > > > their poms. This change would be backward incompatible so it
>>> probably
>>> > > > should follow with major version upgrade, but I'm not sure about
>>> it.
>>> > > >
>>> > > > Otherwise if we leave current state( spring-data for old and
>>> > > > spring-data-2.0 for new) we could support old users who probably
>>> use
>>> > > spring
>>> > > > data 1.0 (because spring data 2.0 release was not so long ago) and
>>> > > provide
>>> > > > new functionality for users who want to use new spring data.
>>> > > > In this case old users wouldn't change any in their code except
>>> ignite
>>> > > > version, and new users would include ignite in their Pom anyway and
>>> > could
>>> > > > choose which module of spring data to bring.
>>> > > >
>>> > > > After some time (probably on 3.0 release) we could change naming as
>>> > Denis
>>> > > > suggested.
>>> > > >
>>> > > > Anyway I leave this decision up to you, just tell me what is the
>>> way to
>>> > > > finish this PR.
>>> > > >
>>> > > > Regards, Roman.
>>> > > >
>>> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
>>> > > >
>>> > > > > In our Hibernate integration we define following two modules to
>>> > > > > distinguish incompatible versions:
>>> > > > >
>>> > > > >- ignite-hiberbate_4.2
>>> > > > >- ignite-hibernate_5.1
>>> > > > >
>>> > > > > In Spark we have:
>>> > > > >
>>> > > > >- ignite-spark
>>> > > > >- ignite-spark_2.10
>>> > > > >
>>> > > > > After thinking this over, I would do the following with Spring
>>> Data:
>>> > > > >
>>> > > > >- ignite-spring-data for the latest Sprind Data 2.0
>>> > > > >- ignite-spring-data_1.0
>>> > > > >
>>> > > > > What do you think?
>>> > > > >
>>> > > > > --
>>> > > > > Denis
>>> > > > >
>>> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
>>> > dpavlov@gmail.com>
>>> > > > > wrote:
>>> > > > >
>>> > > > >> Thank you, Roman.
>>> > > > >>
>>> > > > >> Igniters,
>>> > > > >>
>>> > > > >> IMO we should consider one more alternative - renaming of old
>>> module
>>> > > and
>>> > > > >> package names. Users, which prefer to stay on previous version
>>> will
>>> > be
>>> > > > >> requiered to update their pom's. In the same time users which
>>> are
>>> > > ready
>>> > > > to
>>> > > > >> migrate to spring data 2.0 will need to update methods naming.
>>> > > > >>
>>> > > > >> Denis M, what would you say?
>>> > > > >>
>>> > > > >> Sincerely,
>>> > > > >> Dmitriy Pavlov
>>> > > > >>
>>> > > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон <
>>> homich1...@gmail.com>:
>>> > > > >>
>>> > > > >>> Hi Dmitry!
>>> > > > >>>
>>> > > > >>> I`ve just commited new fix. I renamed package of new module to
>>> > > > >>> springdata20, it helps us to separate old implementation from
>>> new
>>> > and
>>> > > > also
>>> > > > >>> should fix all compilation errors.
>>> > > > >>>
>>> > > > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон <
>>> homich1...@gmail.com>:
>>> > > > >>>
>>> > > >  Ok, I'll check it, but I haven't face this problem.
>>> > > >  If I'll find same issue, what is the proper way? Renaming to
>>> > > something
>>> > > >  like Ignite2QueryGenerator or module removing?
>>> > > >  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov <
>>> dpavlov@gmail.com
>>> > >:
>>> > > > 
>>> > > > > There are 2 classes IgniteQueryGenerator with same package
>>> name.
>>> > > > > Ignite in Idea can't compile.
>>> > > > >
>>> > > > >
>>> > > > > пн, 9 апр. 2018 г., 21:38 Роман Меерсон <
>>> homich1...@gmail.com>:
>>> > > > >
>>> > > > >> Hi Dmitry!
>>> > > > >
>>> > > > >
>>> > 

Re: IGNITE-6879

[Роман Меерсон]

Hi all!

Are there any news about PR merging?

пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :

> Denis,
>
> module naming fixed
>
> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>
>> Roman,
>>
>> In my last reply, I voted for your approach - using "spring-data*_*2.0"
>> for
>> the new Spring version. However, please note that we use "_" symbol
>> instead
>> of "-" to separate a version from the package name.
>>
>> --
>> Denis
>>
>> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
>> wrote:
>>
>> > Hi all!
>> >
>> > So guys let’s make a decision. We leave code in current state as I
>> suggest
>> > or change module naming according Dmitry’s suggestion.
>> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>> >
>> > > Roman,
>> > >
>> > > Your suggestion sounds reasonable to me. Backing it up.
>> > >
>> > > --
>> > > Denis
>> > >
>> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон 
>> > > wrote:
>> > >
>> > > > Hi all!
>> > > >
>> > > > IMHO if we do so we'll produce big pain for everybody while
>> migrating
>> > on
>> > > > new version, because ones should change method and others should
>> change
>> > > > their poms. This change would be backward incompatible so it
>> probably
>> > > > should follow with major version upgrade, but I'm not sure about it.
>> > > >
>> > > > Otherwise if we leave current state( spring-data for old and
>> > > > spring-data-2.0 for new) we could support old users who probably use
>> > > spring
>> > > > data 1.0 (because spring data 2.0 release was not so long ago) and
>> > > provide
>> > > > new functionality for users who want to use new spring data.
>> > > > In this case old users wouldn't change any in their code except
>> ignite
>> > > > version, and new users would include ignite in their Pom anyway and
>> > could
>> > > > choose which module of spring data to bring.
>> > > >
>> > > > After some time (probably on 3.0 release) we could change naming as
>> > Denis
>> > > > suggested.
>> > > >
>> > > > Anyway I leave this decision up to you, just tell me what is the
>> way to
>> > > > finish this PR.
>> > > >
>> > > > Regards, Roman.
>> > > >
>> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
>> > > >
>> > > > > In our Hibernate integration we define following two modules to
>> > > > > distinguish incompatible versions:
>> > > > >
>> > > > >- ignite-hiberbate_4.2
>> > > > >- ignite-hibernate_5.1
>> > > > >
>> > > > > In Spark we have:
>> > > > >
>> > > > >- ignite-spark
>> > > > >- ignite-spark_2.10
>> > > > >
>> > > > > After thinking this over, I would do the following with Spring
>> Data:
>> > > > >
>> > > > >- ignite-spring-data for the latest Sprind Data 2.0
>> > > > >- ignite-spring-data_1.0
>> > > > >
>> > > > > What do you think?
>> > > > >
>> > > > > --
>> > > > > Denis
>> > > > >
>> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
>> > dpavlov@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > >> Thank you, Roman.
>> > > > >>
>> > > > >> Igniters,
>> > > > >>
>> > > > >> IMO we should consider one more alternative - renaming of old
>> module
>> > > and
>> > > > >> package names. Users, which prefer to stay on previous version
>> will
>> > be
>> > > > >> requiered to update their pom's. In the same time users which are
>> > > ready
>> > > > to
>> > > > >> migrate to spring data 2.0 will need to update methods naming.
>> > > > >>
>> > > > >> Denis M, what would you say?
>> > > > >>
>> > > > >> Sincerely,
>> > > > >> Dmitriy Pavlov
>> > > > >>
>> > > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон > >:
>> > > > >>
>> > > > >>> Hi Dmitry!
>> > > > >>>
>> > > > >>> I`ve just commited new fix. I renamed package of new module to
>> > > > >>> springdata20, it helps us to separate old implementation from
>> new
>> > and
>> > > > also
>> > > > >>> should fix all compilation errors.
>> > > > >>>
>> > > > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон > >:
>> > > > >>>
>> > > >  Ok, I'll check it, but I haven't face this problem.
>> > > >  If I'll find same issue, what is the proper way? Renaming to
>> > > something
>> > > >  like Ignite2QueryGenerator or module removing?
>> > > >  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov <
>> dpavlov@gmail.com
>> > >:
>> > > > 
>> > > > > There are 2 classes IgniteQueryGenerator with same package
>> name.
>> > > > > Ignite in Idea can't compile.
>> > > > >
>> > > > >
>> > > > > пн, 9 апр. 2018 г., 21:38 Роман Меерсон > >:
>> > > > >
>> > > > >> Hi Dmitry!
>> > > > >
>> > > > >
>> > > > >> Could you specify where you find conflict? Because I don’t
>> have
>> > > any.
>> > > > >> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov <
>> > dpavlov@gmail.com
>> > > >:
>> > > > >>
>> > > > >>> Hi Denis,
>> > > > >>>
>> > > > >>> could we support just one version 

Re: IGNITE-6879

[Роман Меерсон]

Denis,

module naming fixed

пн, 16 апр. 2018 г. в 19:24, Denis Magda :

> Roman,
>
> In my last reply, I voted for your approach - using "spring-data*_*2.0" for
> the new Spring version. However, please note that we use "_" symbol instead
> of "-" to separate a version from the package name.
>
> --
> Denis
>
> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон 
> wrote:
>
> > Hi all!
> >
> > So guys let’s make a decision. We leave code in current state as I
> suggest
> > or change module naming according Dmitry’s suggestion.
> > ср, 11 апр. 2018 г. в 1:54, Denis Magda :
> >
> > > Roman,
> > >
> > > Your suggestion sounds reasonable to me. Backing it up.
> > >
> > > --
> > > Denis
> > >
> > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон 
> > > wrote:
> > >
> > > > Hi all!
> > > >
> > > > IMHO if we do so we'll produce big pain for everybody while migrating
> > on
> > > > new version, because ones should change method and others should
> change
> > > > their poms. This change would be backward incompatible so it probably
> > > > should follow with major version upgrade, but I'm not sure about it.
> > > >
> > > > Otherwise if we leave current state( spring-data for old and
> > > > spring-data-2.0 for new) we could support old users who probably use
> > > spring
> > > > data 1.0 (because spring data 2.0 release was not so long ago) and
> > > provide
> > > > new functionality for users who want to use new spring data.
> > > > In this case old users wouldn't change any in their code except
> ignite
> > > > version, and new users would include ignite in their Pom anyway and
> > could
> > > > choose which module of spring data to bring.
> > > >
> > > > After some time (probably on 3.0 release) we could change naming as
> > Denis
> > > > suggested.
> > > >
> > > > Anyway I leave this decision up to you, just tell me what is the way
> to
> > > > finish this PR.
> > > >
> > > > Regards, Roman.
> > > >
> > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
> > > >
> > > > > In our Hibernate integration we define following two modules to
> > > > > distinguish incompatible versions:
> > > > >
> > > > >- ignite-hiberbate_4.2
> > > > >- ignite-hibernate_5.1
> > > > >
> > > > > In Spark we have:
> > > > >
> > > > >- ignite-spark
> > > > >- ignite-spark_2.10
> > > > >
> > > > > After thinking this over, I would do the following with Spring
> Data:
> > > > >
> > > > >- ignite-spring-data for the latest Sprind Data 2.0
> > > > >- ignite-spring-data_1.0
> > > > >
> > > > > What do you think?
> > > > >
> > > > > --
> > > > > Denis
> > > > >
> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
> > dpavlov@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> Thank you, Roman.
> > > > >>
> > > > >> Igniters,
> > > > >>
> > > > >> IMO we should consider one more alternative - renaming of old
> module
> > > and
> > > > >> package names. Users, which prefer to stay on previous version
> will
> > be
> > > > >> requiered to update their pom's. In the same time users which are
> > > ready
> > > > to
> > > > >> migrate to spring data 2.0 will need to update methods naming.
> > > > >>
> > > > >> Denis M, what would you say?
> > > > >>
> > > > >> Sincerely,
> > > > >> Dmitriy Pavlov
> > > > >>
> > > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон  >:
> > > > >>
> > > > >>> Hi Dmitry!
> > > > >>>
> > > > >>> I`ve just commited new fix. I renamed package of new module to
> > > > >>> springdata20, it helps us to separate old implementation from new
> > and
> > > > also
> > > > >>> should fix all compilation errors.
> > > > >>>
> > > > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон  >:
> > > > >>>
> > > >  Ok, I'll check it, but I haven't face this problem.
> > > >  If I'll find same issue, what is the proper way? Renaming to
> > > something
> > > >  like Ignite2QueryGenerator or module removing?
> > > >  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov <
> dpavlov@gmail.com
> > >:
> > > > 
> > > > > There are 2 classes IgniteQueryGenerator with same package
> name.
> > > > > Ignite in Idea can't compile.
> > > > >
> > > > >
> > > > > пн, 9 апр. 2018 г., 21:38 Роман Меерсон  >:
> > > > >
> > > > >> Hi Dmitry!
> > > > >
> > > > >
> > > > >> Could you specify where you find conflict? Because I don’t
> have
> > > any.
> > > > >> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov <
> > dpavlov@gmail.com
> > > >:
> > > > >>
> > > > >>> Hi Denis,
> > > > >>>
> > > > >>> could we support just one version instead of leaving
> compatible
> > > > >>> module?
> > > > >>>
> > > > >>> Sincerely,
> > > > >>> Dmitriy Pavlov
> > > > >>>
> > > > >>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov <
> > dpavlov@gmail.com
> > > >:
> > > > >>>
> > > > 
> > > > 

Re: IGNITE-6879

[Denis Magda]

Roman,

In my last reply, I voted for your approach - using "spring-data*_*2.0" for
the new Spring version. However, please note that we use "_" symbol instead
of "-" to separate a version from the package name.

--
Denis

On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон  wrote:

> Hi all!
>
> So guys let’s make a decision. We leave code in current state as I suggest
> or change module naming according Dmitry’s suggestion.
> ср, 11 апр. 2018 г. в 1:54, Denis Magda :
>
> > Roman,
> >
> > Your suggestion sounds reasonable to me. Backing it up.
> >
> > --
> > Denis
> >
> > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон 
> > wrote:
> >
> > > Hi all!
> > >
> > > IMHO if we do so we'll produce big pain for everybody while migrating
> on
> > > new version, because ones should change method and others should change
> > > their poms. This change would be backward incompatible so it probably
> > > should follow with major version upgrade, but I'm not sure about it.
> > >
> > > Otherwise if we leave current state( spring-data for old and
> > > spring-data-2.0 for new) we could support old users who probably use
> > spring
> > > data 1.0 (because spring data 2.0 release was not so long ago) and
> > provide
> > > new functionality for users who want to use new spring data.
> > > In this case old users wouldn't change any in their code except ignite
> > > version, and new users would include ignite in their Pom anyway and
> could
> > > choose which module of spring data to bring.
> > >
> > > After some time (probably on 3.0 release) we could change naming as
> Denis
> > > suggested.
> > >
> > > Anyway I leave this decision up to you, just tell me what is the way to
> > > finish this PR.
> > >
> > > Regards, Roman.
> > >
> > > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
> > >
> > > > In our Hibernate integration we define following two modules to
> > > > distinguish incompatible versions:
> > > >
> > > >- ignite-hiberbate_4.2
> > > >- ignite-hibernate_5.1
> > > >
> > > > In Spark we have:
> > > >
> > > >- ignite-spark
> > > >- ignite-spark_2.10
> > > >
> > > > After thinking this over, I would do the following with Spring Data:
> > > >
> > > >- ignite-spring-data for the latest Sprind Data 2.0
> > > >- ignite-spring-data_1.0
> > > >
> > > > What do you think?
> > > >
> > > > --
> > > > Denis
> > > >
> > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <
> dpavlov@gmail.com>
> > > > wrote:
> > > >
> > > >> Thank you, Roman.
> > > >>
> > > >> Igniters,
> > > >>
> > > >> IMO we should consider one more alternative - renaming of old module
> > and
> > > >> package names. Users, which prefer to stay on previous version will
> be
> > > >> requiered to update their pom's. In the same time users which are
> > ready
> > > to
> > > >> migrate to spring data 2.0 will need to update methods naming.
> > > >>
> > > >> Denis M, what would you say?
> > > >>
> > > >> Sincerely,
> > > >> Dmitriy Pavlov
> > > >>
> > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон :
> > > >>
> > > >>> Hi Dmitry!
> > > >>>
> > > >>> I`ve just commited new fix. I renamed package of new module to
> > > >>> springdata20, it helps us to separate old implementation from new
> and
> > > also
> > > >>> should fix all compilation errors.
> > > >>>
> > > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
> > > >>>
> > >  Ok, I'll check it, but I haven't face this problem.
> > >  If I'll find same issue, what is the proper way? Renaming to
> > something
> > >  like Ignite2QueryGenerator or module removing?
> > >  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov  >:
> > > 
> > > > There are 2 classes IgniteQueryGenerator with same package name.
> > > > Ignite in Idea can't compile.
> > > >
> > > >
> > > > пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
> > > >
> > > >> Hi Dmitry!
> > > >
> > > >
> > > >> Could you specify where you find conflict? Because I don’t have
> > any.
> > > >> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov <
> dpavlov@gmail.com
> > >:
> > > >>
> > > >>> Hi Denis,
> > > >>>
> > > >>> could we support just one version instead of leaving compatible
> > > >>> module?
> > > >>>
> > > >>> Sincerely,
> > > >>> Dmitriy Pavlov
> > > >>>
> > > >>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov <
> dpavlov@gmail.com
> > >:
> > > >>>
> > > 
> > > 
> > >  пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov <
> > dpavlov@gmail.com
> > > >:
> > > 
> > > > Hi Roman,
> > > >
> > > > I've applied PR locally and I have class name conflict at
> least
> > > > for
> > > > org.apache.ignite.springdata.repository.query.
> > > IgniteQueryGenerator
> > > >
> > > > How could we solve it? Is it better to 

Re: IGNITE-6879

[Роман Меерсон]

Hi all!

So guys let’s make a decision. We leave code in current state as I suggest
or change module naming according Dmitry’s suggestion.
ср, 11 апр. 2018 г. в 1:54, Denis Magda :

> Roman,
>
> Your suggestion sounds reasonable to me. Backing it up.
>
> --
> Denis
>
> On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон 
> wrote:
>
> > Hi all!
> >
> > IMHO if we do so we'll produce big pain for everybody while migrating on
> > new version, because ones should change method and others should change
> > their poms. This change would be backward incompatible so it probably
> > should follow with major version upgrade, but I'm not sure about it.
> >
> > Otherwise if we leave current state( spring-data for old and
> > spring-data-2.0 for new) we could support old users who probably use
> spring
> > data 1.0 (because spring data 2.0 release was not so long ago) and
> provide
> > new functionality for users who want to use new spring data.
> > In this case old users wouldn't change any in their code except ignite
> > version, and new users would include ignite in their Pom anyway and could
> > choose which module of spring data to bring.
> >
> > After some time (probably on 3.0 release) we could change naming as Denis
> > suggested.
> >
> > Anyway I leave this decision up to you, just tell me what is the way to
> > finish this PR.
> >
> > Regards, Roman.
> >
> > ср, 11 апр. 2018 г. в 1:35, Denis Magda :
> >
> > > In our Hibernate integration we define following two modules to
> > > distinguish incompatible versions:
> > >
> > >- ignite-hiberbate_4.2
> > >- ignite-hibernate_5.1
> > >
> > > In Spark we have:
> > >
> > >- ignite-spark
> > >- ignite-spark_2.10
> > >
> > > After thinking this over, I would do the following with Spring Data:
> > >
> > >- ignite-spring-data for the latest Sprind Data 2.0
> > >- ignite-spring-data_1.0
> > >
> > > What do you think?
> > >
> > > --
> > > Denis
> > >
> > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov 
> > > wrote:
> > >
> > >> Thank you, Roman.
> > >>
> > >> Igniters,
> > >>
> > >> IMO we should consider one more alternative - renaming of old module
> and
> > >> package names. Users, which prefer to stay on previous version will be
> > >> requiered to update their pom's. In the same time users which are
> ready
> > to
> > >> migrate to spring data 2.0 will need to update methods naming.
> > >>
> > >> Denis M, what would you say?
> > >>
> > >> Sincerely,
> > >> Dmitriy Pavlov
> > >>
> > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон :
> > >>
> > >>> Hi Dmitry!
> > >>>
> > >>> I`ve just commited new fix. I renamed package of new module to
> > >>> springdata20, it helps us to separate old implementation from new and
> > also
> > >>> should fix all compilation errors.
> > >>>
> > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
> > >>>
> >  Ok, I'll check it, but I haven't face this problem.
> >  If I'll find same issue, what is the proper way? Renaming to
> something
> >  like Ignite2QueryGenerator or module removing?
> >  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :
> > 
> > > There are 2 classes IgniteQueryGenerator with same package name.
> > > Ignite in Idea can't compile.
> > >
> > >
> > > пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
> > >
> > >> Hi Dmitry!
> > >
> > >
> > >> Could you specify where you find conflict? Because I don’t have
> any.
> > >> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov  >:
> > >>
> > >>> Hi Denis,
> > >>>
> > >>> could we support just one version instead of leaving compatible
> > >>> module?
> > >>>
> > >>> Sincerely,
> > >>> Dmitriy Pavlov
> > >>>
> > >>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov  >:
> > >>>
> > 
> > 
> >  пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov <
> dpavlov@gmail.com
> > >:
> > 
> > > Hi Roman,
> > >
> > > I've applied PR locally and I have class name conflict at least
> > > for
> > > org.apache.ignite.springdata.repository.query.
> > IgniteQueryGenerator
> > >
> > > How could we solve it? Is it better to rename class for new
> > plugin
> > > version?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov <
> dpavlov@gmail.com
> > >:
> > >
> > >> Excellend picture. I remember about this change.
> > >>
> > >> If Denis M. would be able to look througt the changes faster
> > than
> > >> me, I can merge without detailed review.
> > >>
> > >> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон <
> homich1...@gmail.com
> > >:
> > >>
> > >>> OK
> > 

Re: IGNITE-6879

[Denis Magda]

Roman,

Your suggestion sounds reasonable to me. Backing it up.

--
Denis

On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон  wrote:

> Hi all!
>
> IMHO if we do so we'll produce big pain for everybody while migrating on
> new version, because ones should change method and others should change
> their poms. This change would be backward incompatible so it probably
> should follow with major version upgrade, but I'm not sure about it.
>
> Otherwise if we leave current state( spring-data for old and
> spring-data-2.0 for new) we could support old users who probably use spring
> data 1.0 (because spring data 2.0 release was not so long ago) and provide
> new functionality for users who want to use new spring data.
> In this case old users wouldn't change any in their code except ignite
> version, and new users would include ignite in their Pom anyway and could
> choose which module of spring data to bring.
>
> After some time (probably on 3.0 release) we could change naming as Denis
> suggested.
>
> Anyway I leave this decision up to you, just tell me what is the way to
> finish this PR.
>
> Regards, Roman.
>
> ср, 11 апр. 2018 г. в 1:35, Denis Magda :
>
> > In our Hibernate integration we define following two modules to
> > distinguish incompatible versions:
> >
> >- ignite-hiberbate_4.2
> >- ignite-hibernate_5.1
> >
> > In Spark we have:
> >
> >- ignite-spark
> >- ignite-spark_2.10
> >
> > After thinking this over, I would do the following with Spring Data:
> >
> >- ignite-spring-data for the latest Sprind Data 2.0
> >- ignite-spring-data_1.0
> >
> > What do you think?
> >
> > --
> > Denis
> >
> > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov 
> > wrote:
> >
> >> Thank you, Roman.
> >>
> >> Igniters,
> >>
> >> IMO we should consider one more alternative - renaming of old module and
> >> package names. Users, which prefer to stay on previous version will be
> >> requiered to update their pom's. In the same time users which are ready
> to
> >> migrate to spring data 2.0 will need to update methods naming.
> >>
> >> Denis M, what would you say?
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
> >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон :
> >>
> >>> Hi Dmitry!
> >>>
> >>> I`ve just commited new fix. I renamed package of new module to
> >>> springdata20, it helps us to separate old implementation from new and
> also
> >>> should fix all compilation errors.
> >>>
> >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
> >>>
>  Ok, I'll check it, but I haven't face this problem.
>  If I'll find same issue, what is the proper way? Renaming to something
>  like Ignite2QueryGenerator or module removing?
>  пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :
> 
> > There are 2 classes IgniteQueryGenerator with same package name.
> > Ignite in Idea can't compile.
> >
> >
> > пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
> >
> >> Hi Dmitry!
> >
> >
> >> Could you specify where you find conflict? Because I don’t have any.
> >> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
> >>
> >>> Hi Denis,
> >>>
> >>> could we support just one version instead of leaving compatible
> >>> module?
> >>>
> >>> Sincerely,
> >>> Dmitriy Pavlov
> >>>
> >>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
> >>>
> 
> 
>  пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov  >:
> 
> > Hi Roman,
> >
> > I've applied PR locally and I have class name conflict at least
> > for
> > org.apache.ignite.springdata.repository.query.
> IgniteQueryGenerator
> >
> > How could we solve it? Is it better to rename class for new
> plugin
> > version?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov  >:
> >
> >> Excellend picture. I remember about this change.
> >>
> >> If Denis M. would be able to look througt the changes faster
> than
> >> me, I can merge without detailed review.
> >>
> >> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон  >:
> >>
> >>> OK
> >>>
> >>> [image: 1486924635147168240.jpg]
> >>>
> >>>
> >>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
> >>>
>  Hi,
>  Well, Dmitry has said he's going to merge it in 3-4 days 2
> days
>  ago,
>  so I guess, the merge is going to happen in 1-2 days or so.
> 
> 
>  Best Regards,
>  Igor
> 
>  On Fri, Apr 6, 2018 at 3:48 PM, Роман 

Re: IGNITE-6879

[Роман Меерсон]

Hi all!

IMHO if we do so we'll produce big pain for everybody while migrating on
new version, because ones should change method and others should change
their poms. This change would be backward incompatible so it probably
should follow with major version upgrade, but I'm not sure about it.

Otherwise if we leave current state( spring-data for old and
spring-data-2.0 for new) we could support old users who probably use spring
data 1.0 (because spring data 2.0 release was not so long ago) and provide
new functionality for users who want to use new spring data.
In this case old users wouldn't change any in their code except ignite
version, and new users would include ignite in their Pom anyway and could
choose which module of spring data to bring.

After some time (probably on 3.0 release) we could change naming as Denis
suggested.

Anyway I leave this decision up to you, just tell me what is the way to
finish this PR.

Regards, Roman.

ср, 11 апр. 2018 г. в 1:35, Denis Magda :

> In our Hibernate integration we define following two modules to
> distinguish incompatible versions:
>
>- ignite-hiberbate_4.2
>- ignite-hibernate_5.1
>
> In Spark we have:
>
>- ignite-spark
>- ignite-spark_2.10
>
> After thinking this over, I would do the following with Spring Data:
>
>- ignite-spring-data for the latest Sprind Data 2.0
>- ignite-spring-data_1.0
>
> What do you think?
>
> --
> Denis
>
> On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov 
> wrote:
>
>> Thank you, Roman.
>>
>> Igniters,
>>
>> IMO we should consider one more alternative - renaming of old module and
>> package names. Users, which prefer to stay on previous version will be
>> requiered to update their pom's. In the same time users which are ready to
>> migrate to spring data 2.0 will need to update methods naming.
>>
>> Denis M, what would you say?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон :
>>
>>> Hi Dmitry!
>>>
>>> I`ve just commited new fix. I renamed package of new module to
>>> springdata20, it helps us to separate old implementation from new and also
>>> should fix all compilation errors.
>>>
>>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
>>>
 Ok, I'll check it, but I haven't face this problem.
 If I'll find same issue, what is the proper way? Renaming to something
 like Ignite2QueryGenerator or module removing?
 пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :

> There are 2 classes IgniteQueryGenerator with same package name.
> Ignite in Idea can't compile.
>
>
> пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
>
>> Hi Dmitry!
>
>
>> Could you specify where you find conflict? Because I don’t have any.
>> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
>>
>>> Hi Denis,
>>>
>>> could we support just one version instead of leaving compatible
>>> module?
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
>>>


 пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :

> Hi Roman,
>
> I've applied PR locally and I have class name conflict at least
> for
> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator
>
> How could we solve it? Is it better to rename class for new plugin
> version?
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :
>
>> Excellend picture. I remember about this change.
>>
>> If Denis M. would be able to look througt the changes faster than
>> me, I can merge without detailed review.
>>
>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>>
>>> OK
>>>
>>> [image: 1486924635147168240.jpg]
>>>
>>>
>>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>>>
 Hi,
 Well, Dmitry has said he's going to merge it in 3-4 days 2 days
 ago,
 so I guess, the merge is going to happen in 1-2 days or so.


 Best Regards,
 Igor

 On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон <
 homich1...@gmail.com> wrote:

 > Hi all!
 >
 > As i see everything is awesome and there is no objections, so
 when my PR
 > would be merged?
 >
 > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
 slava.kopti...@gmail.com>:
 >
 > > Thank you, Roman!
 > >
 > > 2018-04-05 

Re: IGNITE-6879

[Denis Magda]

In our Hibernate integration we define following two modules to distinguish
incompatible versions:

   - ignite-hiberbate_4.2
   - ignite-hibernate_5.1

In Spark we have:

   - ignite-spark
   - ignite-spark_2.10

After thinking this over, I would do the following with Spring Data:

   - ignite-spring-data for the latest Sprind Data 2.0
   - ignite-spring-data_1.0

What do you think?

--
Denis

On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov 
wrote:

> Thank you, Roman.
>
> Igniters,
>
> IMO we should consider one more alternative - renaming of old module and
> package names. Users, which prefer to stay on previous version will be
> requiered to update their pom's. In the same time users which are ready to
> migrate to spring data 2.0 will need to update methods naming.
>
> Denis M, what would you say?
>
> Sincerely,
> Dmitriy Pavlov
>
> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон :
>
>> Hi Dmitry!
>>
>> I`ve just commited new fix. I renamed package of new module to
>> springdata20, it helps us to separate old implementation from new and also
>> should fix all compilation errors.
>>
>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
>>
>>> Ok, I'll check it, but I haven't face this problem.
>>> If I'll find same issue, what is the proper way? Renaming to something
>>> like Ignite2QueryGenerator or module removing?
>>> пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :
>>>
 There are 2 classes IgniteQueryGenerator with same package name. Ignite
 in Idea can't compile.


 пн, 9 апр. 2018 г., 21:38 Роман Меерсон :

> Hi Dmitry!


> Could you specify where you find conflict? Because I don’t have any.
> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
>
>> Hi Denis,
>>
>> could we support just one version instead of leaving compatible
>> module?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
>>
>>>
>>>
>>> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :
>>>
 Hi Roman,

 I've applied PR locally and I have class name conflict at least for
 org.apache.ignite.springdata.repository.query.IgniteQueryGenerator

 How could we solve it? Is it better to rename class for new plugin
 version?

 Sincerely,
 Dmitriy Pavlov

 пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :

> Excellend picture. I remember about this change.
>
> If Denis M. would be able to look througt the changes faster than
> me, I can merge without detailed review.
>
> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>
>> OK
>>
>> [image: 1486924635147168240.jpg]
>>
>>
>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>>
>>> Hi,
>>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days
>>> ago,
>>> so I guess, the merge is going to happen in 1-2 days or so.
>>>
>>>
>>> Best Regards,
>>> Igor
>>>
>>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон <
>>> homich1...@gmail.com> wrote:
>>>
>>> > Hi all!
>>> >
>>> > As i see everything is awesome and there is no objections, so
>>> when my PR
>>> > would be merged?
>>> >
>>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
>>> slava.kopti...@gmail.com>:
>>> >
>>> > > Thank you, Roman!
>>> > >
>>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон <
>>> homich1...@gmail.com>:
>>> > >
>>> > > > Hi Slava,
>>> > > >
>>> > > > Fixed
>>> > > >
>>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
>>> > slava.kopti...@gmail.com
>>> > > >:
>>> > > >
>>> > > > > Hi Roman,
>>> > > > >
>>> > > > > please take into account my comment
>>> IgniteQueryGenerator.java
>>> > > > > <
>>> > > > > https://reviews.ignite.apache.
>>> org/ignite/review/IGNT-CR-541?
>>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
>>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
>>> > > > springdata/repository/query/IgniteQueryGenerator.java
>>> > > > > >
>>> > > > >
>>> > > > > Best regards,
>>> > > > > Slava.
>>> > > > >
>>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <
>>> homich1...@gmail.com>:
>>> > > > >
>>> > > > > > Ok, so waiting for accept and commit
>>> > > > > >
>>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey 

Re: IGNITE-6879

[Dmitry Pavlov]

Thank you, Roman.

Igniters,

IMO we should consider one more alternative - renaming of old module and
package names. Users, which prefer to stay on previous version will be
requiered to update their pom's. In the same time users which are ready to
migrate to spring data 2.0 will need to update methods naming.

Denis M, what would you say?

Sincerely,
Dmitriy Pavlov

вт, 10 апр. 2018 г. в 11:27, Роман Меерсон :

> Hi Dmitry!
>
> I`ve just commited new fix. I renamed package of new module to
> springdata20, it helps us to separate old implementation from new and also
> should fix all compilation errors.
>
> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
>
>> Ok, I'll check it, but I haven't face this problem.
>> If I'll find same issue, what is the proper way? Renaming to something
>> like Ignite2QueryGenerator or module removing?
>> пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :
>>
>>> There are 2 classes IgniteQueryGenerator with same package name. Ignite
>>> in Idea can't compile.
>>>
>>>
>>> пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
>>>
 Hi Dmitry!
>>>
>>>
 Could you specify where you find conflict? Because I don’t have any.
 пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :

> Hi Denis,
>
> could we support just one version instead of leaving compatible module?
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
>
>>
>>
>> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :
>>
>>> Hi Roman,
>>>
>>> I've applied PR locally and I have class name conflict at least for
>>> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator
>>>
>>> How could we solve it? Is it better to rename class for new plugin
>>> version?
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :
>>>
 Excellend picture. I remember about this change.

 If Denis M. would be able to look througt the changes faster than
 me, I can merge without detailed review.

 пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :

> OK
>
> [image: 1486924635147168240.jpg]
>
>
> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>
>> Hi,
>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days
>> ago,
>> so I guess, the merge is going to happen in 1-2 days or so.
>>
>>
>> Best Regards,
>> Igor
>>
>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон <
>> homich1...@gmail.com> wrote:
>>
>> > Hi all!
>> >
>> > As i see everything is awesome and there is no objections, so
>> when my PR
>> > would be merged?
>> >
>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
>> slava.kopti...@gmail.com>:
>> >
>> > > Thank you, Roman!
>> > >
>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон <
>> homich1...@gmail.com>:
>> > >
>> > > > Hi Slava,
>> > > >
>> > > > Fixed
>> > > >
>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
>> > slava.kopti...@gmail.com
>> > > >:
>> > > >
>> > > > > Hi Roman,
>> > > > >
>> > > > > please take into account my comment
>> IgniteQueryGenerator.java
>> > > > > <
>> > > > >
>> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
>> > > > springdata/repository/query/IgniteQueryGenerator.java
>> > > > > >
>> > > > >
>> > > > > Best regards,
>> > > > > Slava.
>> > > > >
>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <
>> homich1...@gmail.com>:
>> > > > >
>> > > > > > Ok, so waiting for accept and commit
>> > > > > >
>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
>> > > > kukushkinale...@gmail.com
>> > > > > >:
>> > > > > >
>> > > > > > > Roman,
>> > > > > > >
>> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely
>> commit your
>> > > code)
>> > > > > > > attention to include the new test suite to TeamCity
>> > configuration.
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: IGNITE-6879

[Роман Меерсон]

Hi Dmitry!

I`ve just commited new fix. I renamed package of new module to
springdata20, it helps us to separate old implementation from new and also
should fix all compilation errors.

пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :

> Ok, I'll check it, but I haven't face this problem.
> If I'll find same issue, what is the proper way? Renaming to something
> like Ignite2QueryGenerator or module removing?
> пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :
>
>> There are 2 classes IgniteQueryGenerator with same package name. Ignite
>> in Idea can't compile.
>>
>>
>> пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
>>
>>> Hi Dmitry!
>>
>>
>>> Could you specify where you find conflict? Because I don’t have any.
>>> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
>>>
 Hi Denis,

 could we support just one version instead of leaving compatible module?

 Sincerely,
 Dmitriy Pavlov

 пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :

>
>
> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :
>
>> Hi Roman,
>>
>> I've applied PR locally and I have class name conflict at least for
>> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator
>>
>> How could we solve it? Is it better to rename class for new plugin
>> version?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :
>>
>>> Excellend picture. I remember about this change.
>>>
>>> If Denis M. would be able to look througt the changes faster than
>>> me, I can merge without detailed review.
>>>
>>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>>>
 OK

 [image: 1486924635147168240.jpg]


 пт, 6 апр. 2018 г. в 17:08, Igor Sapego :

> Hi,
> Well, Dmitry has said he's going to merge it in 3-4 days 2 days
> ago,
> so I guess, the merge is going to happen in 1-2 days or so.
>
>
> Best Regards,
> Igor
>
> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон <
> homich1...@gmail.com> wrote:
>
> > Hi all!
> >
> > As i see everything is awesome and there is no objections, so
> when my PR
> > would be merged?
> >
> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
> slava.kopti...@gmail.com>:
> >
> > > Thank you, Roman!
> > >
> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон  >:
> > >
> > > > Hi Slava,
> > > >
> > > > Fixed
> > > >
> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
> > slava.kopti...@gmail.com
> > > >:
> > > >
> > > > > Hi Roman,
> > > > >
> > > > > please take into account my comment
> IgniteQueryGenerator.java
> > > > > <
> > > > >
> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
> > > > springdata/repository/query/IgniteQueryGenerator.java
> > > > > >
> > > > >
> > > > > Best regards,
> > > > > Slava.
> > > > >
> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <
> homich1...@gmail.com>:
> > > > >
> > > > > > Ok, so waiting for accept and commit
> > > > > >
> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
> > > > kukushkinale...@gmail.com
> > > > > >:
> > > > > >
> > > > > > > Roman,
> > > > > > >
> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely
> commit your
> > > code)
> > > > > > > attention to include the new test suite to TeamCity
> > configuration.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-6879

[Роман Меерсон]

Ok, I'll check it, but I haven't face this problem.
If I'll find same issue, what is the proper way? Renaming to something like
Ignite2QueryGenerator or module removing?
пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov :

> There are 2 classes IgniteQueryGenerator with same package name. Ignite in
> Idea can't compile.
>
>
> пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
>
>> Hi Dmitry!
>
>
>> Could you specify where you find conflict? Because I don’t have any.
>> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
>>
>>> Hi Denis,
>>>
>>> could we support just one version instead of leaving compatible module?
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
>>>


 пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :

> Hi Roman,
>
> I've applied PR locally and I have class name conflict at least for
> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator
>
> How could we solve it? Is it better to rename class for new plugin
> version?
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :
>
>> Excellend picture. I remember about this change.
>>
>> If Denis M. would be able to look througt the changes faster than me,
>> I can merge without detailed review.
>>
>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>>
>>> OK
>>>
>>> [image: 1486924635147168240.jpg]
>>>
>>>
>>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>>>
 Hi,
 Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
 so I guess, the merge is going to happen in 1-2 days or so.


 Best Regards,
 Igor

 On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
 wrote:

 > Hi all!
 >
 > As i see everything is awesome and there is no objections, so
 when my PR
 > would be merged?
 >
 > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
 slava.kopti...@gmail.com>:
 >
 > > Thank you, Roman!
 > >
 > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
 > >
 > > > Hi Slava,
 > > >
 > > > Fixed
 > > >
 > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
 > slava.kopti...@gmail.com
 > > >:
 > > >
 > > > > Hi Roman,
 > > > >
 > > > > please take into account my comment
 IgniteQueryGenerator.java
 > > > > <
 > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541
 ?
 > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
 > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
 > > > springdata/repository/query/IgniteQueryGenerator.java
 > > > > >
 > > > >
 > > > > Best regards,
 > > > > Slava.
 > > > >
 > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <
 homich1...@gmail.com>:
 > > > >
 > > > > > Ok, so waiting for accept and commit
 > > > > >
 > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
 > > > kukushkinale...@gmail.com
 > > > > >:
 > > > > >
 > > > > > > Roman,
 > > > > > >
 > > > > > > Just pay commiter's (Dmitry Pavlov will most likely
 commit your
 > > code)
 > > > > > > attention to include the new test suite to TeamCity
 > configuration.
 > > > > > >
 > > > > >
 > > > >
 > > >
 > >
 >

>>>

Re: IGNITE-6879

[Dmitry Pavlov]

There are 2 classes IgniteQueryGenerator with same package name. Ignite in
Idea can't compile.


пн, 9 апр. 2018 г., 21:38 Роман Меерсон :

> Hi Dmitry!
> Could you specify where you find conflict? Because I don’t have any.
> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
>
>> Hi Denis,
>>
>> could we support just one version instead of leaving compatible module?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
>>
>>>
>>>
>>> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :
>>>
 Hi Roman,

 I've applied PR locally and I have class name conflict at least for
 org.apache.ignite.springdata.repository.query.IgniteQueryGenerator

 How could we solve it? Is it better to rename class for new plugin
 version?

 Sincerely,
 Dmitriy Pavlov

 пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :

> Excellend picture. I remember about this change.
>
> If Denis M. would be able to look througt the changes faster than me,
> I can merge without detailed review.
>
> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>
>> OK
>>
>> [image: 1486924635147168240.jpg]
>>
>>
>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>>
>>> Hi,
>>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
>>> so I guess, the merge is going to happen in 1-2 days or so.
>>>
>>>
>>> Best Regards,
>>> Igor
>>>
>>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
>>> wrote:
>>>
>>> > Hi all!
>>> >
>>> > As i see everything is awesome and there is no objections, so when
>>> my PR
>>> > would be merged?
>>> >
>>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
>>> slava.kopti...@gmail.com>:
>>> >
>>> > > Thank you, Roman!
>>> > >
>>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
>>> > >
>>> > > > Hi Slava,
>>> > > >
>>> > > > Fixed
>>> > > >
>>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
>>> > slava.kopti...@gmail.com
>>> > > >:
>>> > > >
>>> > > > > Hi Roman,
>>> > > > >
>>> > > > > please take into account my comment IgniteQueryGenerator.java
>>> > > > > <
>>> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
>>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
>>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
>>> > > > springdata/repository/query/IgniteQueryGenerator.java
>>> > > > > >
>>> > > > >
>>> > > > > Best regards,
>>> > > > > Slava.
>>> > > > >
>>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <
>>> homich1...@gmail.com>:
>>> > > > >
>>> > > > > > Ok, so waiting for accept and commit
>>> > > > > >
>>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
>>> > > > kukushkinale...@gmail.com
>>> > > > > >:
>>> > > > > >
>>> > > > > > > Roman,
>>> > > > > > >
>>> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely
>>> commit your
>>> > > code)
>>> > > > > > > attention to include the new test suite to TeamCity
>>> > configuration.
>>> > > > > > >
>>> > > > > >
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>

Re: IGNITE-6879

[Роман Меерсон]

Hi Dmitry!
Could you specify where you find conflict? Because I don’t have any.
пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :

> Hi Denis,
>
> could we support just one version instead of leaving compatible module?
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :
>
>>
>>
>> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :
>>
>>> Hi Roman,
>>>
>>> I've applied PR locally and I have class name conflict at least for
>>> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator
>>>
>>> How could we solve it? Is it better to rename class for new plugin
>>> version?
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :
>>>
 Excellend picture. I remember about this change.

 If Denis M. would be able to look througt the changes faster than me, I
 can merge without detailed review.

 пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :

> OK
>
> [image: 1486924635147168240.jpg]
>
>
> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>
>> Hi,
>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
>> so I guess, the merge is going to happen in 1-2 days or so.
>>
>>
>> Best Regards,
>> Igor
>>
>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
>> wrote:
>>
>> > Hi all!
>> >
>> > As i see everything is awesome and there is no objections, so when
>> my PR
>> > would be merged?
>> >
>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
>> slava.kopti...@gmail.com>:
>> >
>> > > Thank you, Roman!
>> > >
>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
>> > >
>> > > > Hi Slava,
>> > > >
>> > > > Fixed
>> > > >
>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
>> > slava.kopti...@gmail.com
>> > > >:
>> > > >
>> > > > > Hi Roman,
>> > > > >
>> > > > > please take into account my comment IgniteQueryGenerator.java
>> > > > > <
>> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
>> > > > springdata/repository/query/IgniteQueryGenerator.java
>> > > > > >
>> > > > >
>> > > > > Best regards,
>> > > > > Slava.
>> > > > >
>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон <
>> homich1...@gmail.com>:
>> > > > >
>> > > > > > Ok, so waiting for accept and commit
>> > > > > >
>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
>> > > > kukushkinale...@gmail.com
>> > > > > >:
>> > > > > >
>> > > > > > > Roman,
>> > > > > > >
>> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely
>> commit your
>> > > code)
>> > > > > > > attention to include the new test suite to TeamCity
>> > configuration.
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: IGNITE-6879

[Dmitry Pavlov]

Hi Denis,

could we support just one version instead of leaving compatible module?

Sincerely,
Dmitriy Pavlov

пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov :

>
>
> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov :
>
>> Hi Roman,
>>
>> I've applied PR locally and I have class name conflict at least for
>> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator
>>
>> How could we solve it? Is it better to rename class for new plugin
>> version?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :
>>
>>> Excellend picture. I remember about this change.
>>>
>>> If Denis M. would be able to look througt the changes faster than me, I
>>> can merge without detailed review.
>>>
>>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>>>
 OK

 [image: 1486924635147168240.jpg]


 пт, 6 апр. 2018 г. в 17:08, Igor Sapego :

> Hi,
> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
> so I guess, the merge is going to happen in 1-2 days or so.
>
>
> Best Regards,
> Igor
>
> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
> wrote:
>
> > Hi all!
> >
> > As i see everything is awesome and there is no objections, so when
> my PR
> > would be merged?
> >
> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
> slava.kopti...@gmail.com>:
> >
> > > Thank you, Roman!
> > >
> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
> > >
> > > > Hi Slava,
> > > >
> > > > Fixed
> > > >
> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
> > slava.kopti...@gmail.com
> > > >:
> > > >
> > > > > Hi Roman,
> > > > >
> > > > > please take into account my comment IgniteQueryGenerator.java
> > > > > <
> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
> > > > springdata/repository/query/IgniteQueryGenerator.java
> > > > > >
> > > > >
> > > > > Best regards,
> > > > > Slava.
> > > > >
> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон  >:
> > > > >
> > > > > > Ok, so waiting for accept and commit
> > > > > >
> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
> > > > kukushkinale...@gmail.com
> > > > > >:
> > > > > >
> > > > > > > Roman,
> > > > > > >
> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely commit
> your
> > > code)
> > > > > > > attention to include the new test suite to TeamCity
> > configuration.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-6879

[Dmitry Pavlov]

Hi Roman,

I've applied PR locally and I have class name conflict at least for
org.apache.ignite.springdata.repository.query.IgniteQueryGenerator

How could we solve it? Is it better to rename class for new plugin version?

Sincerely,
Dmitriy Pavlov

пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov :

> Excellend picture. I remember about this change.
>
> If Denis M. would be able to look througt the changes faster than me, I
> can merge without detailed review.
>
> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>
>> OK
>>
>> [image: 1486924635147168240.jpg]
>>
>>
>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>>
>>> Hi,
>>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
>>> so I guess, the merge is going to happen in 1-2 days or so.
>>>
>>>
>>> Best Regards,
>>> Igor
>>>
>>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
>>> wrote:
>>>
>>> > Hi all!
>>> >
>>> > As i see everything is awesome and there is no objections, so when my
>>> PR
>>> > would be merged?
>>> >
>>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин <
>>> slava.kopti...@gmail.com>:
>>> >
>>> > > Thank you, Roman!
>>> > >
>>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
>>> > >
>>> > > > Hi Slava,
>>> > > >
>>> > > > Fixed
>>> > > >
>>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
>>> > slava.kopti...@gmail.com
>>> > > >:
>>> > > >
>>> > > > > Hi Roman,
>>> > > > >
>>> > > > > please take into account my comment IgniteQueryGenerator.java
>>> > > > > <
>>> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
>>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
>>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
>>> > > > springdata/repository/query/IgniteQueryGenerator.java
>>> > > > > >
>>> > > > >
>>> > > > > Best regards,
>>> > > > > Slava.
>>> > > > >
>>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
>>> > > > >
>>> > > > > > Ok, so waiting for accept and commit
>>> > > > > >
>>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
>>> > > > kukushkinale...@gmail.com
>>> > > > > >:
>>> > > > > >
>>> > > > > > > Roman,
>>> > > > > > >
>>> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely commit
>>> your
>>> > > code)
>>> > > > > > > attention to include the new test suite to TeamCity
>>> > configuration.
>>> > > > > > >
>>> > > > > >
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>

Re: IGNITE-6879

[Dmitry Pavlov]

Excellend picture. I remember about this change.

If Denis M. would be able to look througt the changes faster than me, I can
merge without detailed review.

пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :

> OK
>
> [image: 1486924635147168240.jpg]
>
>
> пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
>
>> Hi,
>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
>> so I guess, the merge is going to happen in 1-2 days or so.
>>
>>
>> Best Regards,
>> Igor
>>
>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
>> wrote:
>>
>> > Hi all!
>> >
>> > As i see everything is awesome and there is no objections, so when my PR
>> > would be merged?
>> >
>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин > >:
>> >
>> > > Thank you, Roman!
>> > >
>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
>> > >
>> > > > Hi Slava,
>> > > >
>> > > > Fixed
>> > > >
>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
>> > slava.kopti...@gmail.com
>> > > >:
>> > > >
>> > > > > Hi Roman,
>> > > > >
>> > > > > please take into account my comment IgniteQueryGenerator.java
>> > > > > <
>> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
>> > > > springdata/repository/query/IgniteQueryGenerator.java
>> > > > > >
>> > > > >
>> > > > > Best regards,
>> > > > > Slava.
>> > > > >
>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
>> > > > >
>> > > > > > Ok, so waiting for accept and commit
>> > > > > >
>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
>> > > > kukushkinale...@gmail.com
>> > > > > >:
>> > > > > >
>> > > > > > > Roman,
>> > > > > > >
>> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely commit
>> your
>> > > code)
>> > > > > > > attention to include the new test suite to TeamCity
>> > configuration.
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: IGNITE-6879

[Роман Меерсон]

OK

[image: 1486924635147168240.jpg]


пт, 6 апр. 2018 г. в 17:08, Igor Sapego :

> Hi,
> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
> so I guess, the merge is going to happen in 1-2 days or so.
>
>
> Best Regards,
> Igor
>
> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон 
> wrote:
>
> > Hi all!
> >
> > As i see everything is awesome and there is no objections, so when my PR
> > would be merged?
> >
> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин  >:
> >
> > > Thank you, Roman!
> > >
> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
> > >
> > > > Hi Slava,
> > > >
> > > > Fixed
> > > >
> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
> > slava.kopti...@gmail.com
> > > >:
> > > >
> > > > > Hi Roman,
> > > > >
> > > > > please take into account my comment IgniteQueryGenerator.java
> > > > > <
> > > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
> > > > springdata/repository/query/IgniteQueryGenerator.java
> > > > > >
> > > > >
> > > > > Best regards,
> > > > > Slava.
> > > > >
> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
> > > > >
> > > > > > Ok, so waiting for accept and commit
> > > > > >
> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
> > > > kukushkinale...@gmail.com
> > > > > >:
> > > > > >
> > > > > > > Roman,
> > > > > > >
> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely commit your
> > > code)
> > > > > > > attention to include the new test suite to TeamCity
> > configuration.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-6879

[Igor Sapego]

Hi,
Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
so I guess, the merge is going to happen in 1-2 days or so.


Best Regards,
Igor

On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон  wrote:

> Hi all!
>
> As i see everything is awesome and there is no objections, so when my PR
> would be merged?
>
> чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин :
>
> > Thank you, Roman!
> >
> > 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
> >
> > > Hi Slava,
> > >
> > > Fixed
> > >
> > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин <
> slava.kopti...@gmail.com
> > >:
> > >
> > > > Hi Roman,
> > > >
> > > > please take into account my comment IgniteQueryGenerator.java
> > > > <
> > > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
> > > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
> > > modules/spring-data-2.0/src/main/java/org/apache/ignite/
> > > springdata/repository/query/IgniteQueryGenerator.java
> > > > >
> > > >
> > > > Best regards,
> > > > Slava.
> > > >
> > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
> > > >
> > > > > Ok, so waiting for accept and commit
> > > > >
> > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
> > > kukushkinale...@gmail.com
> > > > >:
> > > > >
> > > > > > Roman,
> > > > > >
> > > > > > Just pay commiter's (Dmitry Pavlov will most likely commit your
> > code)
> > > > > > attention to include the new test suite to TeamCity
> configuration.
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-6879

[Роман Меерсон]

Hi all!

As i see everything is awesome and there is no objections, so when my PR
would be merged?

чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин :

> Thank you, Roman!
>
> 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
>
> > Hi Slava,
> >
> > Fixed
> >
> > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин  >:
> >
> > > Hi Roman,
> > >
> > > please take into account my comment IgniteQueryGenerator.java
> > > <
> > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
> > commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
> > modules/spring-data-2.0/src/main/java/org/apache/ignite/
> > springdata/repository/query/IgniteQueryGenerator.java
> > > >
> > >
> > > Best regards,
> > > Slava.
> > >
> > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
> > >
> > > > Ok, so waiting for accept and commit
> > > >
> > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
> > kukushkinale...@gmail.com
> > > >:
> > > >
> > > > > Roman,
> > > > >
> > > > > Just pay commiter's (Dmitry Pavlov will most likely commit your
> code)
> > > > > attention to include the new test suite to TeamCity configuration.
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-6879

[Вячеслав Коптилин]

Thank you, Roman!

2018-04-05 17:49 GMT+03:00 Роман Меерсон :

> Hi Slava,
>
> Fixed
>
> чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин :
>
> > Hi Roman,
> >
> > please take into account my comment IgniteQueryGenerator.java
> > <
> > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?
> commentId=de43c65f-9ac7-4080-9904-aec119138c94=/
> modules/spring-data-2.0/src/main/java/org/apache/ignite/
> springdata/repository/query/IgniteQueryGenerator.java
> > >
> >
> > Best regards,
> > Slava.
> >
> > 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
> >
> > > Ok, so waiting for accept and commit
> > >
> > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin <
> kukushkinale...@gmail.com
> > >:
> > >
> > > > Roman,
> > > >
> > > > Just pay commiter's (Dmitry Pavlov will most likely commit your code)
> > > > attention to include the new test suite to TeamCity configuration.
> > > >
> > >
> >
>

Re: IGNITE-6879

[Роман Меерсон]

Hi Slava,

Fixed

чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин :

> Hi Roman,
>
> please take into account my comment IgniteQueryGenerator.java
> <
> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?commentId=de43c65f-9ac7-4080-9904-aec119138c94=/modules/spring-data-2.0/src/main/java/org/apache/ignite/springdata/repository/query/IgniteQueryGenerator.java
> >
>
> Best regards,
> Slava.
>
> 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
>
> > Ok, so waiting for accept and commit
> >
> > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin  >:
> >
> > > Roman,
> > >
> > > Just pay commiter's (Dmitry Pavlov will most likely commit your code)
> > > attention to include the new test suite to TeamCity configuration.
> > >
> >
>

Re: IGNITE-6879

[Вячеслав Коптилин]

Hi Roman,

please take into account my comment IgniteQueryGenerator.java


Best regards,
Slava.

2018-04-05 14:59 GMT+03:00 Роман Меерсон :

> Ok, so waiting for accept and commit
>
> чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin :
>
> > Roman,
> >
> > Just pay commiter's (Dmitry Pavlov will most likely commit your code)
> > attention to include the new test suite to TeamCity configuration.
> >
>

Re: IGNITE-6879

[Роман Меерсон]

Ok, so waiting for accept and commit

чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin :

> Roman,
>
> Just pay commiter's (Dmitry Pavlov will most likely commit your code)
> attention to include the new test suite to TeamCity configuration.
>

Re: IGNITE-6879

[Alexey Kukushkin]

Roman,

Just pay commiter's (Dmitry Pavlov will most likely commit your code)
attention to include the new test suite to TeamCity configuration.

Re: IGNITE-6879

[Роман Меерсон]

Alexey,

1) Fixed
2) How could i be sure? What do i need to do?

чт, 5 апр. 2018 г. в 14:24, Alexey Kukushkin :

> Roman,
>
> Just two small comments from me:
>
>1. I suggest renaming IgniteSpringDataTestSuite to
>IgniteSpringData2TestSuite: we must be able to test both spring-data and
>spring-data-2 JARs with single "mvn test"
>2. Make sure "Ignite Spring Data" test job in TeamCity is extended to
>run the new test suite after the code is committed.
>
> Other than that the new module looks OK to me.
>

Re: IGNITE-6879

[Alexey Kukushkin]

Roman,

Just two small comments from me:

   1. I suggest renaming IgniteSpringDataTestSuite to
   IgniteSpringData2TestSuite: we must be able to test both spring-data and
   spring-data-2 JARs with single "mvn test"
   2. Make sure "Ignite Spring Data" test job in TeamCity is extended to
   run the new test suite after the code is committed.

Other than that the new module looks OK to me.

Re: IGNITE-6879

[Роман Меерсон]

I`ve finished with new module:

https://github.com/apache/ignite/pull/3704

чт, 5 апр. 2018 г. в 12:06, Роман Меерсон :

> Ok guys, I`ll made changes but what should we do with examples and with
> Spring module version?
>
> Exemples couldn`t support both versions, so should i leave upgraded to 2.0
> version?
> Spring module was upgraded to newest version, so should i leave it on
> newest version?
>
> чт, 5 апр. 2018 г. в 0:17, Denis Magda :
>
>> Hi guys,
>>
>> According to ASF stats our spring data integration is 2 times more popular
>> than spark integraion - 900 maven downloads vs. 400.
>>
>> So I would suggest us creating ignite-spring-data-2.0 module to support
>> new
>> deployments and leave ignite-spring-data to not break existing ones.
>>
>> --
>> Denis
>>
>>
>>
>> On Wed, Apr 4, 2018 at 7:33 AM, Dmitry Pavlov 
>> wrote:
>>
>> > Hi Igniters,
>> >
>> > I am going to review these changes in 3-4 days. If everything is ok and
>> if
>> > there is no objections, I will merge it.
>> >
>> > Hi Denis,
>> >
>> > are you agree with proposed change?
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>> >
>> > ср, 4 апр. 2018 г. в 14:26, Дмитрий Рябов :
>> >
>> > > I agree that increasing complexity isn't good idea. Roman, can you
>> > document
>> > > the migration guide?
>> > >
>> > > 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin <
>> kukushkinale...@gmail.com>:
>> > >
>> > > > Roman, Dmitry,
>> > > >
>> > > > I also reviewed the fix and the code looks OK to me. But the fix has
>> > > > significant implication - Ignite no longer can be used with
>> spring-data
>> > > 1.0
>> > > > due to no backward compatibility between spring 2.0 and 1.0 APIs.
>> With
>> > > this
>> > > > approach we must remember to add corresponding spring-data migration
>> > > > instructions to the future ignite 2.5 migration guide.
>> > > >
>> > > > We could keep spring 1 support and backward compatibility by
>> creating a
>> > > new
>> > > > module "ignite-spring-2-data" and keeping existing
>> ignite-spring-data
>> > as
>> > > > is. I do not like this option since to me increased complexity and
>> > > > maintainability costs overweight the benefits of protecting
>> > > > "Ignite-spring-1" users.
>> > > >
>> > > > I suggest you find a committer (see this list
>> > > > ),
>> > > communicate
>> > > > the implication I mentioned above and say that two people already
>> > > approved
>> > > > the code providing we are OK with the chosen approach.
>> > > >
>> > >
>> >
>>
>

Re: IGNITE-6879

[Роман Меерсон]

Ok guys, I`ll made changes but what should we do with examples and with
Spring module version?

Exemples couldn`t support both versions, so should i leave upgraded to 2.0
version?
Spring module was upgraded to newest version, so should i leave it on
newest version?

чт, 5 апр. 2018 г. в 0:17, Denis Magda :

> Hi guys,
>
> According to ASF stats our spring data integration is 2 times more popular
> than spark integraion - 900 maven downloads vs. 400.
>
> So I would suggest us creating ignite-spring-data-2.0 module to support new
> deployments and leave ignite-spring-data to not break existing ones.
>
> --
> Denis
>
>
>
> On Wed, Apr 4, 2018 at 7:33 AM, Dmitry Pavlov 
> wrote:
>
> > Hi Igniters,
> >
> > I am going to review these changes in 3-4 days. If everything is ok and
> if
> > there is no objections, I will merge it.
> >
> > Hi Denis,
> >
> > are you agree with proposed change?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 4 апр. 2018 г. в 14:26, Дмитрий Рябов :
> >
> > > I agree that increasing complexity isn't good idea. Roman, can you
> > document
> > > the migration guide?
> > >
> > > 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin  >:
> > >
> > > > Roman, Dmitry,
> > > >
> > > > I also reviewed the fix and the code looks OK to me. But the fix has
> > > > significant implication - Ignite no longer can be used with
> spring-data
> > > 1.0
> > > > due to no backward compatibility between spring 2.0 and 1.0 APIs.
> With
> > > this
> > > > approach we must remember to add corresponding spring-data migration
> > > > instructions to the future ignite 2.5 migration guide.
> > > >
> > > > We could keep spring 1 support and backward compatibility by
> creating a
> > > new
> > > > module "ignite-spring-2-data" and keeping existing ignite-spring-data
> > as
> > > > is. I do not like this option since to me increased complexity and
> > > > maintainability costs overweight the benefits of protecting
> > > > "Ignite-spring-1" users.
> > > >
> > > > I suggest you find a committer (see this list
> > > > ),
> > > communicate
> > > > the implication I mentioned above and say that two people already
> > > approved
> > > > the code providing we are OK with the chosen approach.
> > > >
> > >
> >
>

Re: IGNITE-6879

[Denis Magda]

Hi guys,

According to ASF stats our spring data integration is 2 times more popular
than spark integraion - 900 maven downloads vs. 400.

So I would suggest us creating ignite-spring-data-2.0 module to support new
deployments and leave ignite-spring-data to not break existing ones.

--
Denis



On Wed, Apr 4, 2018 at 7:33 AM, Dmitry Pavlov  wrote:

> Hi Igniters,
>
> I am going to review these changes in 3-4 days. If everything is ok and if
> there is no objections, I will merge it.
>
> Hi Denis,
>
> are you agree with proposed change?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 4 апр. 2018 г. в 14:26, Дмитрий Рябов :
>
> > I agree that increasing complexity isn't good idea. Roman, can you
> document
> > the migration guide?
> >
> > 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin :
> >
> > > Roman, Dmitry,
> > >
> > > I also reviewed the fix and the code looks OK to me. But the fix has
> > > significant implication - Ignite no longer can be used with spring-data
> > 1.0
> > > due to no backward compatibility between spring 2.0 and 1.0 APIs. With
> > this
> > > approach we must remember to add corresponding spring-data migration
> > > instructions to the future ignite 2.5 migration guide.
> > >
> > > We could keep spring 1 support and backward compatibility by creating a
> > new
> > > module "ignite-spring-2-data" and keeping existing ignite-spring-data
> as
> > > is. I do not like this option since to me increased complexity and
> > > maintainability costs overweight the benefits of protecting
> > > "Ignite-spring-1" users.
> > >
> > > I suggest you find a committer (see this list
> > > ),
> > communicate
> > > the implication I mentioned above and say that two people already
> > approved
> > > the code providing we are OK with the chosen approach.
> > >
> >
>

Re: IGNITE-6879

[Dmitry Pavlov]

Hi Igniters,

I am going to review these changes in 3-4 days. If everything is ok and if
there is no objections, I will merge it.

Hi Denis,

are you agree with proposed change?

Sincerely,
Dmitriy Pavlov

ср, 4 апр. 2018 г. в 14:26, Дмитрий Рябов :

> I agree that increasing complexity isn't good idea. Roman, can you document
> the migration guide?
>
> 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin :
>
> > Roman, Dmitry,
> >
> > I also reviewed the fix and the code looks OK to me. But the fix has
> > significant implication - Ignite no longer can be used with spring-data
> 1.0
> > due to no backward compatibility between spring 2.0 and 1.0 APIs. With
> this
> > approach we must remember to add corresponding spring-data migration
> > instructions to the future ignite 2.5 migration guide.
> >
> > We could keep spring 1 support and backward compatibility by creating a
> new
> > module "ignite-spring-2-data" and keeping existing ignite-spring-data as
> > is. I do not like this option since to me increased complexity and
> > maintainability costs overweight the benefits of protecting
> > "Ignite-spring-1" users.
> >
> > I suggest you find a committer (see this list
> > ),
> communicate
> > the implication I mentioned above and say that two people already
> approved
> > the code providing we are OK with the chosen approach.
> >
>

Re: IGNITE-6879

[Дмитрий Рябов]

I agree that increasing complexity isn't good idea. Roman, can you document
the migration guide?

2018-04-04 13:41 GMT+03:00 Alexey Kukushkin :

> Roman, Dmitry,
>
> I also reviewed the fix and the code looks OK to me. But the fix has
> significant implication - Ignite no longer can be used with spring-data 1.0
> due to no backward compatibility between spring 2.0 and 1.0 APIs. With this
> approach we must remember to add corresponding spring-data migration
> instructions to the future ignite 2.5 migration guide.
>
> We could keep spring 1 support and backward compatibility by creating a new
> module "ignite-spring-2-data" and keeping existing ignite-spring-data as
> is. I do not like this option since to me increased complexity and
> maintainability costs overweight the benefits of protecting
> "Ignite-spring-1" users.
>
> I suggest you find a committer (see this list
> ), communicate
> the implication I mentioned above and say that two people already approved
> the code providing we are OK with the chosen approach.
>

Re: IGNITE-6879

[Alexey Kukushkin]

Roman, Dmitry,

I also reviewed the fix and the code looks OK to me. But the fix has
significant implication - Ignite no longer can be used with spring-data 1.0
due to no backward compatibility between spring 2.0 and 1.0 APIs. With this
approach we must remember to add corresponding spring-data migration
instructions to the future ignite 2.5 migration guide.

We could keep spring 1 support and backward compatibility by creating a new
module "ignite-spring-2-data" and keeping existing ignite-spring-data as
is. I do not like this option since to me increased complexity and
maintainability costs overweight the benefits of protecting
"Ignite-spring-1" users.

I suggest you find a committer (see this list
), communicate
the implication I mentioned above and say that two people already approved
the code providing we are OK with the chosen approach.

Re: IGNITE-6879

[Дмитрий Рябов]

Hi!
No, it wasn't a joke)

2018-04-04 11:22 GMT+03:00 Роман Меерсон <homich1...@gmail.com>:

> Hi all!
> I suppose Dmity`s message wasn`t april 1st joke)
> So what about my PR? Would it be merged?
>
> вс, 1 апр. 2018 г. в 12:40, Дмитрий Рябов <somefire...@gmail.com>:
>
>> Dmitry, Alexey, code and tests looks good for me.
>>
>> JIRA: https://issues.apache.org/jira/browse/IGNITE-6879
>> PR: https://github.com/apache/ignite/pull/3704
>> Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541
>> TeamCity: https://ci.ignite.apache.org/viewLog.html?buildId=1170373=
>> buildResultsDiv=IgniteTests24Java8_RunAll
>>
>> 2018-03-22 21:48 GMT+03:00 Роман Меерсон <homich1...@gmail.com>:
>>
>>> Hi all!
>>>
>>> Dmitriy thank you for review.
>>>
>>> I`ve just fixed all your comments.
>>>
>>> чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov <dpavlov@gmail.com>:
>>>
>>>> HI Dmitriy, thank you!
>>>>
>>>> Roman, could you please address Dmitriy's comments?
>>>>
>>>> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов <somefire...@gmail.com>:
>>>>
>>>>> Hi Dmitriy,
>>>>>
>>>>> I took a look for PR, it needs codestyle fixes.
>>>>>
>>>>> 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov <dpavlov@gmail.com>:
>>>>>
>>>>>> Hi Alexey,
>>>>>>
>>>>>> Did you find the patch is looking good and is ready to be merged?
>>>>>>
>>>>>> Sincerely,
>>>>>> Dmitriy Pavlov
>>>>>>
>>>>>> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin <
>>>>>> kukushkinale...@gmail.com>:
>>>>>>
>>>>>> > Just found the fix is ready - I will review it today or tomorrow.
>>>>>> >
>>>>>>
>>>>>
>>>>>
>>

Re: IGNITE-6879

[Роман Меерсон]

Hi all!
I suppose Dmity`s message wasn`t april 1st joke)
So what about my PR? Would it be merged?

вс, 1 апр. 2018 г. в 12:40, Дмитрий Рябов <somefire...@gmail.com>:

> Dmitry, Alexey, code and tests looks good for me.
>
> JIRA: https://issues.apache.org/jira/browse/IGNITE-6879
> PR: https://github.com/apache/ignite/pull/3704
> Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541
> TeamCity:
> https://ci.ignite.apache.org/viewLog.html?buildId=1170373=buildResultsDiv=IgniteTests24Java8_RunAll
>
> 2018-03-22 21:48 GMT+03:00 Роман Меерсон <homich1...@gmail.com>:
>
>> Hi all!
>>
>> Dmitriy thank you for review.
>>
>> I`ve just fixed all your comments.
>>
>> чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov <dpavlov@gmail.com>:
>>
>>> HI Dmitriy, thank you!
>>>
>>> Roman, could you please address Dmitriy's comments?
>>>
>>> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов <somefire...@gmail.com>:
>>>
>>>> Hi Dmitriy,
>>>>
>>>> I took a look for PR, it needs codestyle fixes.
>>>>
>>>> 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov <dpavlov@gmail.com>:
>>>>
>>>>> Hi Alexey,
>>>>>
>>>>> Did you find the patch is looking good and is ready to be merged?
>>>>>
>>>>> Sincerely,
>>>>> Dmitriy Pavlov
>>>>>
>>>>> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin <
>>>>> kukushkinale...@gmail.com>:
>>>>>
>>>>> > Just found the fix is ready - I will review it today or tomorrow.
>>>>> >
>>>>>
>>>>
>>>>
>

Re: IGNITE-6879

[Дмитрий Рябов]

Dmitry, Alexey, code and tests looks good for me.

JIRA: https://issues.apache.org/jira/browse/IGNITE-6879
PR: https://github.com/apache/ignite/pull/3704
Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541
TeamCity:
https://ci.ignite.apache.org/viewLog.html?buildId=1170373=buildResultsDiv=IgniteTests24Java8_RunAll

2018-03-22 21:48 GMT+03:00 Роман Меерсон <homich1...@gmail.com>:

> Hi all!
>
> Dmitriy thank you for review.
>
> I`ve just fixed all your comments.
>
> чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov <dpavlov@gmail.com>:
>
>> HI Dmitriy, thank you!
>>
>> Roman, could you please address Dmitriy's comments?
>>
>> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов <somefire...@gmail.com>:
>>
>>> Hi Dmitriy,
>>>
>>> I took a look for PR, it needs codestyle fixes.
>>>
>>> 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov <dpavlov@gmail.com>:
>>>
>>>> Hi Alexey,
>>>>
>>>> Did you find the patch is looking good and is ready to be merged?
>>>>
>>>> Sincerely,
>>>> Dmitriy Pavlov
>>>>
>>>> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin <
>>>> kukushkinale...@gmail.com>:
>>>>
>>>> > Just found the fix is ready - I will review it today or tomorrow.
>>>> >
>>>>
>>>
>>>

[GitHub] ignite pull request #3704: IGNITE-6879 and migration to spring-data 2.0.5.RE...

[homich1991]

GitHub user homich1991 opened a pull request:

https://github.com/apache/ignite/pull/3704

IGNITE-6879 and migration to spring-data 2.0.5.RELEASE

Fixed IGNITE-6879
Migrated to spring-data 2.0.5.RELEASE
Migrated to spring 5.0.4.RELEASE
Fixed overrided methods naming
--

was problem with merging master in previous one 
https://github.com/apache/ignite/pull/3628, so created this one

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/homich1991/ignite ignite-6879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3704.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3704


commit ae280108fad94d42a04d8b955262178ef6a365dd
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-13T15:32:46Z

Fixed IGNITE-6879
Migrated to spring-data 2.0.5.RELEASE
Migrated to spring 5.0.4.RELEASE
Fixed overrided methods naming

commit f090873961609dc0177172b0ea0a05efc4c462f8
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-13T18:34:17Z

Fixed tests

commit 2b16d5224290f81cd7949643c8c98b8a4e2b3c4f
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-13T20:46:19Z

Fixed sorting problem (added UNSORTED option)
Fixed bean loading order. Now repositories are loaded only via factory and 
not by them selves.

commit 4ca587129cc91d0a10642ab88e8469bdec4a5d92
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-22T18:44:17Z

Fixed comments on PR

commit 62f57f920eb3e57f036e664d3334dc9f3f6f599d
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-25T15:10:54Z

Fixed comments on PR

commit e4c443198d52b70912d4ce06fb74c1acd726dad3
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-25T18:30:55Z

Fixed spring data examples

commit df3fc87a815b816ad599a9872d479b3d63cd028f
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-25T18:34:50Z

Fixed check style comments in ConditionFalse class

commit 1ab3d63cceff5646f9d9d24cec952bd02615a818
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-25T19:25:24Z

Return null instead of exception throwing

commit b118dc23b65d2d6a28512ec19fa90cb779ffc793
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-27T11:56:54Z

Merge branch 'master' into ignite-6879




---

[GitHub] ignite pull request #3628: IGNITE-6879 and migration to spring-data 2.0.5.RE...

[homich1991]

Github user homich1991 closed the pull request at:

https://github.com/apache/ignite/pull/3628


---

Re: IGNITE-6879

[Роман Меерсон]

Hi all!

Dmitriy thank you for review.

I`ve just fixed all your comments.

чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov :

> HI Dmitriy, thank you!
>
> Roman, could you please address Dmitriy's comments?
>
> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов :
>
>> Hi Dmitriy,
>>
>> I took a look for PR, it needs codestyle fixes.
>>
>> 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov :
>>
>>> Hi Alexey,
>>>
>>> Did you find the patch is looking good and is ready to be merged?
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin >> >:
>>>
>>> > Just found the fix is ready - I will review it today or tomorrow.
>>> >
>>>
>>
>>

Re: IGNITE-6879

[Dmitry Pavlov]

HI Dmitriy, thank you!

Roman, could you please address Dmitriy's comments?

чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов :

> Hi Dmitriy,
>
> I took a look for PR, it needs codestyle fixes.
>
> 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov :
>
>> Hi Alexey,
>>
>> Did you find the patch is looking good and is ready to be merged?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin > >:
>>
>> > Just found the fix is ready - I will review it today or tomorrow.
>> >
>>
>
>

Re: IGNITE-6879

[Дмитрий Рябов]

Hi Dmitriy,

I took a look for PR, it needs codestyle fixes.

2018-03-19 14:22 GMT+03:00 Dmitry Pavlov :

> Hi Alexey,
>
> Did you find the patch is looking good and is ready to be merged?
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin :
>
> > Just found the fix is ready - I will review it today or tomorrow.
> >
>

Re: IGNITE-6879

[Dmitry Pavlov]

Hi Alexey,

Did you find the patch is looking good and is ready to be merged?

Sincerely,
Dmitriy Pavlov

чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin :

> Just found the fix is ready - I will review it today or tomorrow.
>

Re: IGNITE-6879

[Alexey Kukushkin]

Dmitry, Roman, I can review the fix - send me a code review link when it is
ready.

On Wed, Mar 14, 2018 at 5:14 PM, Dmitry Pavlov <dpavlov@gmail.com>
wrote:

> Igniters,
>
> it is about spring-data integration support.
>
> Who has intereset about styding this technology?
>
> Alexey Kukushkin would you like to be reviewer of this issue?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 14 мар. 2018 г. в 1:08, Denis Magda <dma...@apache.org>:
>
>> Hello Roman,
>>
>> It's not a big deal, I've added you to the contributors' list in JIRA. Go
>> ahead and assign the ticket to yourself.
>>
>> Folks, anyway, who can review Roman's contribution that brings Spring 2.0
>> support to Ignite?
>>
>> --
>> Denis
>>
>>
>>
>> On Tue, Mar 13, 2018 at 2:21 PM, Роман Меерсон <homich1...@gmail.com>
>> wrote:
>>
>> > Hello!
>> >
>> > I want to work on https://issues.apache.org/jira/browse/IGNITE-6879
>> issue.
>> > Following the rules here
>> > https://ignite.apache.org/community/contribute.html#contribute my Jira
>> > username is "homich" so assign me to this ticket please.
>> >
>> > P.S. I found this rules page after I made PR, so sorry for this
>> > inconvenience.
>> >
>> > Regards.
>> >
>>
>


-- 
Best regards,
Alexey

Re: IGNITE-6879

[Dmitry Pavlov]

Igniters,

it is about spring-data integration support.

Who has intereset about styding this technology?

Alexey Kukushkin would you like to be reviewer of this issue?

Sincerely,
Dmitriy Pavlov

ср, 14 мар. 2018 г. в 1:08, Denis Magda <dma...@apache.org>:

> Hello Roman,
>
> It's not a big deal, I've added you to the contributors' list in JIRA. Go
> ahead and assign the ticket to yourself.
>
> Folks, anyway, who can review Roman's contribution that brings Spring 2.0
> support to Ignite?
>
> --
> Denis
>
>
>
> On Tue, Mar 13, 2018 at 2:21 PM, Роман Меерсон <homich1...@gmail.com>
> wrote:
>
> > Hello!
> >
> > I want to work on https://issues.apache.org/jira/browse/IGNITE-6879
> issue.
> > Following the rules here
> > https://ignite.apache.org/community/contribute.html#contribute my Jira
> > username is "homich" so assign me to this ticket please.
> >
> > P.S. I found this rules page after I made PR, so sorry for this
> > inconvenience.
> >
> > Regards.
> >
>

Re: IGNITE-6879

[Denis Magda]

Hello Roman,

It's not a big deal, I've added you to the contributors' list in JIRA. Go
ahead and assign the ticket to yourself.

Folks, anyway, who can review Roman's contribution that brings Spring 2.0
support to Ignite?

--
Denis



On Tue, Mar 13, 2018 at 2:21 PM, Роман Меерсон <homich1...@gmail.com> wrote:

> Hello!
>
> I want to work on https://issues.apache.org/jira/browse/IGNITE-6879 issue.
> Following the rules here
> https://ignite.apache.org/community/contribute.html#contribute my Jira
> username is "homich" so assign me to this ticket please.
>
> P.S. I found this rules page after I made PR, so sorry for this
> inconvenience.
>
> Regards.
>

IGNITE-6879

[Роман Меерсон]

Hello!

I want to work on https://issues.apache.org/jira/browse/IGNITE-6879 issue.
Following the rules here
https://ignite.apache.org/community/contribute.html#contribute my Jira
username is "homich" so assign me to this ticket please.

P.S. I found this rules page after I made PR, so sorry for this
inconvenience.

Regards.

[GitHub] ignite pull request #3628: IGNITE-6879 and migration to spring-data 2.0.5.RE...

[homich1991]

GitHub user homich1991 opened a pull request:

https://github.com/apache/ignite/pull/3628

IGNITE-6879 and migration to spring-data 2.0.5.RELEASE

Fixed IGNITE-6879
Migrated to spring-data 2.0.5.RELEASE
Migrated to spring 5.0.4.RELEASE
Fixed overrided methods naming

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/homich1991/ignite ignite-6879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3628


commit ae280108fad94d42a04d8b955262178ef6a365dd
Author: Roman_Meerson <roman_meerson@...>
Date:   2018-03-13T15:32:46Z

Fixed IGNITE-6879
Migrated to spring-data 2.0.5.RELEASE
Migrated to spring 5.0.4.RELEASE
Fixed overrided methods naming




---

[jira] [Created] (IGNITE-6879) Support Spring 2.0

[Alexey Kukushkin (JIRA)]

Alexey Kukushkin created IGNITE-6879:


 Summary: Support Spring 2.0
 Key: IGNITE-6879
 URL: https://issues.apache.org/jira/browse/IGNITE-6879
 Project: Ignite
  Issue Type: Improvement
  Security Level: Public (Viewable by anyone)
  Components: spring
Affects Versions: 2.3
Reporter: Alexey Kukushkin


Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt 
with Spring 2.0. Trying to change the Spring dependency version to 
2.0.0.release results in compile errors like below and requires regression in 
general. 
This improvement was created to either migrate from Spring 1.1 to 2.0 or create 
another set of modules ignite-spring-xxx-2 to have backward compatibility with 
Spring 1.1.

[ERROR] 
/Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10]
 name clash: deleteAll(java.lang.Iterable) in 
org.apache.ignite.springdata.repository.IgniteRepository and 
deleteAll(java.lang.Iterable) in 
org.springframework.data.repository.CrudRepository have the same erasure, yet 
neither overrides the other




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)