Re: [DISCUSSION] Framework for SQL performance regressions detection.

2020-05-26 Thread Denis Magda
Roman, Probably you are right that the SQL benchmarks need to be incorporated into the existing 'ignite-benchmarks' module. Please disregard my suggestion of setting a dedicated repository. - Denis On Sat, May 23, 2020 at 6:12 AM Roman Kondakov wrote: > Hi Denis, > > I'm not sure we need a se

Re: [DISCUSSION] Framework for SQL performance regressions detection.

2020-05-25 Thread Roman Kondakov
I've found out that we have `ignite-compatibility` module. It already has nice tools for launching different Ignite version simultaneously. We can reuse these tools for SQL regressions detection. I'm going to place the SQL regressions detection framework to this module and add a separate TeamCity

Re: [DISCUSSION] Framework for SQL performance regressions detection.

2020-05-23 Thread Roman Kondakov
Hi Igor, I think yes, this tool will be well suited for this. -- Kind Regards Roman Kondakov On 22.05.2020 22:46, Igor Seliverstov wrote: > Great idea I think. > > Can we also use the tool to compare, let's say, H2 indexing against Calcite > based one to detect possible issues when the new e

Re: [DISCUSSION] Framework for SQL performance regressions detection.

2020-05-23 Thread Roman Kondakov
Hi Denis, I'm not sure we need a separate repository for it. What would be the benefit of using a separate repo? BTW I noticed that Ignite has `ignite-benchmarks` module. It contains JMH/JOL benchmarks for now. We can also put the SQL benchmark to this module. What do you think? -- Kind Regard

Re: [DISCUSSION] Framework for SQL performance regressions detection.

2020-05-22 Thread Igor Seliverstov
Great idea I think. Can we also use the tool to compare, let's say, H2 indexing against Calcite based one to detect possible issues when the new engine acts worse than H2? Regards Igor пт, 22 мая 2020 г., 22:36 Denis Magda : > Hi Roman, > > +1 for sure. On a side note, should we create a separa

Re: [DISCUSSION] Framework for SQL performance regressions detection.

2020-05-22 Thread Denis Magda
Hi Roman, +1 for sure. On a side note, should we create a separate ASF/Git repository for the project? Not sure we need to put the suite in the main Ignite repo. - Denis On Fri, May 22, 2020 at 8:54 AM Roman Kondakov wrote: > Hi everybody! > > Currently Ignite doesn't have an ability to detec