Re: [IGNITE-7789] Ignite Client Nodes testErrorOnDisconnect()
Maxim, Alexey G. thank you. Test now passes in nigth build, https://ci.ignite.apache.org/viewLog.html?buildId=1117170 Sincerely, Dmitriy Pavlov ср, 28 февр. 2018 г. в 18:11, Maxim Muzafarov : > Dmitry, Sergey > > I've found solution of fixing this test-case, but not sure about > correctness. > Can you review it? > > JIRA: https://issues.apache.org/jira/browse/IGNITE-7789 > Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-507 > PR: https://github.com/apache/ignite/pull/3588 > > > ср, 28 февр. 2018 г. в 18:02, Dmitry Pavlov : > > > Hi Maxim, > > > > First of all, thank you for being ready to help community with tests and > > TC. Contributions which helps to improve tests stability are highly > > appreciated. > > > > Feel free to assign any issue if it is currently unassigned. If issue > > became too hard to implement later, it may be returned to unassigned. > > > > I hope Sergey C. can provide some details about this test failure. > > > > Sincerely, > > Dmitriy Pavlov > > > > вт, 27 февр. 2018 г. в 15:59, Maxim Muzafarov : > > > > > Hi all, > > > > > > I just briefly look at this issue [1] and found that for: > > > > > > 1) CollectionConfiguration[2] we have default backup = 0; > > > 2) AtomicConfiguration[3] we have DFLT_BACKUPS = 1; > > > > > > Is this correct? Because, both of them used for testing > > > dataStructureOperationsTest(). After disconnet and recreation cache > > > GridCacheAtomicLongImpl the default value for backup used. > > > > > > We have doTestIgniteOperationOnDisconnect() and it's argument of > > operations > > > List> which calls asynch. So thats why > > we > > > have unstable test-case. > > > > > > OK - test case > > > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Queue > > > creation > > > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Set > > > creation > > > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Atomic > > > creation > > > > > > FAIL - test case > > > 2018-02-27 15:52:23,304][INFO ][async-callable-runner-1][root] Atomic > > > creation > > > [2018-02-27 15:52:23,304][INFO ][async-callable-runner-1][root] Queue > > > creation > > > [2018-02-27 15:52:23,303][INFO ][async-callable-runner-1][root] Set > > > creation > > > > > > Can i take this issue for mysefl? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-7789 > > > [2] > > > > > > > > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/configuration/CollectionConfiguration.java#L47 > > > [3] > > > > > > > > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/configuration/AtomicConfiguration.java#L32 > > > > > >
Re: [IGNITE-7789] Ignite Client Nodes testErrorOnDisconnect()
Dmitry, Sergey I've found solution of fixing this test-case, but not sure about correctness. Can you review it? JIRA: https://issues.apache.org/jira/browse/IGNITE-7789 Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-507 PR: https://github.com/apache/ignite/pull/3588 ср, 28 февр. 2018 г. в 18:02, Dmitry Pavlov : > Hi Maxim, > > First of all, thank you for being ready to help community with tests and > TC. Contributions which helps to improve tests stability are highly > appreciated. > > Feel free to assign any issue if it is currently unassigned. If issue > became too hard to implement later, it may be returned to unassigned. > > I hope Sergey C. can provide some details about this test failure. > > Sincerely, > Dmitriy Pavlov > > вт, 27 февр. 2018 г. в 15:59, Maxim Muzafarov : > > > Hi all, > > > > I just briefly look at this issue [1] and found that for: > > > > 1) CollectionConfiguration[2] we have default backup = 0; > > 2) AtomicConfiguration[3] we have DFLT_BACKUPS = 1; > > > > Is this correct? Because, both of them used for testing > > dataStructureOperationsTest(). After disconnet and recreation cache > > GridCacheAtomicLongImpl the default value for backup used. > > > > We have doTestIgniteOperationOnDisconnect() and it's argument of > operations > > List> which calls asynch. So thats why > we > > have unstable test-case. > > > > OK - test case > > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Queue > > creation > > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Set > > creation > > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Atomic > > creation > > > > FAIL - test case > > 2018-02-27 15:52:23,304][INFO ][async-callable-runner-1][root] Atomic > > creation > > [2018-02-27 15:52:23,304][INFO ][async-callable-runner-1][root] Queue > > creation > > [2018-02-27 15:52:23,303][INFO ][async-callable-runner-1][root] Set > > creation > > > > Can i take this issue for mysefl? > > > > [1] https://issues.apache.org/jira/browse/IGNITE-7789 > > [2] > > > > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/configuration/CollectionConfiguration.java#L47 > > [3] > > > > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/configuration/AtomicConfiguration.java#L32 > > >
Re: [IGNITE-7789] Ignite Client Nodes testErrorOnDisconnect()
Hi Maxim, First of all, thank you for being ready to help community with tests and TC. Contributions which helps to improve tests stability are highly appreciated. Feel free to assign any issue if it is currently unassigned. If issue became too hard to implement later, it may be returned to unassigned. I hope Sergey C. can provide some details about this test failure. Sincerely, Dmitriy Pavlov вт, 27 февр. 2018 г. в 15:59, Maxim Muzafarov : > Hi all, > > I just briefly look at this issue [1] and found that for: > > 1) CollectionConfiguration[2] we have default backup = 0; > 2) AtomicConfiguration[3] we have DFLT_BACKUPS = 1; > > Is this correct? Because, both of them used for testing > dataStructureOperationsTest(). After disconnet and recreation cache > GridCacheAtomicLongImpl the default value for backup used. > > We have doTestIgniteOperationOnDisconnect() and it's argument of operations > List> which calls asynch. So thats why we > have unstable test-case. > > OK - test case > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Queue > creation > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Set > creation > [2018-02-27 15:51:05,065][INFO ][async-callable-runner-1][root] Atomic > creation > > FAIL - test case > 2018-02-27 15:52:23,304][INFO ][async-callable-runner-1][root] Atomic > creation > [2018-02-27 15:52:23,304][INFO ][async-callable-runner-1][root] Queue > creation > [2018-02-27 15:52:23,303][INFO ][async-callable-runner-1][root] Set > creation > > Can i take this issue for mysefl? > > [1] https://issues.apache.org/jira/browse/IGNITE-7789 > [2] > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/configuration/CollectionConfiguration.java#L47 > [3] > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/configuration/AtomicConfiguration.java#L32 >
