Re: Maven conflicts within ignite-core from duplicated classes

2016-06-16 Thread Anton Vinogradov 
We already have 2 dependencies at ignite-core:
*javax.cache.cache-api* and *org.gridgain.ignite-shmem*
(ASAIK we have an issue to redeploy org.gridgain.ignite-shmem as
org.apache.ignite.ignite-shmem)

On Thu, Jun 16, 2016 at 11:57 AM, Vladimir Ozerov 
wrote:

> And why do we afraid this dependency? It has "CLASS" retention so users do
> not need them in runtime, AFAIK.
>
> On Thu, Jun 16, 2016 at 11:19 AM, Vladislav Pyatkov  >
> wrote:
>
> > Why not just rename these classes?
> >
> > On Thu, Jun 16, 2016 at 11:16 AM, Semyon Boikov 
> > wrote:
> >
> > > As far as I know the only reason sources of Nullable are in Ignite - we
> > > did not want to have any dependecy for 'core' module.
> > >
> > > On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda 
> > wrote:
> > >
> > >> Hi Pete,
> > >>
> > >> CC-ing Ignite dev list to the thread as well.
> > >>
> > >> Igniters, up to today is there any reason why we need to include
> sources
> > >> of Nullable JetBrain’s annotation in Ignite sources?
> > >>
> > >> As I see we can rather import that latest version from the maven
> > >> repository
> > >> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0
> > >>
> > >> *Anton, *please take a look at Pete issue and suggest a workaround and
> > >> generic solution overall.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> On Jun 9, 2016, at 1:32 PM, Pete Campton 
> > wrote:
> > >>
> > >> Hello,
> > >>
> > >> I've come across an issue where there are a couple of classes
> duplicated
> > >> from org.jetbrains.annotations within the ignite-core module which
> > conflict
> > >> with other part of our code base.
> > >>
> > >> As these files are duplicated rather than being referenced as a maven
> > >> dependency I am unable to exclude them or reference a specific version
> > of
> > >> the org.jetbrains.annotations artifact.
> > >>
> > >> Specifically, the included version cannot be used to annotate types
> > >> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> > >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> > >> ElementType.LOCAL_VARIABLE})
> > >> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> > >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> > >> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
> > >>
> > >> As far as I know there isn't an easy way of excluding these files from
> > >> within the ignite-core module. Is there are reason why these
> "external"
> > >> files have been duplicated within the ignite code base rather than
> being
> > >> referenced as a maven dependency? Or alternatively, has anyone come
> > across
> > >> a way of avoiding these conflicts?
> > >>
> > >> Thanks
> > >> Pete
> > >>
> > >>
> > >>
> > >
> >
>

Re: Maven conflicts within ignite-core from duplicated classes

2016-06-16 Thread Vladimir Ozerov 
And why do we afraid this dependency? It has "CLASS" retention so users do
not need them in runtime, AFAIK.

On Thu, Jun 16, 2016 at 11:19 AM, Vladislav Pyatkov 
wrote:

> Why not just rename these classes?
>
> On Thu, Jun 16, 2016 at 11:16 AM, Semyon Boikov 
> wrote:
>
> > As far as I know the only reason sources of Nullable are in Ignite - we
> > did not want to have any dependecy for 'core' module.
> >
> > On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda 
> wrote:
> >
> >> Hi Pete,
> >>
> >> CC-ing Ignite dev list to the thread as well.
> >>
> >> Igniters, up to today is there any reason why we need to include sources
> >> of Nullable JetBrain’s annotation in Ignite sources?
> >>
> >> As I see we can rather import that latest version from the maven
> >> repository
> >> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0
> >>
> >> *Anton, *please take a look at Pete issue and suggest a workaround and
> >> generic solution overall.
> >>
> >> —
> >> Denis
> >>
> >> On Jun 9, 2016, at 1:32 PM, Pete Campton 
> wrote:
> >>
> >> Hello,
> >>
> >> I've come across an issue where there are a couple of classes duplicated
> >> from org.jetbrains.annotations within the ignite-core module which
> conflict
> >> with other part of our code base.
> >>
> >> As these files are duplicated rather than being referenced as a maven
> >> dependency I am unable to exclude them or reference a specific version
> of
> >> the org.jetbrains.annotations artifact.
> >>
> >> Specifically, the included version cannot be used to annotate types
> >> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> >> ElementType.LOCAL_VARIABLE})
> >> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> >> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
> >>
> >> As far as I know there isn't an easy way of excluding these files from
> >> within the ignite-core module. Is there are reason why these "external"
> >> files have been duplicated within the ignite code base rather than being
> >> referenced as a maven dependency? Or alternatively, has anyone come
> across
> >> a way of avoiding these conflicts?
> >>
> >> Thanks
> >> Pete
> >>
> >>
> >>
> >
>

Re: Maven conflicts within ignite-core from duplicated classes

2016-06-16 Thread Vladislav Pyatkov 
Why not just rename these classes?

On Thu, Jun 16, 2016 at 11:16 AM, Semyon Boikov 
wrote:

> As far as I know the only reason sources of Nullable are in Ignite - we
> did not want to have any dependecy for 'core' module.
>
> On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda  wrote:
>
>> Hi Pete,
>>
>> CC-ing Ignite dev list to the thread as well.
>>
>> Igniters, up to today is there any reason why we need to include sources
>> of Nullable JetBrain’s annotation in Ignite sources?
>>
>> As I see we can rather import that latest version from the maven
>> repository
>> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0
>>
>> *Anton, *please take a look at Pete issue and suggest a workaround and
>> generic solution overall.
>>
>> —
>> Denis
>>
>> On Jun 9, 2016, at 1:32 PM, Pete Campton  wrote:
>>
>> Hello,
>>
>> I've come across an issue where there are a couple of classes duplicated
>> from org.jetbrains.annotations within the ignite-core module which conflict
>> with other part of our code base.
>>
>> As these files are duplicated rather than being referenced as a maven
>> dependency I am unable to exclude them or reference a specific version of
>> the org.jetbrains.annotations artifact.
>>
>> Specifically, the included version cannot be used to annotate types
>> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
>> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
>> ElementType.LOCAL_VARIABLE})
>> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
>> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
>> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
>>
>> As far as I know there isn't an easy way of excluding these files from
>> within the ignite-core module. Is there are reason why these "external"
>> files have been duplicated within the ignite code base rather than being
>> referenced as a maven dependency? Or alternatively, has anyone come across
>> a way of avoiding these conflicts?
>>
>> Thanks
>> Pete
>>
>>
>>
>

Re: Maven conflicts within ignite-core from duplicated classes

2016-06-16 Thread Semyon Boikov 
As far as I know the only reason sources of Nullable are in Ignite - we did
not want to have any dependecy for 'core' module.

On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda  wrote:

> Hi Pete,
>
> CC-ing Ignite dev list to the thread as well.
>
> Igniters, up to today is there any reason why we need to include sources
> of Nullable JetBrain’s annotation in Ignite sources?
>
> As I see we can rather import that latest version from the maven repository
> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0
>
> *Anton, *please take a look at Pete issue and suggest a workaround and
> generic solution overall.
>
> —
> Denis
>
> On Jun 9, 2016, at 1:32 PM, Pete Campton  wrote:
>
> Hello,
>
> I've come across an issue where there are a couple of classes duplicated
> from org.jetbrains.annotations within the ignite-core module which conflict
> with other part of our code base.
>
> As these files are duplicated rather than being referenced as a maven
> dependency I am unable to exclude them or reference a specific version of
> the org.jetbrains.annotations artifact.
>
> Specifically, the included version cannot be used to annotate types
> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> ElementType.LOCAL_VARIABLE})
> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
>
> As far as I know there isn't an easy way of excluding these files from
> within the ignite-core module. Is there are reason why these "external"
> files have been duplicated within the ignite code base rather than being
> referenced as a maven dependency? Or alternatively, has anyone come across
> a way of avoiding these conflicts?
>
> Thanks
> Pete
>
>
>

Re: Maven conflicts within ignite-core from duplicated classes

2016-06-16 Thread Anton Vinogradov 
Denis,

I've created issue: https://issues.apache.org/jira/browse/IGNITE-3323

On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda  wrote:

> Hi Pete,
>
> CC-ing Ignite dev list to the thread as well.
>
> Igniters, up to today is there any reason why we need to include sources
> of Nullable JetBrain’s annotation in Ignite sources?
>
> As I see we can rather import that latest version from the maven repository
> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0
>
> *Anton, *please take a look at Pete issue and suggest a workaround and
> generic solution overall.
>
> —
> Denis
>
> On Jun 9, 2016, at 1:32 PM, Pete Campton  wrote:
>
> Hello,
>
> I've come across an issue where there are a couple of classes duplicated
> from org.jetbrains.annotations within the ignite-core module which conflict
> with other part of our code base.
>
> As these files are duplicated rather than being referenced as a maven
> dependency I am unable to exclude them or reference a specific version of
> the org.jetbrains.annotations artifact.
>
> Specifically, the included version cannot be used to annotate types
> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> ElementType.LOCAL_VARIABLE})
> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER,
> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
>
> As far as I know there isn't an easy way of excluding these files from
> within the ignite-core module. Is there are reason why these "external"
> files have been duplicated within the ignite code base rather than being
> referenced as a maven dependency? Or alternatively, has anyone come across
> a way of avoiding these conflicts?
>
> Thanks
> Pete
>
>
>

Re: Maven conflicts within ignite-core from duplicated classes

2016-06-13 Thread Denis Magda 
Hi Pete,

CC-ing Ignite dev list to the thread as well.

Igniters, up to today is there any reason why we need to include sources of 
Nullable JetBrain’s annotation in Ignite sources?

As I see we can rather import that latest version from the maven repository
https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 


Anton, please take a look at Pete issue and suggest a workaround and generic 
solution overall.

—
Denis

> On Jun 9, 2016, at 1:32 PM, Pete Campton  wrote:
> 
> Hello,
> 
> I've come across an issue where there are a couple of classes duplicated from 
> org.jetbrains.annotations within the ignite-core module which conflict with 
> other part of our code base.
> 
> As these files are duplicated rather than being referenced as a maven 
> dependency I am unable to exclude them or reference a specific version of the 
> org.jetbrains.annotations artifact.
> 
> Specifically, the included version cannot be used to annotate types
> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, 
> ElementType.LOCAL_VARIABLE})
> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, 
> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
> 
> As far as I know there isn't an easy way of excluding these files from within 
> the ignite-core module. Is there are reason why these "external" files have 
> been duplicated within the ignite code base rather than being referenced as a 
> maven dependency? Or alternatively, has anyone come across a way of avoiding 
> these conflicts?
> 
> Thanks
> Pete
>