Re: SqlFields query result does not expose fields metadata.

Done. Sergi 2017-05-23 13:48 GMT+03:00 Andrey Mashenkov : > IGNITE-5252 [1] is ready for review. > Sergi, would you please take a look at it? > > [1] https://issues.apache.org/jira/browse/IGNITE-5252 > > On Sat, May 20, 2017 at 7:07 PM, Andrey Mashenkov < >

Re: SqlFields query result does not expose fields metadata.

IGNITE-5252 [1] is ready for review. Sergi, would you please take a look at it? [1] https://issues.apache.org/jira/browse/IGNITE-5252 On Sat, May 20, 2017 at 7:07 PM, Andrey Mashenkov < andrey.mashen...@gmail.com> wrote: > Dmitry, > > Here is a link ot ticket [1] > > [1]

Re: SqlFields query result does not expose fields metadata.

I cannot find a ticket for it. Has it been filed? On Fri, May 19, 2017 at 12:38 AM, Vladimir Ozerov wrote: > Ah, got it. Then I am ok with the change as well. > > On Fri, May 19, 2017 at 9:24 AM, Sergi Vladykin > wrote: > > > Nope, the proposal

Re: SqlFields query result does not expose fields metadata.

Nope, the proposal was to have a FieldsQueryCursor interface with getFieldName(int column) method, may be + some other methods we will add later. This does not require any complex code modifications or exposing internal APIs. I'm not against new SQL API, it is a good idea, but it should not

Re: SqlFields query result does not expose fields metadata.

Proposal is about returning GridQueryFieldMetadata from QueryCursor, which is internal interface. This interface is counterintuitive and is not ready to be exposed to users. For example, it has method "typeName" which actually returns table name. And has method "fieldTypeName" which returns

Re: SqlFields query result does not expose fields metadata.

It should not require any internals movement, it must be an easy fix. Sergi 2017-05-18 15:36 GMT+03:00 Vladimir Ozerov : > With all the changes to internals we made, new API can be created very > quickly somewhere around AI 2.2 or AI 2.3. Currently the whole API is >

Re: SqlFields query result does not expose fields metadata.

With all the changes to internals we made, new API can be created very quickly somewhere around AI 2.2 or AI 2.3. Currently the whole API is located in the wrong place, as it is bounded to cache. So the more we add now, the more we will deprecate in several months. Remember, that this feature will

Re: SqlFields query result does not expose fields metadata.

I agree that this change makes sense. With complex queries it may be non-trivial to get the right column by index from results. With metadata user no longer needs to care about result column order, and refactorings are easier. Pavel On Thu, May 18, 2017 at 2:36 PM, Sergi Vladykin

Re: SqlFields query result does not expose fields metadata.

I believe we will not see this new SQL API soon. It is not even in design stage. The change proposed by Andrey is very simple and our users will benefit from it right away. I see no reasons to disallow this change. Sergi 2017-05-18 12:35 GMT+03:00 Vladimir Ozerov : >