Re: Protocol with re: to reverting previous patches

2017-11-28 Thread Sailesh Mukil
Yes, that's how I've usually done it. On Tue, Nov 28, 2017 at 2:16 PM, David Knupp wrote: > Seems like a silly question, but I just want to make sure I do this right. > > IMPALA-6239 was filed because the patch for IMPALA-6068 introduced a > regression. As a result, the

Re: [DISCUSS] 2.11.0 release

2017-11-30 Thread Sailesh Mukil
+1 Thanks for volunteering. On Thu, Nov 30, 2017 at 1:02 PM, Jim Apple wrote: > +1 > > On Thu, Nov 30, 2017 at 12:46 PM, Thomas Tauber-Marshall < > tmarsh...@cloudera.com> wrote: > > > Folks, > > > > It has been over 2 months since we released Apache Impala 2.10.0 and >

Re: Impala minidump dump_breakpad_symbols

2017-11-27 Thread Sailesh Mukil
Hi Sandish, Have you tried the steps outlined here? https://cwiki.apache.org/confluence/display/IMPALA/Debugging+Impala+Minidumps If it still doesn't work, as Brock mentioned, please paste portions of errors or any other helpful output that you see. - Sailesh On Mon, Nov 27, 2017 at 8:23 PM,

Re: build broken

2017-12-07 Thread Sailesh Mukil
t; > > wrote: > > > > > I think that's a consequence of the "cherry pick" merge strategy. It > does > > > seem like a flaw in our merge process. It would be nice if we could > > > configure gerrit so that it didn't merge patches where the parent > is

Re: build broken

2017-12-05 Thread Sailesh Mukil
Sorry about that. I thought they would both be merged together, but it looks like that wasn't the case. On Tue, Dec 5, 2017 at 6:22 PM, Michael Ho wrote: > Thanks Tim for fixing it and Jin Chul for investigating the problem. Sorry > for missing that during code review. > > On

[RESULT] Vote on Impala 3.0.0 RC1

2018-05-07 Thread Sailesh Mukil
https://lists.apache.org/thread.html/c1be7c5d3b69986c854b7f17d616c7c454cac77a9d13bb1041b371ce@%3Cdev.impala.apache.org%3E The vote has passed with the following tally: +1 (binding): - Jim Apple - Thomas Tauber-Marshall - Sailesh Mukil - Lars Volker - Philip Zeyliger -1: None Thank you

Jenkins Upgrade

2018-05-09 Thread Sailesh Mukil
I'll be performing a Jenkins upgrade shortly, and will have it in the "Prepare for restart" mode. I'll send in a mail when the upgrade is done.

Re: Jenkins Upgrade

2018-05-09 Thread Sailesh Mukil
Jenkins is back up. On Wed, May 9, 2018 at 9:47 PM, Sailesh Mukil <sail...@cloudera.com> wrote: > I'll be performing a Jenkins upgrade shortly, and will have it in the > "Prepare for restart" mode. I'll send in a mail when the upgrade is done. >

Re: [ANNOUNCE] Apache Impala 3.0.0 release

2018-05-10 Thread Sailesh Mukil
any > > others who contributed to creating this new branch and maintaining the > > relationship between the two branches. > > > > On Wed, May 9, 2018 at 1:37 PM, Sailesh Mukil <sail...@apache.org> > wrote: > > > > > The Apache Impala team is ple

Re: New message on your code reviews when cherry-picking your change fails.

2018-05-11 Thread Sailesh Mukil
nge 10360 <http://gerrit.cloudera.org:8080/10360>. To > > unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>. > > Gerrit-Project: Impala-ASF > > Gerrit-Branch: master > > Gerrit-MessageType: comment > > Gerrit-Change-Id: Ia2e2df73d27f

Re: [VOTE] 3.0.0 release candidate 1

2018-05-07 Thread Sailesh Mukil
The vote has passed with the following tally: +1 (binding): - Jim Apple - Thomas Tauber-Marshall - Sailesh Mukil - Lars Volker - Philip Zeyliger -1: None Thank you for participating in the vote! On Thu, May 3, 2018 at 10:41 AM, Philip Zeyliger <phi...@cloudera.com> wrote: > +1

Re: Maintaining Impala Documentation Sets for Releases

2018-05-08 Thread Sailesh Mukil
#3 is best. I'm doing something similar for the maintaining the latest releases for 2.x and 3.x in the "Downloads" page. Patch: https://gerrit.cloudera.org/#/c/10333/ On Mon, May 7, 2018 at 4:18 PM, Lars Volker wrote: > I'm in favor of #3, too. Ideally we'd have proper pages

Re: Automatically rebase changes before GVO?

2018-06-11 Thread Sailesh Mukil
+1 On Mon, Jun 11, 2018 at 3:02 PM, Jim Apple wrote: > No objection from me. > > On Mon, Jun 11, 2018 at 12:06 PM, Tim Armstrong > wrote: > > > > On nit: as GVD gets more complex, it becomes harder for new people to > > understand the messages and +Ns applied to their patches. That doesn't >

Re: Re: Re: [DISCUSS] Apache Impala 2.12.0 and 3.0 releases

2018-05-01 Thread Sailesh Mukil
An update: Impala 2.12.0 has been released. All remaining tasks for Impala 3.0.0 have been completed. The release is now in preparation and a vote will commence soon. On Fri, Apr 13, 2018 at 11:51 AM, Sailesh Mukil <sail...@cloudera.com> wrote: > Thank you all. > > I

[VOTE] 3.0.0 release candidate 1

2018-05-01 Thread Sailesh Mukil
This is a vote to release Impala 3.0.0 The artifacts for testing can be downloaded from: https://dist.apache.org/repos/dist/dev/impala/3.0.0/RC1/ Git tag: 3.0.0-rc1 Tree hash: d5bf1fdeb20ac332ce48c6a2b0588bcaf7ac9cb0 Please vote +1 or -1. -1 votes should be accompanied by an explanation of the

Re: [ANNOUNCE] Apache Impala 2.12.0 release

2018-04-30 Thread Sailesh Mukil
My pleasure! On Mon, Apr 30, 2018 at 11:19 AM, Jim Apple <jbap...@cloudera.com> wrote: > -user, -announce > > Thanks for driving this, Sailesh! > > On Mon, Apr 30, 2018 at 10:03 AM, Sailesh Mukil <sail...@apache.org> > wrote: > > > The Apache Impala

[ANNOUNCE] Apache Impala 2.12.0 release

2018-04-30 Thread Sailesh Mukil
The Apache Impala team is pleased to announce the release of Impala 2.12.0. Impala is a high-performance distributed SQL engine. The release is available at: https://impala.apache.org/downloads.html Thanks, The Apache Impala team

2.x branch divergence, its implications and what you can do.

2018-05-03 Thread Sailesh Mukil
It's been a while since we started maintaining 2 active branches, master and 2.x, and the divergence between them has grown quite a bit. The implications of this (as Michael Brown brought to my attention) are that a patch that goes into 'master' may not cleanly apply to '2.x', which would fail

Re: 2.x branch divergence, its implications and what you can do.

2018-05-03 Thread Sailesh Mukil
That's one way to go about it. To elaborate: Add "Cherry-picks: not for 2.x" in the original patch that goes into 'master', manually cherry-pick to '2.x', resolve conflicts and push. However, this way, if there are multiple patches being merged, we could end up with a different order of commits in

Re: 2.x branch divergence, its implications and what you can do.

2018-05-03 Thread Sailesh Mukil
On Thu, May 3, 2018 at 12:17 PM, Lars Volker <l...@cloudera.com> wrote: > Should we add a check to the master GVO that makes sure that a change > either applies to 2.x, or has a "not for 2.x" label? > > I like this idea. Let me open a JIRA for it. > On Thu, M

Re: [VOTE] 3.0.0 release candidate 1

2018-05-03 Thread Sailesh Mukil
of the release testing job that Sailesh appears to > have run on jenkins.impala.io. > > On Tue, May 1, 2018 at 4:34 PM Sailesh Mukil <sail...@cloudera.com> wrote: > > > This is a vote to release Impala 3.0.0 > > > > The artifacts for testing can be downloaded from

Re: 2.x branch divergence, its implications and what you can do.

2018-05-03 Thread Sailesh Mukil
ng process each time > > > they push out a new revision but it does introduce more risk of > > > accidentally diverging your master and 2.x commits versus just doing > the > > > conflict resolution once. > > > > > > On Thu, May 3, 2018 at 12:17 PM, Lar

Re: thrift-server-test

2018-01-08 Thread Sailesh Mukil
5:39:23 01/09/2018 15:39:23 krbtgt/krbtest@krbtest.com > renew until 01/15/2018 15:39:23 > > Thanks! > > > On Mon, Jan 8, 2018 at 12:20 PM, Sailesh Mukil <sail...@cloudera.com> > wrote: > > > Can you run the test again, and klist the contents of the

Re: thrift-server-test

2018-01-08 Thread Sailesh Mukil
Can you run the test again, and klist the contents of the credential cache and post the error logs again? Looks like "impala/localhost" might not be stored as expected in the cache on your machine. On Wed, Dec 13, 2017 at 2:47 PM, Philip Zeyliger wrote: > The KDC in this

Re: Setting up ASF Git Bot?

2018-01-31 Thread Sailesh Mukil
I like the idea. Easier to access commits from the JIRA. On Wed, Jan 31, 2018 at 1:36 PM, Philip Zeyliger wrote: > Hi folks, > > Would people be interested in ASF's bot that connects JIRAs to Commits? You > can see the "activity stream" of >

Help with fixing clang-diagnostic-over-aligned

2018-02-14 Thread Sailesh Mukil
Does anyone have experience with fixing the following type of clang-tidy warning? /home/ubuntu/Impala/be/src/runtime/exec-env.cc:159:21: warning: type 'impala::QueryExecMgr' requires 64 bytes of alignment and the default allocator only guarantees 16 bytes [clang-diagnostic-over-aligned]

Re: Help with fixing clang-diagnostic-over-aligned

2018-02-14 Thread Sailesh Mukil
oss-cacheline loads/stores. > > -Todd > > > On Wed, Feb 14, 2018 at 12:33 PM, Sailesh Mukil <sail...@cloudera.com> > wrote: > > > Does anyone have experience with fixing the following type of > > clang-tidy warning? > > > > > > /home/ubu

Re: #pragma once?

2018-08-01 Thread Sailesh Mukil
An advantage of using #pragma once is potential improved compilation speeds. However, a con is that it's non-standard and therefore, its behavior can change at any point and can also vary across compilers, potentially making the code even less portable. That being said, since Kudu has been using

Re: impalad running as superuser in tests

2018-07-17 Thread Sailesh Mukil
On Tue, Jul 17, 2018 at 2:47 PM, Todd Lipcon wrote: > Hey folks, > > I'm working on a regression test for IMPALA-7311 and found something > interesting. It appears that in our normal minicluster setup, impalad runs > as the same username as the namenode (namely, the username of the > developer,

Re: Order of error messages printed

2018-07-24 Thread Sailesh Mukil
The ErrorLogMap's key is "TErrorCode::type" which is an Enum. I don't think we can derive any inherent meaning from the order of the errors listed in the enum (other than OK=0, which wouldn't be in this map anyway). I'm not aware of any clients relying on this order, and even if there were, it

Re: impalad running as superuser in tests

2018-07-18 Thread Sailesh Mukil
On Wed, Jul 18, 2018 at 10:21 AM, Todd Lipcon wrote: > On Tue, Jul 17, 2018 at 5:27 PM, Sailesh Mukil > > wrote: > > > On Tue, Jul 17, 2018 at 2:47 PM, Todd Lipcon > > wrote: > > > > > Hey folks, > > > > > > I'm working on a regression t

Re: expr-benchmark

2018-09-09 Thread Sailesh Mukil
The benchmarks weren't being actively maintained last I saw (6 months back or so), and most of them aren't run regularly as well. So a lot of the dependent code may have changed causing them to break. So, there's no guarantee that they will work. On Sat, Sep 8, 2018 at 10:08 AM Jim Apple wrote:

Re: boost::scoped_ptr vs std::unique_ptr

2018-07-05 Thread Sailesh Mukil
I'm in favor. Since the main distinction is that a unique_ptr is moveable, whereas a scoped_ptr is not, we should just make sure that we do our due diligence during code reviews so that we catch those cases. Also, making a unique_ptr const disallows moving it, since the move constructor takes a

Re: Removing IMPALA_MINICLUSTER_PROFILE=2 from master

2018-07-11 Thread Sailesh Mukil
+1 for removing it. I'm all for reduced complexity if not a lot of users are benefitting from it. On Wed, Jul 11, 2018 at 9:29 AM, Fredy Wijaya wrote: > Hi all, > > In the master branch, we support both Hadoop 2 and Hadoop 3 via > IMPALA_MINICLUSTER_PROFILE environment variable. When Impala

Re: Impala OS and Java version support

2018-07-06 Thread Sailesh Mukil
I'm in favor of the minimum OS version support proposal. From 3.x, I don't see any reason to support much older OSes especially since it's becoming much more burdensome to special case code for them and have those paths tested. I'll defer to others on the minimum Java version proposal since they

Re: Error when build with bootstrap_development.sh

2018-04-04 Thread Sailesh Mukil
Have you tried deleting the gen-cpp directory and rebuilding with "./buildall" ? On Wed, Apr 4, 2018 at 11:33 AM, Yang Su wrote: > Dear all, > > I try to build impala on a Ubuntu box: 16.04.1-Ubuntu x86_64. > > I ran bin/bootstrap_development.sh. It failed with the following

Re: Re: Re: [DISCUSS] Apache Impala 2.12.0 and 3.0 releases

2018-04-13 Thread Sailesh Mukil
Thank you all. I've triaged all the remaining open JIRAs for Impala 2.12.0 and Impala 3.0 and we have 2 more breaking changes that need to go in for Impala 3.0: https://issues.apache.org/jira/browse/IMPALA-6340 https://issues.apache.org/jira/browse/IMPALA-5893 There are also a couple of patches

Re: Should we allow attachments?

2018-04-08 Thread Sailesh Mukil
Do a lot of dev lists allow for attachments? In my experience, I've not found that to be the case. On Sat, Apr 7, 2018 at 8:00 PM, Philip Zeyliger wrote: > I'm in favor of attachments. We can always change our minds if it turns out > to be unpleasant. > > P > > On Sat, Apr

Re: [VOTE] 2.12.0 release candidate 1

2018-04-20 Thread Sailesh Mukil
e.org/jira/browse/IMPALA-4744> and we're released > > with > > this before. Should we require a subsequent RC, we can manually change > > GIT_HASH in bin/save-version.sh. > > > > Thanks for creating the RC, Sailesh! > > > > > > On Thu, Apr

Impala FE compilation error (related to sentry)

2018-04-16 Thread Sailesh Mukil
I get this error when trying to the build the Impala frontend. Anyone know how I can get past this? [ERROR] COMPILATION ERROR : [ERROR] /home/systest/incubator-impala/fe/src/main/java/org/apache/impala/authorization/Privilege.java:[72,25] org.apache.sentry.core.common.BitFieldAction is abstract;

Re: Impala FE compilation error (related to sentry)

2018-04-16 Thread Sailesh Mukil
udera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > -- > > On Mon, Apr 16, 2018 at 5:59 PM, Sailesh Mukil <sail...@cloudera.com> > wrote: > > > Thanks Fredy. > > > > Is there a fix out already? > > > > On Mon, Apr 16, 2018 at 3:53 PM,

Re: Impala FE compilation error (related to sentry)

2018-04-16 Thread Sailesh Mukil
t; > > [image: Cloudera] <https://www.cloudera.com/> > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera>

[RESULT] Vote on Impala 2.12.0 RC 1

2018-04-24 Thread Sailesh Mukil
https://lists.apache.org/thread.html/bdbb9d74834a5db53ee6565958044f3af1d4160f45cf0024393a4fe2@%3Cdev.impala.apache.org%3E The vote has passed with the following tally: +1 (binding): * Lars Volker * Thomas Tauber-Marshall * Jim Apple * Sailesh Mukil -1 (binding) - None (There was one which

Re: JIRA necromancy

2018-04-17 Thread Sailesh Mukil
Yes to this. On Tue, Apr 17, 2018 at 11:26 AM, Alexander Behm wrote: > I agree. Reopening can be very confusing. > > On Tue, Apr 17, 2018 at 11:20 AM, Jim Apple wrote: > > > I'm convinced. > > > > On Tue, Apr 17, 2018 at 10:29 AM, Tim Armstrong

Re: [VOTE] 2.12.0 release candidate 1

2018-04-19 Thread Sailesh Mukil
pala-2.12.0.tar.gz: No such file or directory > /tmp/apache-impala-2.12.0.tar.gz: FAILED open or read > sha512sum: WARNING: 1 listed file could not be read > > > On Thu, Apr 19, 2018 at 2:40 PM, Sailesh Mukil <sail...@cloudera.com> > wrote: > > > This is a vote to release

[VOTE] 2.12.0 release candidate 1

2018-04-19 Thread Sailesh Mukil
This is a vote to release Impala 2.12.0 The artifacts for testing can be downloaded from: https://dist.apache.org/repos/dist/dev/impala/2.12.0/RC1/ Git tag: 2.12.0-rc1 Tree hash: 07f18b8539a044c506bb3ff5a118f3b7b5ea1cf7 Please vote +1 or -1. -1 votes should be accompanied by an explanation of

Re: Re: [VOTE] 2.12.0 release candidate 1

2018-04-25 Thread Sailesh Mukil
ap...@cloudera.com> wrote: > > >+1: I trust the results of the Jenkins job. > > > > > >On Fri, Apr 20, 2018 at 3:45 PM, Sailesh Mukil <sail...@cloudera.com> > > wrote: > > > > > >> +1 (binding) > > >> > > >>

[DISCUSS] Apache Impala 2.12.0 and 3.0 releases

2018-04-02 Thread Sailesh Mukil
Folks, It's been about 3 months since our last release and there have been a good number of bug fixes, features added and performance improvements since then. I propose that we have a 2.12.0 release soon and a 3.0 release in parallel. I, as a PMC of Apache Impala volunteer to mange both these