"unset all" seems better for me as well. However, "unset" commands are
just supported in impala-shell.
Maybe we should support UNSET statements in our SQL dialect, just like
SET statements:
https://github.com/apache/impala/blob/dfc2f175bdd10106e6984fc150ede9891a03eeb0/fe/src/main/cup/sql-parser.cup#L2920
Regards,
Quanlong
On Wed, Apr 13, 2022 at 4:01 PM Gabor Kaszab wrote:
>
> Hey gaoxiaoqing,
> Thanks for taking care of this!
>
> Regarding the syntax, currently we have "set ;", "unset
> ;", "set;" and "set all;"
> Following these I would vote for a bit different syntax than what you
> proposed. E.g. "*unset all*"
>
> Cheers,
> Gabor
>
> On Wed, Apr 13, 2022 at 8:22 AM `曦 <[email protected]> wrote:
>
> > I have submitted the following issue,
> >
> > https://issues.apache.org/jira/browse/IMPALA-11233
> >
> >
> >
> >
> > when we using jdbc connection pool, a connection set some query option,
> > after query finished, connection is closed and put back to the connection
> > pool. when connection using again, the last query option also come into
> > affect.
> >
> > we need a feature that a set statement can reset all query option without
> > restart impalad.
> >
> > I wrote a demo using set reset_all_query_option=1. it can reset all query
> > option.
> >
> > https://gerrit.cloudera.org/#/c/18408/
> >
> > do you think is it much more better to create a new syntax？ eg, reset
> > query_option
> >
> > Thanks!
> >
> > gaoxiaoqing
