Re: TEST_START_CLUSTER_ARGS are not applied in custom cluster tests

2018-02-20 Thread Lars Volker
Thanks MJ and Philip for the replies. I added a comment: https://gerrit.cloudera.org/c/9291/11/tests/common/custom_cluster_test_suite.py#128 Cheers, Lars On Tue, Feb 13, 2018 at 3:06 PM, Matthew Jacobs wrote: > I think that it was an oversight. That said, given that custom cluster > tests may a

Re: TEST_START_CLUSTER_ARGS are not applied in custom cluster tests

2018-02-13 Thread Matthew Jacobs
I think that it was an oversight. That said, given that custom cluster tests may also set the same flags (e.g. mem_limit as Phil pointed out) I'm not sure the desired behavior would be immediately obvious. It may just be best to clarify the name and/or comment on TEST_START_CLUSTER_ARGS. On Tue, F

Re: TEST_START_CLUSTER_ARGS are not applied in custom cluster tests

2018-02-13 Thread Philip Zeyliger
It's definitely handy. I've used it for specifying things like --mem_limit when running inside a container. I think Lars' question is more about what the custom cluster tests should do with it. -- Philip On Tue, Feb 13, 2018 at 10:48 AM, Matthew Jacobs wrote: > I had introduced this while I was

Re: TEST_START_CLUSTER_ARGS are not applied in custom cluster tests

2018-02-13 Thread Matthew Jacobs
I had introduced this while I was working at Cloudera for jenkins jobs to specify RM-related parameters to the test environment. At that time, I had one or more jenkins jobs that were setting this environment variable. I do not know if Cloudera or any other Impala developers are trying to use this.