Experimental removal syntax support for "select extract(ident from expr)"

2016-09-19 Thread Wang, Youwei A
Greetings everyone. The reason I want to do the removal mentioned in the caption is I have tried to add syntax support for the following function for Impala-889 like: Select btrim(heading/tailing ExprY KW_FROM ExprZ); By adding following code in the sql-parser.cup file: | function_name:fn_name

Re: [DISCUSS] Removal of Llama support in next (2.8?) release of Impala

2016-09-19 Thread Brock Noland
+1 On Sun, Sep 18, 2016 at 11:58 AM, Matthew Jacobs wrote: > +1 > > On Sun, Sep 18, 2016 at 9:13 AM, Marcel Kornacker > wrote: > > > +1 > > > > On Sat, Sep 17, 2016 at 3:04 PM, Alex Behm > wrote: > > > +1 > > > > > > On Sat, Sep 17, 2016 at 2:52 PM, Henry Robinson > > wrote: > > > > > >> Impa

Git hook to automatically call clang-format

2016-09-19 Thread Henry Robinson
I recently added a git hook to automatically format my patches with git-clang-format. It happens on pre-commit. If the commit is --amend, the script chooses HEAD~1 to compare against instead of HEAD. The script is here: https://gist.github.com/henryr/e89f9724eb85a6d5ea48ff0027f36793 If you want

Re: Git hook to automatically call clang-format

2016-09-19 Thread Henry Robinson
Uhhh, scratch that - this doesn't actually commit the changes. I'll work on a better version and post it when ready. On 19 September 2016 at 13:36, Henry Robinson wrote: > I recently added a git hook to automatically format my patches with > git-clang-format. > > It happens on pre-commit. If the

Re: Git hook to automatically call clang-format

2016-09-19 Thread Henry Robinson
This one works a bit better for me, YMMV: wget https://gist.githubusercontent.com/henryr/e89f9724eb85a6d5ea48ff0027f36793/raw/2dd7888d7494cc4d38fb3f51581b503bf25b6c7c/pre-commit -O ${IMPALA_HOME}/.git/hooks/pre-commit On 19 September 2016 at 14:46, Henry Robinson wrote: > Uhhh, scratch that

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-09-19 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 10: Greetings, Jim. I have updated this patch using the new gerrit project, "Impala-ASF". Corresponding new

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings