[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:

Line 118:   https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala";>Contribute
> Better to be explicit that this is documentation for Impala in CDH. Perhaps
So, perhaps I could rename "books" to "docs", then have that page link to the 
three books and the CDH Impala docs?


-- 
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:

Line 118:   https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala";>Contribute
> Maybe I could word the link "Documentation (hosted by Cloudera)". What do y
Better to be explicit that this is documentation for Impala in CDH. Perhaps it 
needs an intermediate page to give space to explain that.


-- 
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:

Line 118:   https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala";>Contribute
> I think removing the docs link is counterproductive. Feel free to highlight
Maybe I could word the link "Documentation (hosted by Cloudera)". What do you 
think?


-- 
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
..


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:

Line 118:   https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala";>Contribute
I think removing the docs link is counterproductive. Feel free to highlight 
that this goes to a non-Apache site, but there's a lot of useful information in 
the docs that we don't have an ASF equivalent of yet.


http://gerrit.cloudera.org:8080/#/c/4318/2/overview.html
File overview.html:

PS2, Line 150: We encourage you to read 
Can you change the wording? "We encourage you to read" sounds very prescriptive 
to me. "This paper from CIDR '15 has the most complete overview of Impala's 
architecture" is how I'd rephrase.


-- 
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-06 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2).

Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
..

IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

While I'm in here, remove outdated roadmap.

Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
---
M community.html
M index.html
M overview.html
3 files changed, 10 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4318/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson