[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-3221: Copyright / license audit .. IMPALA-3221: Copyright / license audit Populates LICENSE.txt with known third-party licenses in the Impala codebase. Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Reviewed-on: http://gerrit.cloudera.org:8080/3995 Reviewed-by: Henry Robinson Tested-by: Henry Robinson --- M LICENSE.txt D be/src/gutil/LICENSE.txt M be/src/runtime/string-search.h 3 files changed, 354 insertions(+), 82 deletions(-) Approvals: Henry Robinson: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 4: Code-Review+2 Verified+1 Rebase. Carry+2 and will submit without GVO, as this only changes text, not code. -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461: All rights reserved. > Sorry, I still am confused - why are prettytable and sqlparse (3-clause BSD As we just discussed - I think they're all treated the same in PS3. -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 3: I have branched for 2.7.0 and I anticipate cherry-picking this from master before cutting a release candidate for voting. -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461: All rights reserved. > Thanks for finding those! I don't *think* we need a COPYING for sasl; the e Sorry, I still am confused - why are prettytable and sqlparse (3-clause BSD license in COPYING) treated differently from www/highlight (3-clause BSD license in LICENSE)? -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461: shell/ext-py/prettytable-0.7.1: 3-clause BSD (see shell/ext-py/prettytable-0.7.1/PKG-INFO) > There is sopy copyright text in shell/ext-py/prettytable-0.7.1/COPYING. sql Thanks for finding those! I don't *think* we need a COPYING for sasl; the entry in LICENSE is enough (I think). -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-3221: Copyright / license audit .. IMPALA-3221: Copyright / license audit Populates LICENSE.txt with known third-party licenses in the Impala codebase. Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 --- M LICENSE.txt D be/src/gutil/LICENSE.txt M be/src/runtime/string-search.h 3 files changed, 354 insertions(+), 82 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/3995/3 -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461: shell/ext-py/prettytable-0.7.1: 3-clause BSD (see shell/ext-py/prettytable-0.7.1/PKG-INFO) > There's no license or copyright text included with prettytable etc. that I There is sopy copyright text in shell/ext-py/prettytable-0.7.1/COPYING. sqlparse is also in COPYING. sasl points to toddlipcon's github page, which says the code was borrowed from qpid, which is an apache project. Do you think there needs to be any copying there? -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-3221: Copyright / license audit .. IMPALA-3221: Copyright / license audit Populates LICENSE.txt with known third-party licenses in the Impala codebase. Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 --- M LICENSE.txt D be/src/gutil/LICENSE.txt M be/src/runtime/string-search.h 3 files changed, 297 insertions(+), 82 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/3995/2 -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461: shell/ext-py/prettytable-0.7.1: 3-clause BSD (see shell/ext-py/prettytable-0.7.1/PKG-INFO) > I noticed that one 3-clause BSD licence is copied in above, while these are There's no license or copyright text included with prettytable etc. that I could find, so nothing to copy here. For d3, note that there are a couple of mentions of the author. -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) Nice work. This must have been labor-intensive. http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461: shell/ext-py/prettytable-0.7.1: 3-clause BSD (see shell/ext-py/prettytable-0.7.1/PKG-INFO) I noticed that one 3-clause BSD licence is copied in above, while these are only incorporated by reference. Why is that? -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3221: Copyright / license audit
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/3995 Change subject: IMPALA-3221: Copyright / license audit .. IMPALA-3221: Copyright / license audit Populates LICENSE.txt with known third-party licenses in the Impala codebase. Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 --- M LICENSE.txt D be/src/gutil/LICENSE.txt M be/src/runtime/string-search.h 3 files changed, 268 insertions(+), 82 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/3995/1 -- To view, visit http://gerrit.cloudera.org:8080/3995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I24a868aec6a4f17f4ccca1b088d2f0de32f75d87 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
