[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3937/4/fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java File fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java: PS4, Line 126: dataSource_ = (ExternalDataSource) ctor.newInstance(); I think this will break compatibility with old data sources, customers will likely have to recompile against the renamed interface. We can address this separately but shouldn't forget. I filed https://issues.cloudera.org/browse/IMPALA-4081 -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
Re: [Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
On Thu, Sep 1, 2016 at 6:58 PM Thomas Tauber-Marshall < [email protected]> wrote: > Current status: > > I can get the packaging build as far as successfully generating the > parcels and setting up the cm cluster. Example run: > http://golden.jenkins.cloudera.com/job/CDH5-Packaging-On-Demand/3029/ > > However, the cluster health checks fail due to: > https://jira.cloudera.com/browse/OPSAPS-36138 > > I have also manually run a cluster with the generated parcels and verified > that things seem to work, so I feel fairly confident about it: > http://tmarshall2-1.vpc.cloudera.com:7180/cmf/home > (I'll shut this down tomorrow morning before I leave) > Scratch that, I had the wrong parcels deployed. Sorry. The cluster I manually ran does not work, though the error it runs into is in Sqoop and doesn't look related to the package rename. > > I'm going on PTO tomorrow for a week, so I won't be working on this more > for now. I'm not sure how urgent it is, but of course someone can take over > from here if needed. > > On Thu, Sep 1, 2016 at 11:40 AM Thomas Tauber-Marshall (Code Review) < > [email protected]> wrote: > >> Thomas Tauber-Marshall has posted comments on this change. >> >> Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) >> .. >> >> >> Patch Set 4: >> >> Currently, the on demand packaging build won't run because there are no >> sles64 nodes online. Do you know what to do about that? >> >> http://golden.jenkins.cloudera.com/job/CDH5-Packaging-On-Demand/3033 >> http://golden.jenkins.cloudera.com/job/generic-package-sles64-11-impala/ >> http://golden.jenkins.cloudera.com/label/static-sles64-11-impala/? >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/3937 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 >> Gerrit-PatchSet: 4 >> Gerrit-Project: Impala-ASF >> Gerrit-Branch: master >> Gerrit-Owner: Thomas Tauber-Marshall >> Gerrit-Reviewer: Jim Apple >> Gerrit-Reviewer: Thomas Tauber-Marshall >> Gerrit-HasComments: No >> >> -- >> You received this message because you are subscribed to the Google Groups >> "impala-cr" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/a/cloudera.com/d/optout >> . >> >
Re: [Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Current status: I can get the packaging build as far as successfully generating the parcels and setting up the cm cluster. Example run: http://golden.jenkins.cloudera.com/job/CDH5-Packaging-On-Demand/3029/ However, the cluster health checks fail due to: https://jira.cloudera.com/browse/OPSAPS-36138 I have also manually run a cluster with the generated parcels and verified that things seem to work, so I feel fairly confident about it: http://tmarshall2-1.vpc.cloudera.com:7180/cmf/home (I'll shut this down tomorrow morning before I leave) I'm going on PTO tomorrow for a week, so I won't be working on this more for now. I'm not sure how urgent it is, but of course someone can take over from here if needed. On Thu, Sep 1, 2016 at 11:40 AM Thomas Tauber-Marshall (Code Review) < [email protected]> wrote: > Thomas Tauber-Marshall has posted comments on this change. > > Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) > .. > > > Patch Set 4: > > Currently, the on demand packaging build won't run because there are no > sles64 nodes online. Do you know what to do about that? > > http://golden.jenkins.cloudera.com/job/CDH5-Packaging-On-Demand/3033 > http://golden.jenkins.cloudera.com/job/generic-package-sles64-11-impala/ > http://golden.jenkins.cloudera.com/label/static-sles64-11-impala/? > > -- > To view, visit http://gerrit.cloudera.org:8080/3937 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 > Gerrit-PatchSet: 4 > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-Owner: Thomas Tauber-Marshall > Gerrit-Reviewer: Jim Apple > Gerrit-Reviewer: Thomas Tauber-Marshall > Gerrit-HasComments: No > > -- > You received this message because you are subscribed to the Google Groups > "impala-cr" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/a/cloudera.com/d/optout. >
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: Currently, the on demand packaging build won't run because there are no sles64 nodes online. Do you know what to do about that? http://golden.jenkins.cloudera.com/job/CDH5-Packaging-On-Demand/3033 http://golden.jenkins.cloudera.com/job/generic-package-sles64-11-impala/ http://golden.jenkins.cloudera.com/label/static-sles64-11-impala/? -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: > I just rebased both patches, and the new version also passes a > private jenkins run: > http://sandbox.jenkins.cloudera.com/job/impala-thirdparty-branching-nobuild-tmarshall/8/ > > I'm having trouble getting the bvt to run. I think the problem is > inconsistencies caused by the ongoing branching and version bumps, > so hopefully that'll be fixed in a few days. Some of that has been cleared up. Does the BVT work now? -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: I just rebased both patches, and the new version also passes a private jenkins run: http://sandbox.jenkins.cloudera.com/job/impala-thirdparty-branching-nobuild-tmarshall/8/ I'm having trouble getting the bvt to run. I think the problem is inconsistencies caused by the ongoing branching and version bumps, so hopefully that'll be fixed in a few days. -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3937 to look at the new patch set (#4). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-3786: Replace "cloudera" with "apache" (part 2) As part of the ASF transition, we need to replace references to Cloudera in Impala with references to Apache. This primarily means changing Java package names from com.cloudera.impala.* to org.apache.impala.* A prior patch renamed all the files as necessary, and this patch performs the actual code changes. Most of the changes in this patch were generated with some commands of the form: find . | grep "\.java\|\.py\|\.h\|\.cc" | \ xargs sed -i s/'com\(.\)cloudera\(\.\)impala/org\1apache\2impala/g along with some manual fixes. After this patch, the remaining references to Cloudera in the repo mostly fall into the categories: - External components that have cloudera in their own package names, eg. com.cloudera.kudu/llama - URLs, eg. https://repository.cloudera.com/ Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 --- M be/src/benchmarks/expr-benchmark.cc M be/src/catalog/catalog.cc M be/src/catalog/catalog.h M be/src/exec/external-data-source-executor.cc M be/src/exec/external-data-source-executor.h M be/src/exprs/hive-udf-call.cc M be/src/scheduling/request-pool-service.cc M be/src/scheduling/request-pool-service.h M be/src/service/fe-support.cc M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/util/jni-util.cc M be/src/util/logging-support.cc M bin/create_testdata.sh M bin/run-jdbc-client.sh M common/function-registry/CMakeLists.txt M common/function-registry/gen_builtins_catalog.py M common/thrift/CatalogInternalService.thrift M common/thrift/CatalogObjects.thrift M common/thrift/CatalogService.thrift M common/thrift/Data.thrift M common/thrift/DataSinks.thrift M common/thrift/Descriptors.thrift M common/thrift/ExecStats.thrift M common/thrift/Exprs.thrift M common/thrift/ExternalDataSource.thrift M common/thrift/Frontend.thrift M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M common/thrift/JniCatalog.thrift M common/thrift/LineageGraph.thrift M common/thrift/Logging.thrift M common/thrift/Metrics.thrift M common/thrift/Partitions.thrift M common/thrift/PlanNodes.thrift M common/thrift/Planner.thrift M common/thrift/ResourceBrokerService.thrift M common/thrift/Results.thrift M common/thrift/RuntimeProfile.thrift M common/thrift/StatestoreService.thrift M common/thrift/Status.thrift M common/thrift/Types.thrift M common/thrift/generate_error_codes.py M common/thrift/generate_metrics.py M ext-data-source/api/pom.xml M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/util/SerializationUtils.java M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/v1/ExternalDataSource.java M ext-data-source/pom.xml M ext-data-source/sample/pom.xml M ext-data-source/sample/src/main/java/org/apache/impala/extdatasource/sample/EchoDataSource.java M ext-data-source/test/pom.xml M ext-data-source/test/src/main/java/org/apache/impala/extdatasource/AllTypesDataSource.java M fe/pom.xml M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableChangeColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java M fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/Authorizatio
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 3: I have branched for 2.7.0 and I anticipate cherry-picking this from master before cutting a release candidate for voting. -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 3: -Code-Review It passed the packaging build: http://golden.jenkins.cloudera.com/job/CDH5-Packaging-Impala-On-Demand/347/ -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 3: Code-Review+1 Rebased -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3937 to look at the new patch set (#3). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-3786: Replace "cloudera" with "apache" (part 2) As part of the ASF transition, we need to replace references to Cloudera in Impala with references to Apache. This primarily means changing Java package names from com.cloudera.impala.* to org.apache.impala.* A prior patch renamed all the files as necessary, and this patch performs the actual code changes. Most of the changes in this patch were generated with some commands of the form: find . | grep "\.java\|\.py\|\.h\|\.cc" | \ xargs sed -i s/'com\(.\)cloudera\(\.\)impala/org\1apache\2impala/g along with some manual fixes. After this patch, the remaining references to Cloudera in the repo mostly fall into the categories: - External components that have cloudera in their own package names, eg. com.cloudera.kudu/llama - URLs, eg. https://repository.cloudera.com/ Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 --- M be/src/benchmarks/expr-benchmark.cc M be/src/catalog/catalog.cc M be/src/catalog/catalog.h M be/src/exec/external-data-source-executor.cc M be/src/exec/external-data-source-executor.h M be/src/exprs/hive-udf-call.cc M be/src/scheduling/request-pool-service.cc M be/src/scheduling/request-pool-service.h M be/src/service/fe-support.cc M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/util/jni-util.cc M be/src/util/logging-support.cc M bin/create_testdata.sh M bin/run-jdbc-client.sh M common/function-registry/CMakeLists.txt M common/function-registry/gen_builtins_catalog.py M common/thrift/CatalogInternalService.thrift M common/thrift/CatalogObjects.thrift M common/thrift/CatalogService.thrift M common/thrift/Data.thrift M common/thrift/DataSinks.thrift M common/thrift/Descriptors.thrift M common/thrift/ExecStats.thrift M common/thrift/Exprs.thrift M common/thrift/ExternalDataSource.thrift M common/thrift/Frontend.thrift M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M common/thrift/JniCatalog.thrift M common/thrift/LineageGraph.thrift M common/thrift/Logging.thrift M common/thrift/Metrics.thrift M common/thrift/Partitions.thrift M common/thrift/PlanNodes.thrift M common/thrift/Planner.thrift M common/thrift/ResourceBrokerService.thrift M common/thrift/Results.thrift M common/thrift/RuntimeProfile.thrift M common/thrift/StatestoreService.thrift M common/thrift/Status.thrift M common/thrift/Types.thrift M common/thrift/generate_error_codes.py M common/thrift/generate_metrics.py M ext-data-source/api/pom.xml M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/util/SerializationUtils.java M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/v1/ExternalDataSource.java M ext-data-source/pom.xml M ext-data-source/sample/pom.xml M ext-data-source/sample/src/main/java/org/apache/impala/extdatasource/sample/EchoDataSource.java M ext-data-source/test/pom.xml M ext-data-source/test/src/main/java/org/apache/impala/extdatasource/AllTypesDataSource.java M fe/pom.xml M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableChangeColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java M fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/Authorizatio
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 2: Code-Review+1 Passed exhaustive tests. -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 2: (1 comment) There's a Jenkins job building this currently: http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/3881/ (it was also run last night and ran into two problems, which have been fixed) http://gerrit.cloudera.org:8080/#/c/3937/1/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: Line 141:<< "This setup is generally unsupported and Impala might be unstable."; > regression Done -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-3786: Replace "cloudera" with "apache" (part 2) As part of the ASF transition, we need to replace references to Cloudera in Impala with references to Apache. This primarily means changing Java package names from com.cloudera.impala.* to org.apache.impala.* A prior patch renamed all the files as necessary, and this patch performs the actual code changes. Most of the changes in this patch were generated with some commands of the form: find . | grep "\.java\|\.py\|\.h\|\.cc" | \ xargs sed -i s/'com\(.\)cloudera\(\.\)impala/org\1apache\2impala/g along with some manual fixes. After this patch, the remaining references to Cloudera in the repo mostly fall into the categories: - External components that have cloudera in their own package names, eg. com.cloudera.kudu/llama - URLs, eg. https://repository.cloudera.com/ Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 --- M be/src/benchmarks/expr-benchmark.cc M be/src/catalog/catalog.cc M be/src/catalog/catalog.h M be/src/exec/external-data-source-executor.cc M be/src/exec/external-data-source-executor.h M be/src/exprs/hive-udf-call.cc M be/src/scheduling/request-pool-service.cc M be/src/scheduling/request-pool-service.h M be/src/service/fe-support.cc M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/util/jni-util.cc M be/src/util/logging-support.cc M bin/create_testdata.sh M bin/run-jdbc-client.sh M common/function-registry/CMakeLists.txt M common/function-registry/gen_builtins_catalog.py M common/thrift/CatalogInternalService.thrift M common/thrift/CatalogObjects.thrift M common/thrift/CatalogService.thrift M common/thrift/Data.thrift M common/thrift/DataSinks.thrift M common/thrift/Descriptors.thrift M common/thrift/ExecStats.thrift M common/thrift/Exprs.thrift M common/thrift/ExternalDataSource.thrift M common/thrift/Frontend.thrift M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M common/thrift/JniCatalog.thrift M common/thrift/LineageGraph.thrift M common/thrift/Logging.thrift M common/thrift/Metrics.thrift M common/thrift/Partitions.thrift M common/thrift/PlanNodes.thrift M common/thrift/Planner.thrift M common/thrift/ResourceBrokerService.thrift M common/thrift/Results.thrift M common/thrift/RuntimeProfile.thrift M common/thrift/StatestoreService.thrift M common/thrift/Status.thrift M common/thrift/Types.thrift M common/thrift/generate_error_codes.py M common/thrift/generate_metrics.py M ext-data-source/api/pom.xml M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/util/SerializationUtils.java M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/v1/ExternalDataSource.java M ext-data-source/pom.xml M ext-data-source/sample/pom.xml M ext-data-source/sample/src/main/java/org/apache/impala/extdatasource/sample/EchoDataSource.java M ext-data-source/test/pom.xml M ext-data-source/test/src/main/java/org/apache/impala/extdatasource/AllTypesDataSource.java M fe/pom.xml M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableChangeColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java M fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/AuthorizationStmt.java M fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java M fe/src/main
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 1: (1 comment) Have you run private-build-and-test in exhaustive exploration mode? http://gerrit.cloudera.org:8080/#/c/3937/1/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: Line 141:<< "which is required. Exiting if Supplemental SSE3 is not functional..."; regression -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/3937 Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-3786: Replace "cloudera" with "apache" (part 2) As part of the ASF transition, we need to replace references to Cloudera in Impala with references to Apache. This primarily means changing Java package names from com.cloudera.impala.* to org.apache.impala.* A prior patch renamed all the files as necessary, and this patch performs the actual code changes. Most of the changes in this patch were generated with some commands of the form: find . | grep "\.java\|\.py\|\.h\|\.cc" | \ xargs sed -i s/'com\(.\)cloudera\(\.\)impala/org\1apache\2impala/g along with some manual fixes. After this patch, the remaining references to Cloudera in the repo mostly fall into the categories: - External components that have cloudera in their own package names, eg. com.cloudera.kudu/llama - URLs, eg. https://repository.cloudera.com/ Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 --- M be/src/benchmarks/expr-benchmark.cc M be/src/catalog/catalog.cc M be/src/catalog/catalog.h M be/src/exec/external-data-source-executor.cc M be/src/exec/external-data-source-executor.h M be/src/exprs/hive-udf-call.cc M be/src/scheduling/request-pool-service.cc M be/src/scheduling/request-pool-service.h M be/src/service/fe-support.cc M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/util/cpu-info.cc M be/src/util/jni-util.cc M be/src/util/logging-support.cc M bin/create_testdata.sh M bin/run-jdbc-client.sh M common/function-registry/CMakeLists.txt M common/function-registry/gen_builtins_catalog.py M common/thrift/CatalogInternalService.thrift M common/thrift/CatalogObjects.thrift M common/thrift/CatalogService.thrift M common/thrift/Data.thrift M common/thrift/DataSinks.thrift M common/thrift/Descriptors.thrift M common/thrift/ExecStats.thrift M common/thrift/Exprs.thrift M common/thrift/ExternalDataSource.thrift M common/thrift/Frontend.thrift M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M common/thrift/JniCatalog.thrift M common/thrift/LineageGraph.thrift M common/thrift/Logging.thrift M common/thrift/Metrics.thrift M common/thrift/Partitions.thrift M common/thrift/PlanNodes.thrift M common/thrift/Planner.thrift M common/thrift/ResourceBrokerService.thrift M common/thrift/Results.thrift M common/thrift/RuntimeProfile.thrift M common/thrift/StatestoreService.thrift M common/thrift/Status.thrift M common/thrift/Types.thrift M common/thrift/generate_error_codes.py M common/thrift/generate_metrics.py M ext-data-source/api/pom.xml M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/util/SerializationUtils.java M ext-data-source/api/src/main/java/org/apache/impala/extdatasource/v1/ExternalDataSource.java M ext-data-source/pom.xml M ext-data-source/sample/pom.xml M ext-data-source/sample/src/main/java/org/apache/impala/extdatasource/sample/EchoDataSource.java M ext-data-source/test/pom.xml M ext-data-source/test/src/main/java/org/apache/impala/extdatasource/AllTypesDataSource.java M fe/pom.xml M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableChangeColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java M fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/AuthorizationStmt.java M fe/src
