[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3815: clean up cross-compiled comparator .. IMPALA-3815: clean up cross-compiled comparator This avoids including a big block of interpreted code in the cross-compiled IR and will make it easier to inline the Compare() function into other codegened functions in a later change. Perf: Ran top-n targeted perf, didn't see any significant change. Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Reviewed-on: http://gerrit.cloudera.org:8080/4307 Reviewed-by: Dan Hecht Tested-by: Internal Jenkins --- M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h 2 files changed, 38 insertions(+), 27 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Dan Hecht has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 3: Turns out the new DCHECKs were incorrect (I must have had a release build running locally when I tested it). Removed them and added a comment explaining the lifetime of the exprs. -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Hello Michael Ho, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4307 to look at the new patch set (#3). Change subject: IMPALA-3815: clean up cross-compiled comparator .. IMPALA-3815: clean up cross-compiled comparator This avoids including a big block of interpreted code in the cross-compiled IR and will make it easier to inline the Compare() function into other codegened functions in a later change. Perf: Ran top-n targeted perf, didn't see any significant change. Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab --- M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h 2 files changed, 38 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/4307/3 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 2: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/175/ -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Dan Hecht has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Michael Ho has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4307 Change subject: IMPALA-3815: clean up cross-compiled comparator .. IMPALA-3815: clean up cross-compiled comparator This avoids including a big block of interpreted code in the cross-compiled IR and will make it easier to inline the Compare() function into other codegened functions in a later change. Perf: Ran top-n targeted perf, didn't see any significant change. Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab --- M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h 2 files changed, 34 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/4307/1 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
