[Impala-ASF-CR] Minor enhancements to helper scripts.
Internal Jenkins has posted comments on this change. Change subject: Minor enhancements to helper scripts. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Ivanfi Gerrit-HasComments: No
[Impala-ASF-CR] Minor enhancements to helper scripts.
Internal Jenkins has submitted this change and it was merged. Change subject: Minor enhancements to helper scripts. .. Minor enhancements to helper scripts. - run-all-tests.sh: survive non-fatal failures when calling ulimit. - copy-udfs-udas.sh: respect $MAKE_CMD instead of blindly using make. Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 Reviewed-on: http://gerrit.cloudera.org:8080/4304 Reviewed-by: Tim Armstrong Tested-by: Internal Jenkins --- M bin/run-all-tests.sh M testdata/bin/copy-udfs-udas.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Ivanfi
[Impala-ASF-CR] Minor enhancements to helper scripts.
Zoltan Ivanfi has posted comments on this change.
Change subject: Minor enhancements to helper scripts.
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4304/3/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:
PS3, Line 51: "-j${IMPALA_BUILD_THREADS:-4}"
> quotes don't seem necessary here
They are not strictly necessary, unless someone abuses the IMPALA_BUILD_THREADS
variable. It is recommended to always quote variables in shell scripts just to
be sure (https://google.github.io/styleguide/shell.xml#Variable_expansion,
http://www.dwheeler.com/essays/filenames-in-shell.html#doublequote).
--
To view, visit http://gerrit.cloudera.org:8080/4304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zoltan Ivanfi
Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor enhancements to helper scripts.
Tim Armstrong has posted comments on this change.
Change subject: Minor enhancements to helper scripts.
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4304/3/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:
PS3, Line 51: "-j${IMPALA_BUILD_THREADS:-4}"
quotes don't seem necessary here
--
To view, visit http://gerrit.cloudera.org:8080/4304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zoltan Ivanfi
Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor enhancements to helper scripts.
Zoltan Ivanfi has posted comments on this change.
Change subject: Minor enhancements to helper scripts.
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4304/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:
Line 104: ulimit -c unlimited ||:
> || true
Done
http://gerrit.cloudera.org:8080/#/c/4304/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:
PS2, Line 51: CORES
> Can you make this -j${IMPALA_BUILD_THREADS:-4} for consistency with other m
Done
--
To view, visit http://gerrit.cloudera.org:8080/4304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zoltan Ivanfi
Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor enhancements to helper scripts.
Zoltan Ivanfi has uploaded a new patch set (#3). Change subject: Minor enhancements to helper scripts. .. Minor enhancements to helper scripts. - run-all-tests.sh: survive non-fatal failures when calling ulimit. - copy-udfs-udas.sh: respect $MAKE_CMD instead of blindly using make. Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 --- M bin/run-all-tests.sh M testdata/bin/copy-udfs-udas.sh 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/4304/3 -- To view, visit http://gerrit.cloudera.org:8080/4304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Minor enhancements to helper scripts.
Tim Armstrong has posted comments on this change.
Change subject: Minor enhancements to helper scripts.
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4304/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:
Line 104: ulimit -c unlimited ||:
|| true
for consistency with the rest of the scripts (one less bash feature for people
to understand).
http://gerrit.cloudera.org:8080/#/c/4304/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:
Line 51: "${MAKE_CMD:-make}" -j$CORES \
Nice catch, looks like I missed this one.
PS2, Line 51: CORES
Can you make this -j${IMPALA_BUILD_THREADS:-4} for consistency with other make
invocations?
--
To view, visit http://gerrit.cloudera.org:8080/4304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor enhancements to helper scripts.
Zoltan Ivanfi has uploaded a new patch set (#2). Change subject: Minor enhancements to helper scripts. .. Minor enhancements to helper scripts. - run-all-tests.sh: survive non-fatal failures when calling ulimit. - copy-udfs-udas.sh: respect $MAKE_CMD instead of blindly using make. Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 --- M bin/run-all-tests.sh M testdata/bin/copy-udfs-udas.sh 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/4304/2 -- To view, visit http://gerrit.cloudera.org:8080/4304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi
[Impala-ASF-CR] Minor enhancements to helper scripts.
Zoltan Ivanfi has uploaded a new change for review. http://gerrit.cloudera.org:8080/4304 Change subject: Minor enhancements to helper scripts. .. Minor enhancements to helper scripts. - Make run-all-tests.sh survive non-fatal failures when calling ulimit. - Respect MAKE_CMD instead of blindly using make in copy-udfs-udas.sh. Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 --- M bin/run-all-tests.sh M testdata/bin/copy-udfs-udas.sh 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/4304/1 -- To view, visit http://gerrit.cloudera.org:8080/4304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi
