[Impala-ASF-CR] PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend
Lars Volker has abandoned this change. Change subject: PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend .. Abandoned Merged an alternative approach to testing. -- To view, visit http://gerrit.cloudera.org:8080/3982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia77d54ae72ae87fbf279623c4924be2943a84a3e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend
Matthew Jacobs has posted comments on this change. Change subject: PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend .. Patch Set 1: I made a comment on the JIRA, but I'd question this approach. I think that in practice this bug only affects the mini cluster, right? Outside of the minicluster, nobody should run multiple impalads per host (that are associated with the same Impala cluster). I think we should consider simplifying the SimpleScheduler to not attempt to schedule on multiple impalads on the same host. -- To view, visit http://gerrit.cloudera.org:8080/3982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia77d54ae72ae87fbf279623c4924be2943a84a3e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/3982 Change subject: PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend .. PREVIEW, please see the ongoing discussion in the Jira IMPALA-3944: Fix for BackendConfig::RemoveBackend SimpleScheduler::BackendConfig maintains two maps, hostname->IP and IP->[list of backends]. In situations where multiple backends run on a single host, BackendConfig::RemoveBackend was erroneously removing the hostname->IP mapping, even when the list of backends for a host was not empty. The fix is to only remove this mapping when the last backend of a host gets removed. Change-Id: Ia77d54ae72ae87fbf279623c4924be2943a84a3e --- M be/src/scheduling/simple-scheduler-test.cc M be/src/scheduling/simple-scheduler.cc 2 files changed, 64 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/3982/1 -- To view, visit http://gerrit.cloudera.org:8080/3982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia77d54ae72ae87fbf279623c4924be2943a84a3e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker
