[Impala-CR](cdh5-2.3.0_5.5.x) IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr
Bharath Vissapragada has submitted this change and it was merged. Change subject: IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr .. IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr This commit fixes the issue where an incorrect rewrite is performed for the case of uncorrelated aggregate subqueries participating in a NOT IN expr with a constant. With this commit we detect cases like this and throw an AnalysisException. Change-Id: Ia05ebc70ef310a0ec6f00ae6ae1c5de8fbd50240 Reviewed-on: http://gerrit.cloudera.org:8080/2007 Reviewed-by: Dimitris Tsirogiannis Tested-by: Internal Jenkins (cherry picked from commit bf6fabd1029ffb3f087076a786ef9864509daef6) Reviewed-on: http://gerrit.cloudera.org:8080/2158 Reviewed-by: Bharath Vissapragada Tested-by: Bharath Vissapragada --- M fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Bharath Vissapragada: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia05ebc70ef310a0ec6f00ae6ae1c5de8fbd50240 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.3.0_5.5.x Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu
[Impala-CR](cdh5-2.3.0_5.5.x) IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr
Hello Juan Yu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2158 to look at the new patch set (#2). Change subject: IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr .. IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr This commit fixes the issue where an incorrect rewrite is performed for the case of uncorrelated aggregate subqueries participating in a NOT IN expr with a constant. With this commit we detect cases like this and throw an AnalysisException. Change-Id: Ia05ebc70ef310a0ec6f00ae6ae1c5de8fbd50240 Reviewed-on: http://gerrit.cloudera.org:8080/2007 Reviewed-by: Dimitris Tsirogiannis Tested-by: Internal Jenkins (cherry picked from commit bf6fabd1029ffb3f087076a786ef9864509daef6) --- M fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/58/2158/2 -- To view, visit http://gerrit.cloudera.org:8080/2158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia05ebc70ef310a0ec6f00ae6ae1c5de8fbd50240 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.3.0_5.5.x Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu
[Impala-CR](cdh5-2.3.0_5.5.x) IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr .. Patch Set 2: Code-Review+2 Verified+1 http://sandbox.jenkins.cloudera.com/job/impala-master-64bit-PRIVATE/2636/ - passed -- To view, visit http://gerrit.cloudera.org:8080/2158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia05ebc70ef310a0ec6f00ae6ae1c5de8fbd50240 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.3.0_5.5.x Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu Gerrit-HasComments: No
[Impala-CR](cdh5-2.3.0_5.5.x) IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr
Juan Yu has posted comments on this change. Change subject: IMPALA-2093: Disallow NOT IN aggregate subqueries with a constant lhs expr .. Patch Set 1: @Bharath, did you run test job for it? If all tests passed, please commit this. thanks. -- To view, visit http://gerrit.cloudera.org:8080/2158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia05ebc70ef310a0ec6f00ae6ae1c5de8fbd50240 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.3.0_5.5.x Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu Gerrit-HasComments: No
