[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. IMPALA-3143: Fix permission check when user belongs to supergroup This commit fixes an issue where a permission check warning is incorrectly generated when a user that belongs to the supergroup issues a create database statement. The fix is to also check if the user belongs to the supergroup when checking for permissions and ACLs. Testing: This change was tested manually by creating an HDFS directory D that belonged to user/group A and running a CREATE DATABASE foo LOCALTION 'D' statement as a user B that belongs to the 'supergroup' group; the test verified that when the supergroup is taken into account, no permision check warning is issued. Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Reviewed-on: http://gerrit.cloudera.org:8080/3164 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M fe/src/main/java/com/cloudera/impala/util/FsPermissionChecker.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Alex Behm has posted comments on this change. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. IMPALA-3143: Fix permission check when user belongs to supergroup This commit fixes an issue where a permission check warning is incorrectly generated when a user that belongs to the supergroup issues a create database statement. The fix is to also check if the user belongs to the supergroup when checking for permissions and ACLs. Testing: This change was tested manually by creating an HDFS directory D that belonged to user/group A and running a CREATE DATABASE foo LOCALTION 'D' statement as a user B that belongs to the 'supergroup' group; the test verified that when the supergroup is taken into account, no permision check warning is issued. Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d --- M fe/src/main/java/com/cloudera/impala/util/FsPermissionChecker.java 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/3164/2 -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Alex Behm has posted comments on this change. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3164/1//COMMIT_MSG Commit Message: Line 13: Please update the commit msg with the testing you have done to validate this change, -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. Patch Set 1: Unfortunately, it's not that simple as changing a test in TestPermissionValidation(). We need to: a) create a path the owner of which is not the current user (that runs the tests) and b) make sure the current user belongs to the "supergroup" group, which based on what I've seen, is not the default setup. -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Alex Behm has posted comments on this change. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. Patch Set 1: Maybe you can fix a test in here? AnalyzeDDLTest.TestPermissionValidation() -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. Patch Set 1: I don't have a good way to create a test for that. Let me know if you have any ideas on that. -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3143: Fix permission check when user belongs to supergroup
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/3164 Change subject: IMPALA-3143: Fix permission check when user belongs to supergroup .. IMPALA-3143: Fix permission check when user belongs to supergroup This commit fixes an issue where a permission check warning is incorrectly generated when a user that belongs to the supergroup issues a create database statement. The fix is to also check if the user belongs to the supergroup when checking for permissions and ACLs. Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d --- M fe/src/main/java/com/cloudera/impala/util/FsPermissionChecker.java 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/3164/1 -- To view, visit http://gerrit.cloudera.org:8080/3164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2bb703ac70280c62db404db2c07d87139aa5ae0d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Dimitris Tsirogiannis
