[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-19 Thread Internal Jenkins (Code Review) 
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3569: handle errors in timezone db initialization
..


IMPALA-3569: handle errors in timezone db initialization

Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Reviewed-on: http://gerrit.cloudera.org:8080/3125
Reviewed-by: Dan Hecht 
Tested-by: Internal Jenkins
---
M be/src/common/init.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/timestamp-functions-ir.cc
M be/src/exprs/timestamp-functions.h
M be/src/exprs/timezone_db.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
7 files changed, 42 insertions(+), 47 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-19 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3569: handle errors in timezone db initialization
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-19 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3569: handle errors in timezone db initialization
..


Patch Set 3:

It turned out a backend test was indirectly including timestamp-functions.h via 
runtime-state.h. Fixed that.

-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-19 Thread Tim Armstrong (Code Review) 
Hello Internal Jenkins, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3125

to look at the new patch set (#3).

Change subject: IMPALA-3569: handle errors in timezone db initialization
..

IMPALA-3569: handle errors in timezone db initialization

Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
---
M be/src/common/init.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/timestamp-functions-ir.cc
M be/src/exprs/timestamp-functions.h
M be/src/exprs/timezone_db.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
7 files changed, 42 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/25/3125/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-18 Thread Tim Armstrong (Code Review) 
Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3125

to look at the new patch set (#2).

Change subject: IMPALA-3569: handle errors in timezone db initialization
..

IMPALA-3569: handle errors in timezone db initialization

Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
---
M be/src/common/init.cc
M be/src/exprs/timestamp-functions-ir.cc
M be/src/exprs/timestamp-functions.h
M be/src/exprs/timezone_db.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
6 files changed, 41 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/25/3125/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-18 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3569: handle errors in timezone db initialization
..


Patch Set 2: Code-Review+2

Rebase

-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-18 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3569: handle errors in timezone db initialization
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3569: handle errors in timezone db initialization

2016-05-18 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3125

Change subject: IMPALA-3569: handle errors in timezone db initialization
..

IMPALA-3569: handle errors in timezone db initialization

Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
---
M be/src/common/init.cc
M be/src/exprs/timestamp-functions-ir.cc
M be/src/exprs/timestamp-functions.h
M be/src/exprs/timezone_db.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
6 files changed, 41 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/25/3125/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b4d5e6b992ea023f801edb7b487e57f39920c03
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong