[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-25 Thread Internal Jenkins (Code Review) 
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Reviewed-on: http://gerrit.cloudera.org:8080/3171
Reviewed-by: Taras Bobrovytsky 
Tested-by: Internal Jenkins
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M bin/collect_minidumps.py
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_breakpad.py
5 files changed, 72 insertions(+), 28 deletions(-)

Approvals:
  Taras Bobrovytsky: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 6:

(1 comment)

Thanks for the review, please see PS7.

http://gerrit.cloudera.org:8080/#/c/3171/6/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 176: e
> nit: capital E
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Hello Taras Bobrovytsky, Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3171

to look at the new patch set (#7).

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M bin/collect_minidumps.py
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_breakpad.py
5 files changed, 72 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3171/6/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 176: e
nit: capital E


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 5:

(3 comments)

Thank you for the review. Please see PS6.

http://gerrit.cloudera.org:8080/#/c/3171/5/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 169: \
> I think it would be nicer without this character, like this:
Done


Line 174: minidump_path
> I think you should rename this to result, like this:
Done


Line 176: sys.exit(1)
> Should we print a message to stderr here? something like "minidump director
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Hello Taras Bobrovytsky, Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3171

to look at the new patch set (#6).

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M bin/collect_minidumps.py
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_breakpad.py
5 files changed, 72 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3171/5/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 169: \
I think it would be nicer without this character, like this:
minidump_path = get_config_parameter_value(
conf_dir, role_name, 'minidump_path') or 'minidumps'


Line 174: minidump_path
I think you should rename this to result, like this:
result = os.path.join(minidump_path, role_name)


Line 176: sys.exit(1)
Should we print a message to stderr here? something like "minidump directory 
does not exist"


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 4:

(6 comments)

Thank you for the review. Please see PS5.

http://gerrit.cloudera.org:8080/#/c/3171/4/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 143: get_config_value
> How about get config_parameter_value?
Done


Line 143: key
> Can you rename this to something more descriptive? maybe config_parameter_n
Done


Line 163:   '''Extracts the minidump directory path for a given role from the 
configuration file.'''
> Update the comment, and briefly describe the logic. Maybe say if nothing is
Done


Line 164: result
> it's confusing that you keep on reusing the same variable "result". Maybe r
Done


Line 167: result
> Rename to minidump_path here as well
Done


Line 170: sys.exit(0)
> Why isn't this an error any more?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Hello Taras Bobrovytsky, Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3171

to look at the new patch set (#5).

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M bin/collect_minidumps.py
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_breakpad.py
5 files changed, 71 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/3171/4/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 143: key
Can you rename this to something more descriptive? maybe config_parameter_name?


Line 143: get_config_value
How about get config_parameter_value?


Line 163:   '''Extracts the minidump directory path for a given role from the 
configuration file.'''
Update the comment, and briefly describe the logic. Maybe say if nothing is 
specified, we will assume the minidumps go to log_dir/minidumps, etc


Line 164: result
it's confusing that you keep on reusing the same variable "result". Maybe 
rename it to minidump_path here?


Line 167: result
Rename to minidump_path here as well


Line 170: sys.exit(0)
Why isn't this an error any more?


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Hello Taras Bobrovytsky, Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3171

to look at the new patch set (#4).

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M bin/collect_minidumps.py
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_breakpad.py
5 files changed, 63 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 3: Code-Review+2

LGTM

-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 3: Code-Review+2

Please see if Alex wants to take another look, but looks fine to me.

-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 1:

(2 comments)

Thanks for the reviews, please see PS3.

http://gerrit.cloudera.org:8080/#/c/3171/1//COMMIT_MSG
Commit Message:

Line 12: name collisions in case of local test clusters and strangely 
configured installations.
> After this change, where will the mini dumps appear in our local test setup
Added a comment.


http://gerrit.cloudera.org:8080/#/c/3171/1/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 123: self.start_cluster_with_args()
> how does this end up starting with a relative dir rather than using self.tm
Added a comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new patch set (#3).

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
3 files changed, 37 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

For local test clusters the minidumps will be written to
$IMPALA_HOME/logs/cluster/minidumps/{catalogd,impalad,statestored}.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
3 files changed, 35 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-23 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3171/1//COMMIT_MSG
Commit Message:

Line 12: name collisions in case of local test clusters and strangely 
configured installations.
After this change, where will the mini dumps appear in our local test setup?


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-23 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3171/1/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 123: self.start_cluster_with_args()
how does this end up starting with a relative dir rather than using 
self.tmp_dir?


-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-23 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3171

Change subject: IMPALA-3581: Change location of minidump folders to log_dir
..

IMPALA-3581: Change location of minidump folders to log_dir

Currently the default minidump location is /tmp/impala-minidumps, which can be 
wiped on
reboot on various distributions. This change moves the default location to
FLAGS_log_dir/minidumps/$daemon. The additional trailing $daemon folder is kept 
to prevent
name collisions in case of local test clusters and strangely configured 
installations.

Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
3 files changed, 35 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3171/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker