[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has abandoned this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

Please update to using the new gerrit project, "Impala-ASF".
Instructions are here:

https://cwiki.apache.org/confluence/display/IMPALA/How+to+switch+to+Apache-hosted+git

Pushes to this project will be disabled on October 1.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

Hi Abdur. Is there anything we can do to lend you a hand?

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

> As a reminder, the gerrit "Impala" project is now deprecated. To
 > lear now to switch, read
 > 
 > http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/201607.mbox/%3ccac-psx2shyqsoxgcckrqmqbo-jjwdp6cmgotu_1snuqvkdv...@mail.gmail.com%3E
 > 
 > To make sure you receive all messages that look like this,
 > subscribe to
 > 
 > http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/

How is it going?

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

As a reminder, the gerrit "Impala" project is now deprecated. To lear now to 
switch, read

http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/201607.mbox/%3ccac-psx2shyqsoxgcckrqmqbo-jjwdp6cmgotu_1snuqvkdv...@mail.gmail.com%3E

To make sure you receive all messages that look like this, subscribe to

http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

> > > Oh. I was working on a docker image, and last time i tested was
 > > > more than 2 months ago. I can look for the recent version of
 > > > cdh5-trunk later in the day today.
 > >
 > > How is it going?
 > 
 > Hi Jim. Sorry for the delayed response. I am in the middle of
 > preparing for my MS defense, so i wont be able to take time out for
 > testing this before 5th of August. I will be able solve this after
 > that. It will be really hard before that. I hope you understand. If
 > you can wait till then, it fine. If not, I understand. Thanks.

Yes, it is OK to wait two weeks. Good luck on your defense!

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Abdur Rafay (Code Review)]

Abdur Rafay has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

> > Oh. I was working on a docker image, and last time i tested was
 > > more than 2 months ago. I can look for the recent version of
 > > cdh5-trunk later in the day today.
 > 
 > How is it going?

Hi Jim. Sorry for the delayed response. I am in the middle of preparing for my 
MS defense, so i wont be able to take time out for testing this before 5th of 
August. I will be able solve this after that. It will be really hard before 
that. I hope you understand. If you can wait till then, it fine. If not, I 
understand. Thanks.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

> Oh. I was working on a docker image, and last time i tested was
 > more than 2 months ago. I can look for the recent version of
 > cdh5-trunk later in the day today.

How is it going?

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Abdur Rafay (Code Review)]

Abdur Rafay has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

Oh. I was working on a docker image, and last time i tested was more than 2 
months ago. I can look for the recent version of cdh5-trunk later in the day 
today.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Abdur Rafay (Code Review)]

Abdur Rafay has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

We "were" able to expose them as built-in functions and i tested them on a 
small sample data (TPCH) at that time. The problem we had was that we were 
unable to generate tests at that time.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

"all the functions" wasn't the concern of Skye on March 15. Instead, she 
explained that these are not exposed as built-in aggregate funcitons in Impala.

If there was something about her comment that isn't clear, I would be happy to 
try and help you decipher it.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Abdur Rafay (Code Review)]

Abdur Rafay has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 2:

Hi Jim, i just uploaded all the functions i implemented. The implementation of 
Median was done using KLL algorithm, which can be found here: 
http://arxiv.org/pdf/1603.05346v2.pdf
Let me know if i have to do anything else. Sorry for the delay.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Abdur Rafay (Code Review)]

Abdur Rafay has uploaded a new patch set (#2).

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..

IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
---
M be/src/exprs/aggregate-functions.cc
M be/src/exprs/aggregate-functions.h
2 files changed, 743 insertions(+), 178 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/34/2534/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 1:

> > > Abdur, are you still interested in working on this?
 > >
 > > Jim, i have written all the functions already, including Median
 > > using KLL algorithm. I was working with Skye but we were unable
 > to
 > > generate the test data to test them. I have tested the functions
 > on
 > > TPCH and they work fine. I can provide you with the code if you
 > > want.
 > 
 > I think it would be best to upload what you have done to this
 > location so I (or someone else) can help review it

Is there anything I can do to assist you?

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Abdur Rafay
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 1:

> > Abdur, are you still interested in working on this?
 > 
 > Jim, i have written all the functions already, including Median
 > using KLL algorithm. I was working with Skye but we were unable to
 > generate the test data to test them. I have tested the functions on
 > TPCH and they work fine. I can provide you with the code if you
 > want.

I think it would be best to upload what you have done to this location so I (or 
someone else) can help review it

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Anonymous Coward #200
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Anonymous Coward (Code Review)]

Anonymous Coward #200 has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 1:

> Abdur, are you still interested in working on this?

Jim, i have written all the functions already, including Median using KLL 
algorithm. I was working with Skye but we were unable to generate the test data 
to test them. I have tested the functions on TPCH and they work fine. I can 
provide you with the code if you want.

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Anonymous Coward #200
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..


Patch Set 1:

Abdur, are you still interested in working on this?

-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Skye Wanderman-Milne 
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

[Abdur Rafay (Code Review)]

Abdur Rafay has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2534

Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate 
corr().
..

IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
---
M be/src/exprs/aggregate-functions.cc
M be/src/exprs/aggregate-functions.h
2 files changed, 86 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/34/2534/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Abdur Rafay