[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Skye Wanderman-Milne has submitted this change and it was merged. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option test_annotate_utf8_option was failing in the exhaustive build because some other test was switching the session database from 'default' to 'functional_parquet'. This patch amends the patch to use the new 'unique_database' fixture, which both ensures the table will be created in the expected database and handles table cleanup. Change-Id: I981475581340edc0be68fa2813f5e63990202399 Reviewed-on: http://gerrit.cloudera.org:8080/2586 Reviewed-by: Skye Wanderman-Milne Tested-by: Skye Wanderman-Milne --- M tests/query_test/test_scanners.py 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Skye Wanderman-Milne: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. Patch Set 3: Verified+1 verified via private exhaustive build: http://sandbox.jenkins.cloudera.com/job/impala-master-64bit-PRIVATE/2659/ -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Hello Michael Brown, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2586 to look at the new patch set (#3). Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option test_annotate_utf8_option was failing in the exhaustive build because some other test was switching the session database from 'default' to 'functional_parquet'. This patch amends the patch to use the new 'unique_database' fixture, which both ensures the table will be created in the expected database and handles table cleanup. Change-Id: I981475581340edc0be68fa2813f5e63990202399 --- M tests/query_test/test_scanners.py 1 file changed, 7 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/2586/3 -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Skye Wanderman-Milne has uploaded a new change for review. http://gerrit.cloudera.org:8080/2586 Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option test_annotate_utf8_option was failing in the exhaustive build because some other test was switching the session database from 'default' to 'functional_parquet'. This patch amends the patch to use the new 'unique_database' fixture, which both ensures the table will be created in the expected database and handles table cleanup. Change-Id: I981475581340edc0be68fa2813f5e63990202399 --- M tests/query_test/test_scanners.py 1 file changed, 7 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/2586/1 -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Michael Brown has posted comments on this change. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Michael Brown has posted comments on this change. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2586/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 246: def test_annotate_utf8_option(self, unique_database): Fwiw, unique_databases works with vector. Did you intentionally remove vector? -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Skye Wanderman-Milne has uploaded a new patch set (#2). Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option test_annotate_utf8_option was failing in the exhaustive build because some other test was switching the session database from 'default' to 'functional_parquet'. This patch amends the patch to use the new 'unique_database' fixture, which both ensures the table will be created in the expected database and handles table cleanup. Change-Id: I981475581340edc0be68fa2813f5e63990202399 --- M tests/query_test/test_scanners.py 1 file changed, 7 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/2586/2 -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Dan Hecht has posted comments on this change. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. Patch Set 2: Code-Review+1 Please get Michael B's to sign off. -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3195: explicitly specify unique database in TestScanners.test_annotate_utf8_option .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2586/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 246: def test_annotate_utf8_option(self, unique_database): > Fwiw, unique_databases works with vector. Did you intentionally remove vect No, I didn't realize that. I'll add it back. -- To view, visit http://gerrit.cloudera.org:8080/2586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981475581340edc0be68fa2813f5e63990202399 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: Yes
