[Impala-CR](cdh5-trunk) IMPALA-3711: Only check privilege when needed
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Only check privilege when needed .. Patch Set 3: I will update comments. but code change is ready for review.. -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3711: Only check privilege when needed
Huaisi Xu has uploaded a new patch set (#3). Change subject: IMPALA-3711: Only check privilege when needed .. IMPALA-3711: Only check privilege when needed Previously getSchemas() checks privileges for all databases and tables; getTables() checks for all columns, which can lead to bad performance. This patch avoids checking unnecessary privileges. Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 --- M fe/src/main/java/com/cloudera/impala/catalog/Catalog.java M fe/src/main/java/com/cloudera/impala/service/Frontend.java M fe/src/main/java/com/cloudera/impala/service/JniCatalog.java M fe/src/main/java/com/cloudera/impala/service/JniFrontend.java M fe/src/main/java/com/cloudera/impala/service/MetadataOp.java M fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java 6 files changed, 52 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3371/3 -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu
[Impala-CR](cdh5-trunk) IMPALA-3711: Only check privilege when needed
Huaisi Xu has uploaded a new patch set (#2). Change subject: IMPALA-3711: Only check privilege when needed .. IMPALA-3711: Only check privilege when needed Previously getSchemas() checks privileges for all databases and tables; getTables() checks for all columns, which can lead to bad performance. This patch avoids checking unnecessary privileges. Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 --- M fe/src/main/java/com/cloudera/impala/catalog/Catalog.java M fe/src/main/java/com/cloudera/impala/service/Frontend.java M fe/src/main/java/com/cloudera/impala/service/JniCatalog.java M fe/src/main/java/com/cloudera/impala/service/JniFrontend.java M fe/src/main/java/com/cloudera/impala/service/MetadataOp.java M fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java 6 files changed, 53 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3371/2 -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu
