[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Internal Jenkins has submitted this change and it was merged. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Kudu: Exclude non-Kudu symbols during stub client generation Previously boost related symbols (and others) would get defined in the Kudu client stub with a non-functional implementation. If these implementations were used at runtime they would crash Impala. Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Reviewed-on: http://gerrit.cloudera.org:8080/2864 Reviewed-by: Tim Armstrong Tested-by: Internal Jenkins --- M bin/bootstrap_toolchain.py 1 file changed, 105 insertions(+), 97 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: > Manual testing is ok, but let's make sure we get automated coverage > set up Ya the rhel 5 job failed due to a crash. I'm hoping its this. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: Manual testing is ok, but let's make sure we get automated coverage set up -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: Tim are you ok with this? I'm still in the process of setting up the rhel 5 job. I did manual testing and it was fine. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: > (1 comment) > > Were you able to test this, at least manually for now? I think > that's OK for getting this in. We also need to talk to Alex about > changes to the jenkins jobs as we were talking about. The be tests passed. I still need to setup that rhel 5 job. Maybe I can do that today. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: > (1 comment) > > Were you able to test this, at least manually for now? I think > that's OK for getting this in. We also need to talk to Alex about > changes to the jenkins jobs as we were talking about. FWIW there are some weak symbols from Kudu that look like they're related to templates. It's probably fine not to have them, but we should run a private job to test. mj@mj-desktop:~/dev/Impala$ nm --defined-only -D ./toolchain/kudu-0.8.0-RC1/release/lib/libkudu_client.so | grep " W " | c++filt | grep "kudu::" 0009d8e0 W kudu::Status kudu::KuduPartialRow::SetSliceCopy >(int, kudu::Slice const&) 0009f060 W kudu::Status kudu::KuduPartialRow::SetSliceCopy >(kudu::Slice const&, kudu::Slice const&) 0009d630 W kudu::Status kudu::KuduPartialRow::SetSliceCopy >(int, kudu::Slice const&) 0009e910 W kudu::Status kudu::KuduPartialRow::SetSliceCopy >(kudu::Slice const&, kudu::Slice const&) 0009f520 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)10>::cpp_type const&, bool) 000a11e0 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)10>::cpp_type const&, bool) 0009f750 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)11>::cpp_type const&, bool) 000a1650 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)11>::cpp_type const&, bool) 0009edd0 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)12>::cpp_type const&, bool) 000a23a0 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)12>::cpp_type const&, bool) 0009e450 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)13>::cpp_type const&, bool) 000a0d70 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)13>::cpp_type const&, bool) 0009db90 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)1>::cpp_type const&, bool) 0009fbb0 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)1>::cpp_type const&, bool) 0009ddc0 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)3>::cpp_type const&, bool) 000a0020 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)3>::cpp_type const&, bool) 0009dff0 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)5>::cpp_type const&, bool) 000a0490 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)5>::cpp_type const&, bool) 0009e220 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)7>::cpp_type const&, bool) 000a0900 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)7>::cpp_type const&, bool) 0009e680 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)8>::cpp_type const&, bool) 000a1f30 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)8>::cpp_type const&, bool) 0009f980 W kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)9>::cpp_type const&, bool) 000a1ac0 W kudu::Status kudu::KuduPartialRow::Set >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)9>::cpp_type const&, bool) 000a3830 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)10>::cpp_type*) const 000a3ae0 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)11>::cpp_type*) const 000a4050 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)12>::cpp_type*) const 000a3580 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)13>::cpp_type*) const 000a2ac0 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)1>::cpp_type*) const 000a2d70 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)3>::cpp_type*) const 000a3020 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)5>::cpp_type*) const 000a32d0 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)7>::cpp_type*) const 000a3d90 W kudu::Status kudu::KuduPartialRow::Get >(int, kudu::TypeTraits<(kudu::DataType)8>::cpp_type*) const 000a2810 W kudu::Status kudu::KuduPartia
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 2: (1 comment) Were you able to test this, at least manually for now? I think that's OK for getting this in. We also need to talk to Alex about changes to the jenkins jobs as we were talking about. http://gerrit.cloudera.org:8080/#/c/2864/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 258: an and? -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2864/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 127: def build_kudu_stub(toolchain_root, kudu_version, compiler): > Can we move this logic to a different file? Or at least to the bottom of th Moved to the bottom. Line 186: if sym_type.upper() not in "TW": > Was stubbing weak symbols necessary to get impala to think? This is all ver I never tried that. I used to think Todd knew what he was doing :) It turns out only the strong symbols are needed. At least things compile and the be tests pass. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2864 to look at the new patch set (#2). Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Kudu: Exclude non-Kudu symbols during stub client generation Previously boost related symbols (and others) would get defined in the Kudu client stub with a non-functional implementation. If these implementations were used at runtime they would crash Impala. Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 --- M bin/bootstrap_toolchain.py 1 file changed, 105 insertions(+), 97 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/2864/2 -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: I'm fine with nightly or weekly so long as it won't break silently :) -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2864/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 127: def build_kudu_stub(toolchain_root, kudu_version, compiler): Can we move this logic to a different file? Or at least to the bottom of this file. It's really confusing to read this file when there is a big block of Kudu-specific logic in the middle of the regular bootstrap logic. Line 186: if sym_type.upper() not in "TW": Was stubbing weak symbols necessary to get impala to think? This is all very confusing and I can't really reason about what is and isn't necessary. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
Re: [Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Yeah I agree I think it'd be useful. How about weekly then? On Mon, Apr 25, 2016 at 8:25 PM Tim Armstrong wrote: > Sounds like useful coverage, although nightly might even be overkill. > > On Mon, Apr 25, 2016 at 8:22 PM, Casey Ching (Code Review) < > [email protected]> wrote: > >> Casey Ching has posted comments on this change. >> >> Change subject: Kudu: Exclude non-Kudu symbols during stub client >> generation >> .. >> >> >> Patch Set 1: >> >> > didn't he say it occurred while executing some BE tests. He may >> > have had something wrong with his setup, but having a private build >> > succeed on a supported and non-supported OS seems like it would be >> > the minimum coverage we should have. The customer cluster test is a >> > good idea too. Or can we just write a BE test that calls into it? >> >> Ah you are right, the be tests failed. >> >> What do you guys think about just setting up a nightly rhel 5 job? It >> would be nice to have coverage there anyhow and its really simple to do. I >> can set it up. >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/2864 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 >> Gerrit-PatchSet: 1 >> Gerrit-Project: Impala >> Gerrit-Branch: cdh5-trunk >> Gerrit-Owner: Casey Ching >> Gerrit-Reviewer: Casey Ching >> Gerrit-Reviewer: Matthew Jacobs >> Gerrit-Reviewer: Tim Armstrong >> Gerrit-HasComments: No >> > >
Re: [Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Sounds like useful coverage, although nightly might even be overkill. On Mon, Apr 25, 2016 at 8:22 PM, Casey Ching (Code Review) < [email protected]> wrote: > Casey Ching has posted comments on this change. > > Change subject: Kudu: Exclude non-Kudu symbols during stub client > generation > .. > > > Patch Set 1: > > > didn't he say it occurred while executing some BE tests. He may > > have had something wrong with his setup, but having a private build > > succeed on a supported and non-supported OS seems like it would be > > the minimum coverage we should have. The customer cluster test is a > > good idea too. Or can we just write a BE test that calls into it? > > Ah you are right, the be tests failed. > > What do you guys think about just setting up a nightly rhel 5 job? It > would be nice to have coverage there anyhow and its really simple to do. I > can set it up. > > -- > To view, visit http://gerrit.cloudera.org:8080/2864 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 > Gerrit-PatchSet: 1 > Gerrit-Project: Impala > Gerrit-Branch: cdh5-trunk > Gerrit-Owner: Casey Ching > Gerrit-Reviewer: Casey Ching > Gerrit-Reviewer: Matthew Jacobs > Gerrit-Reviewer: Tim Armstrong > Gerrit-HasComments: No >
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: > didn't he say it occurred while executing some BE tests. He may > have had something wrong with his setup, but having a private build > succeed on a supported and non-supported OS seems like it would be > the minimum coverage we should have. The customer cluster test is a > good idea too. Or can we just write a BE test that calls into it? Ah you are right, the be tests failed. What do you guys think about just setting up a nightly rhel 5 job? It would be nice to have coverage there anyhow and its really simple to do. I can set it up. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: didn't he say it occurred while executing some BE tests. He may have had something wrong with his setup, but having a private build succeed on a supported and non-supported OS seems like it would be the minimum coverage we should have. The customer cluster test is a good idea too. Or can we just write a BE test that calls into it? -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: > But yeah, we probably want some kind of automated test for the > stubbed kudu configuration. Ya the stub could be built always. Then we could add some custom cluster test to use it. I'm still not sure how to repro though. Huaisi do you remember how you ran into the problem? -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: But yeah, we probably want some kind of automated test for the stubbed kudu configuration. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: It might be possible if you set KUDU_IS_SUPPORTED=false and re-bootstrap the toolchain - I think that's the situation where huaisi was running into issues. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: > What testing did you do? I only checked the file size of the .so to see that the size was reduced. Also started the impala and ran a dummy query. I'm not sure how to repro this. I think we need a new jenkins job. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: It would be good to manually confirm that this works with and without kudu enabled. It seems like the backend tests were a problem point so I'd feel better if we could confirm that the backend tests work ok when Kudu is disabled. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: What testing did you do? -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: Code-Review+1 Cool. Makes sense, though I'm not familiar with c++filt so hopefully someone else can give a +2 -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2864 Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Kudu: Exclude non-Kudu symbols during stub client generation Previously boost related symbols (and others) would get defined in the Kudu client stub with a non-functional implementation. If these implementations were used at runtime they would crash Impala. Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 --- M bin/bootstrap_toolchain.py 1 file changed, 19 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/2864/1 -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching
