[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. IMPALA-4549: consistently enforce that boost gregorian year <= Adds a Boost patch that makes the documentation and code consistent on whether the max supported year is or 1. The documentation and the max_date value are both , so fix cases where it is 1. I also filed a bug against boost https://svn.boost.org/trac/boost/ticket/12630 Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 --- M buildall.sh A source/boost/boost-1.57.0-patches/0001-greg-year-range.patch 2 files changed, 34 insertions(+), 4 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 5 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 5 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 5: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 5 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 4: Code-Review+2 Missed updating version in a couple of spots -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 4 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5264 to look at the new patch set (#4). Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. IMPALA-4549: consistently enforce that boost gregorian year <= Adds a Boost patch that makes the documentation and code consistent on whether the max supported year is or 1. The documentation and the max_date value are both , so fix cases where it is 1. I also filed a bug against boost https://svn.boost.org/trac/boost/ticket/12630 Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 --- M buildall.sh A source/boost/boost-1.57.0-patches/0001-greg-year-range.patch 2 files changed, 34 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/64/5264/4 -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 4 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 3: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 3 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 2: I'm holding off on merging this until some of the churn with Kudu versions settles down. -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5264 to look at the new patch set (#2). Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. IMPALA-4549: consistently enforce that boost gregorian year <= Adds a Boost patch that makes the documentation and code consistent on whether the max supported year is or 1. The documentation and the max_date value are both , so fix cases where it is 1. I also filed a bug against boost https://svn.boost.org/trac/boost/ticket/12630 Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 --- M buildall.sh A source/boost/boost-1.57.0-patches/0001-greg-year-range.patch 2 files changed, 31 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/64/5264/2 -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5264/1//COMMIT_MSG Commit Message: Line 9: The documentation and code are inconsistent about whether the max is > Maybe indicate in this message that this commit adds a custom boost patch? Done -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5264/1//COMMIT_MSG Commit Message: Line 9: The documentation and code are inconsistent about whether the max is Maybe indicate in this message that this commit adds a custom boost patch? -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5264 Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. IMPALA-4549: consistently enforce that boost gregorian year <= The documentation and code are inconsistent about whether the max is or 1. The documentation and the max_date value are both , so fix cases where it is 1. I also filed a bug against boost https://svn.boost.org/trac/boost/ticket/12630 Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 --- M buildall.sh A source/boost/boost-1.57.0-patches/0001-greg-year-range.patch 2 files changed, 31 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/64/5264/1 -- To view, visit http://gerrit.cloudera.org:8080/5264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65e4912b407ae43e281e8fb8153c89cd12e2e237 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
