Re: [DISCUSS] Branching for a release soon?
That might be the place for release candidates. I added KEYS to https://dist.apache.org/repos/dist/release/incubator/impala/KEYS now, following http://incubator.apache.org/guides/releasemanagement.html On Wed, Aug 31, 2016 at 4:37 PM, Jim Apple wrote: > Thanks, Tom! > > I have added my key to > https://dist.apache.org/repos/dist/dev/incubator/impala/KEYS. > > Committers who are interested in acting as release managers at some > point might be interested in getting keys, joining the apache web of > trust, putting the keys on home.apache.org, etc. The instructions for > all of this can be found by poking around the apache web space. Here > is a reasonable place to start: > http://www.apache.org/dev/release-signing.html > > On Wed, Aug 31, 2016 at 3:39 AM, Tom White wrote: >> On Wed, Aug 31, 2016 at 12:07 AM, Jim Apple wrote: >>> Testing is passing. I am waiting on the following commits to land in >>> master, though, before I cherry-pick them to branch-2.7.0: >>> >>> https://gerrit.cloudera.org/#/c/3995/ >>> https://gerrit.cloudera.org/#/c/3937/ >>> https://gerrit.cloudera.org/#/c/3936/ >>> https://gerrit.cloudera.org/#/c/4160/ >>> >>> These are all intellectual property / branding changes, but they are >>> all things that I think the IPMC may require of a release: >>> >>> 1. A copyright audit >>> >>> 2. Java package changes away from cloudera >> >> Strictly speaking this is not necessary for the first incubator >> release, but it's good to do early if possible. >> >>> >>> 3. Incubating DISCLAIMER file >>> >>> Once these are committed and in 2.7.0, I will re-test and make a >>> release candidate tarball. I think the next steps are to >>> cryptographically sign it, put it in my home.apache.org web space, >> >> Release candidates should go in a directory under >> https://dist.apache.org/repos/dist/dev/incubator/, then once they have >> been approved they can be moved to the final location with a single >> commit. >> >> See http://www.apache.org/dev/release.html#stage. >> >> Tom >> >>> then ask PMC members to download it, build it, test it, and vote on >>> it. >>> >>> >>> On Mon, Aug 29, 2016 at 10:02 AM, Jim Apple wrote: #1 is now done. I am now doing #2, making the branch and starting testing. Expect possible churn on this since this is our first attempt at cutting an upstream release. On Fri, Aug 19, 2016 at 8:40 AM, Jim Apple wrote: > I would like to volunteer to be the next release manager for an > upcoming Apache Impala 2.7 (incubating) release. I plan to: > > 1. Get a vote done adding to our bylaws the procedure for creating a > branch. (See thread from yesterday) > > 2. Create a release branch, possibly backdated a few commits from HEAD > to a commit that looks stable. > > 3. Maintain that branch by cherry-picking bugfix commits from "master" > as necessary to get the tests running cleanly. > > 4. Make a release candidate and call for a vote here, then on the IPMC > list (which is required for Incubator releases) > > Obviously, this glosses over some details about publishing and signing > releases, but I would welcome feedback on this outline.
Re: [DISCUSS] Branching for a release soon?
Thanks, Tom! I have added my key to https://dist.apache.org/repos/dist/dev/incubator/impala/KEYS. Committers who are interested in acting as release managers at some point might be interested in getting keys, joining the apache web of trust, putting the keys on home.apache.org, etc. The instructions for all of this can be found by poking around the apache web space. Here is a reasonable place to start: http://www.apache.org/dev/release-signing.html On Wed, Aug 31, 2016 at 3:39 AM, Tom White wrote: > On Wed, Aug 31, 2016 at 12:07 AM, Jim Apple wrote: >> Testing is passing. I am waiting on the following commits to land in >> master, though, before I cherry-pick them to branch-2.7.0: >> >> https://gerrit.cloudera.org/#/c/3995/ >> https://gerrit.cloudera.org/#/c/3937/ >> https://gerrit.cloudera.org/#/c/3936/ >> https://gerrit.cloudera.org/#/c/4160/ >> >> These are all intellectual property / branding changes, but they are >> all things that I think the IPMC may require of a release: >> >> 1. A copyright audit >> >> 2. Java package changes away from cloudera > > Strictly speaking this is not necessary for the first incubator > release, but it's good to do early if possible. > >> >> 3. Incubating DISCLAIMER file >> >> Once these are committed and in 2.7.0, I will re-test and make a >> release candidate tarball. I think the next steps are to >> cryptographically sign it, put it in my home.apache.org web space, > > Release candidates should go in a directory under > https://dist.apache.org/repos/dist/dev/incubator/, then once they have > been approved they can be moved to the final location with a single > commit. > > See http://www.apache.org/dev/release.html#stage. > > Tom > >> then ask PMC members to download it, build it, test it, and vote on >> it. >> >> >> On Mon, Aug 29, 2016 at 10:02 AM, Jim Apple wrote: >>> #1 is now done. >>> >>> I am now doing #2, making the branch and starting testing. Expect >>> possible churn on this since this is our first attempt at cutting an >>> upstream release. >>> >>> On Fri, Aug 19, 2016 at 8:40 AM, Jim Apple wrote: I would like to volunteer to be the next release manager for an upcoming Apache Impala 2.7 (incubating) release. I plan to: 1. Get a vote done adding to our bylaws the procedure for creating a branch. (See thread from yesterday) 2. Create a release branch, possibly backdated a few commits from HEAD to a commit that looks stable. 3. Maintain that branch by cherry-picking bugfix commits from "master" as necessary to get the tests running cleanly. 4. Make a release candidate and call for a vote here, then on the IPMC list (which is required for Incubator releases) Obviously, this glosses over some details about publishing and signing releases, but I would welcome feedback on this outline.
Re: [DISCUSS] Branching for a release soon?
On Wed, Aug 31, 2016 at 12:07 AM, Jim Apple wrote: > Testing is passing. I am waiting on the following commits to land in > master, though, before I cherry-pick them to branch-2.7.0: > > https://gerrit.cloudera.org/#/c/3995/ > https://gerrit.cloudera.org/#/c/3937/ > https://gerrit.cloudera.org/#/c/3936/ > https://gerrit.cloudera.org/#/c/4160/ > > These are all intellectual property / branding changes, but they are > all things that I think the IPMC may require of a release: > > 1. A copyright audit > > 2. Java package changes away from cloudera Strictly speaking this is not necessary for the first incubator release, but it's good to do early if possible. > > 3. Incubating DISCLAIMER file > > Once these are committed and in 2.7.0, I will re-test and make a > release candidate tarball. I think the next steps are to > cryptographically sign it, put it in my home.apache.org web space, Release candidates should go in a directory under https://dist.apache.org/repos/dist/dev/incubator/, then once they have been approved they can be moved to the final location with a single commit. See http://www.apache.org/dev/release.html#stage. Tom > then ask PMC members to download it, build it, test it, and vote on > it. > > > On Mon, Aug 29, 2016 at 10:02 AM, Jim Apple wrote: >> #1 is now done. >> >> I am now doing #2, making the branch and starting testing. Expect >> possible churn on this since this is our first attempt at cutting an >> upstream release. >> >> On Fri, Aug 19, 2016 at 8:40 AM, Jim Apple wrote: >>> I would like to volunteer to be the next release manager for an >>> upcoming Apache Impala 2.7 (incubating) release. I plan to: >>> >>> 1. Get a vote done adding to our bylaws the procedure for creating a >>> branch. (See thread from yesterday) >>> >>> 2. Create a release branch, possibly backdated a few commits from HEAD >>> to a commit that looks stable. >>> >>> 3. Maintain that branch by cherry-picking bugfix commits from "master" >>> as necessary to get the tests running cleanly. >>> >>> 4. Make a release candidate and call for a vote here, then on the IPMC >>> list (which is required for Incubator releases) >>> >>> Obviously, this glosses over some details about publishing and signing >>> releases, but I would welcome feedback on this outline.
Re: [DISCUSS] Branching for a release soon?
Testing is passing. I am waiting on the following commits to land in master, though, before I cherry-pick them to branch-2.7.0: https://gerrit.cloudera.org/#/c/3995/ https://gerrit.cloudera.org/#/c/3937/ https://gerrit.cloudera.org/#/c/3936/ https://gerrit.cloudera.org/#/c/4160/ These are all intellectual property / branding changes, but they are all things that I think the IPMC may require of a release: 1. A copyright audit 2. Java package changes away from cloudera 3. Incubating DISCLAIMER file Once these are committed and in 2.7.0, I will re-test and make a release candidate tarball. I think the next steps are to cryptographically sign it, put it in my home.apache.org web space, then ask PMC members to download it, build it, test it, and vote on it. On Mon, Aug 29, 2016 at 10:02 AM, Jim Apple wrote: > #1 is now done. > > I am now doing #2, making the branch and starting testing. Expect > possible churn on this since this is our first attempt at cutting an > upstream release. > > On Fri, Aug 19, 2016 at 8:40 AM, Jim Apple wrote: >> I would like to volunteer to be the next release manager for an >> upcoming Apache Impala 2.7 (incubating) release. I plan to: >> >> 1. Get a vote done adding to our bylaws the procedure for creating a >> branch. (See thread from yesterday) >> >> 2. Create a release branch, possibly backdated a few commits from HEAD >> to a commit that looks stable. >> >> 3. Maintain that branch by cherry-picking bugfix commits from "master" >> as necessary to get the tests running cleanly. >> >> 4. Make a release candidate and call for a vote here, then on the IPMC >> list (which is required for Incubator releases) >> >> Obviously, this glosses over some details about publishing and signing >> releases, but I would welcome feedback on this outline.
Re: [DISCUSS] Branching for a release soon?
#1 is now done. I am now doing #2, making the branch and starting testing. Expect possible churn on this since this is our first attempt at cutting an upstream release. On Fri, Aug 19, 2016 at 8:40 AM, Jim Apple wrote: > I would like to volunteer to be the next release manager for an > upcoming Apache Impala 2.7 (incubating) release. I plan to: > > 1. Get a vote done adding to our bylaws the procedure for creating a > branch. (See thread from yesterday) > > 2. Create a release branch, possibly backdated a few commits from HEAD > to a commit that looks stable. > > 3. Maintain that branch by cherry-picking bugfix commits from "master" > as necessary to get the tests running cleanly. > > 4. Make a release candidate and call for a vote here, then on the IPMC > list (which is required for Incubator releases) > > Obviously, this glosses over some details about publishing and signing > releases, but I would welcome feedback on this outline.
Re: [DISCUSS] Branching for a release soon?
Todd, I see this as being useful for future releases, even if it doesn't get used for this one. Thanks for volunteering to look into that. On Fri, Aug 19, 2016 at 11:12 AM, Todd Lipcon wrote: > I believe the newer versions of gerrit support a label-like concept called > 'hashtags' (apparently the authors of Gerrit love Instagram). They allow > you to tag a review/commit with arbitrary strings. Perhaps this feature > could be used so that patch authors can tag their reviews/commits as > "stable-candidate" and Jim can easily query for them? Then when it has been > cherry-picked to the branch, a "stable-picked" tag can be added to indicate > it has been merged? > > If this sounds useful, let me know and I can look into enabling the feature > on gerrit.cloudera.org. I think some non-trivial config change has to be > made, though, so would take a week or two. > > -Todd > > On Fri, Aug 19, 2016 at 9:38 AM, Tim Armstrong > wrote: > >> I think the first sounds easiest. If commit authors really think something >> should go in the release they can always reach out to you. >> >> On Fri, Aug 19, 2016 at 9:15 AM, Jim Apple wrote: >> >> > I hadn't decided yet. What do you think? >> > >> > I could test the release, then look for bug fixes that landed in >> > master after my branch started that fix anything that doesn't pass. >> > >> > Or I could reach out to commit authors and ask them, or I could ask >> > them to email me, like you mentioned. >> > >> > Or I could read commit messages and cherry-pick anything that is a bug >> fix. >> > >> > On Fri, Aug 19, 2016 at 9:01 AM, Tim Armstrong >> > wrote: >> > > How do you plan to choose which commits to cherry-pick? Should we let >> you >> > > know if we think a patch should/shouldn't be part of the release? >> > > >> > > On Fri, Aug 19, 2016 at 8:44 AM, Tom White wrote: >> > > >> > >> Thanks for volunteering to do the release Jim! The plan looks fine to >> > me. >> > >> >> > >> Tom >> > >> >> > >> On Fri, Aug 19, 2016 at 4:42 PM, Todd Lipcon >> wrote: >> > >> > Sounds great to me! >> > >> > >> > >> > Todd >> > >> > >> > >> > On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: >> > >> > >> > >> >> I would like to volunteer to be the next release manager for an >> > >> >> upcoming Apache Impala 2.7 (incubating) release. I plan to: >> > >> >> >> > >> >> 1. Get a vote done adding to our bylaws the procedure for creating >> a >> > >> >> branch. (See thread from yesterday) >> > >> >> >> > >> >> 2. Create a release branch, possibly backdated a few commits from >> > HEAD >> > >> >> to a commit that looks stable. >> > >> >> >> > >> >> 3. Maintain that branch by cherry-picking bugfix commits from >> > "master" >> > >> >> as necessary to get the tests running cleanly. >> > >> >> >> > >> >> 4. Make a release candidate and call for a vote here, then on the >> > IPMC >> > >> >> list (which is required for Incubator releases) >> > >> >> >> > >> >> Obviously, this glosses over some details about publishing and >> > signing >> > >> >> releases, but I would welcome feedback on this outline. >> > >> >> >> > >> >> > >> > > > > -- > Todd Lipcon > Software Engineer, Cloudera
Re: [DISCUSS] Branching for a release soon?
I believe the newer versions of gerrit support a label-like concept called 'hashtags' (apparently the authors of Gerrit love Instagram). They allow you to tag a review/commit with arbitrary strings. Perhaps this feature could be used so that patch authors can tag their reviews/commits as "stable-candidate" and Jim can easily query for them? Then when it has been cherry-picked to the branch, a "stable-picked" tag can be added to indicate it has been merged? If this sounds useful, let me know and I can look into enabling the feature on gerrit.cloudera.org. I think some non-trivial config change has to be made, though, so would take a week or two. -Todd On Fri, Aug 19, 2016 at 9:38 AM, Tim Armstrong wrote: > I think the first sounds easiest. If commit authors really think something > should go in the release they can always reach out to you. > > On Fri, Aug 19, 2016 at 9:15 AM, Jim Apple wrote: > > > I hadn't decided yet. What do you think? > > > > I could test the release, then look for bug fixes that landed in > > master after my branch started that fix anything that doesn't pass. > > > > Or I could reach out to commit authors and ask them, or I could ask > > them to email me, like you mentioned. > > > > Or I could read commit messages and cherry-pick anything that is a bug > fix. > > > > On Fri, Aug 19, 2016 at 9:01 AM, Tim Armstrong > > wrote: > > > How do you plan to choose which commits to cherry-pick? Should we let > you > > > know if we think a patch should/shouldn't be part of the release? > > > > > > On Fri, Aug 19, 2016 at 8:44 AM, Tom White wrote: > > > > > >> Thanks for volunteering to do the release Jim! The plan looks fine to > > me. > > >> > > >> Tom > > >> > > >> On Fri, Aug 19, 2016 at 4:42 PM, Todd Lipcon > wrote: > > >> > Sounds great to me! > > >> > > > >> > Todd > > >> > > > >> > On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: > > >> > > > >> >> I would like to volunteer to be the next release manager for an > > >> >> upcoming Apache Impala 2.7 (incubating) release. I plan to: > > >> >> > > >> >> 1. Get a vote done adding to our bylaws the procedure for creating > a > > >> >> branch. (See thread from yesterday) > > >> >> > > >> >> 2. Create a release branch, possibly backdated a few commits from > > HEAD > > >> >> to a commit that looks stable. > > >> >> > > >> >> 3. Maintain that branch by cherry-picking bugfix commits from > > "master" > > >> >> as necessary to get the tests running cleanly. > > >> >> > > >> >> 4. Make a release candidate and call for a vote here, then on the > > IPMC > > >> >> list (which is required for Incubator releases) > > >> >> > > >> >> Obviously, this glosses over some details about publishing and > > signing > > >> >> releases, but I would welcome feedback on this outline. > > >> >> > > >> > > > -- Todd Lipcon Software Engineer, Cloudera
Re: [DISCUSS] Branching for a release soon?
I think the first sounds easiest. If commit authors really think something should go in the release they can always reach out to you. On Fri, Aug 19, 2016 at 9:15 AM, Jim Apple wrote: > I hadn't decided yet. What do you think? > > I could test the release, then look for bug fixes that landed in > master after my branch started that fix anything that doesn't pass. > > Or I could reach out to commit authors and ask them, or I could ask > them to email me, like you mentioned. > > Or I could read commit messages and cherry-pick anything that is a bug fix. > > On Fri, Aug 19, 2016 at 9:01 AM, Tim Armstrong > wrote: > > How do you plan to choose which commits to cherry-pick? Should we let you > > know if we think a patch should/shouldn't be part of the release? > > > > On Fri, Aug 19, 2016 at 8:44 AM, Tom White wrote: > > > >> Thanks for volunteering to do the release Jim! The plan looks fine to > me. > >> > >> Tom > >> > >> On Fri, Aug 19, 2016 at 4:42 PM, Todd Lipcon wrote: > >> > Sounds great to me! > >> > > >> > Todd > >> > > >> > On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: > >> > > >> >> I would like to volunteer to be the next release manager for an > >> >> upcoming Apache Impala 2.7 (incubating) release. I plan to: > >> >> > >> >> 1. Get a vote done adding to our bylaws the procedure for creating a > >> >> branch. (See thread from yesterday) > >> >> > >> >> 2. Create a release branch, possibly backdated a few commits from > HEAD > >> >> to a commit that looks stable. > >> >> > >> >> 3. Maintain that branch by cherry-picking bugfix commits from > "master" > >> >> as necessary to get the tests running cleanly. > >> >> > >> >> 4. Make a release candidate and call for a vote here, then on the > IPMC > >> >> list (which is required for Incubator releases) > >> >> > >> >> Obviously, this glosses over some details about publishing and > signing > >> >> releases, but I would welcome feedback on this outline. > >> >> > >> >
Re: [DISCUSS] Branching for a release soon?
I hadn't decided yet. What do you think? I could test the release, then look for bug fixes that landed in master after my branch started that fix anything that doesn't pass. Or I could reach out to commit authors and ask them, or I could ask them to email me, like you mentioned. Or I could read commit messages and cherry-pick anything that is a bug fix. On Fri, Aug 19, 2016 at 9:01 AM, Tim Armstrong wrote: > How do you plan to choose which commits to cherry-pick? Should we let you > know if we think a patch should/shouldn't be part of the release? > > On Fri, Aug 19, 2016 at 8:44 AM, Tom White wrote: > >> Thanks for volunteering to do the release Jim! The plan looks fine to me. >> >> Tom >> >> On Fri, Aug 19, 2016 at 4:42 PM, Todd Lipcon wrote: >> > Sounds great to me! >> > >> > Todd >> > >> > On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: >> > >> >> I would like to volunteer to be the next release manager for an >> >> upcoming Apache Impala 2.7 (incubating) release. I plan to: >> >> >> >> 1. Get a vote done adding to our bylaws the procedure for creating a >> >> branch. (See thread from yesterday) >> >> >> >> 2. Create a release branch, possibly backdated a few commits from HEAD >> >> to a commit that looks stable. >> >> >> >> 3. Maintain that branch by cherry-picking bugfix commits from "master" >> >> as necessary to get the tests running cleanly. >> >> >> >> 4. Make a release candidate and call for a vote here, then on the IPMC >> >> list (which is required for Incubator releases) >> >> >> >> Obviously, this glosses over some details about publishing and signing >> >> releases, but I would welcome feedback on this outline. >> >> >>
Re: [DISCUSS] Branching for a release soon?
How do you plan to choose which commits to cherry-pick? Should we let you know if we think a patch should/shouldn't be part of the release? On Fri, Aug 19, 2016 at 8:44 AM, Tom White wrote: > Thanks for volunteering to do the release Jim! The plan looks fine to me. > > Tom > > On Fri, Aug 19, 2016 at 4:42 PM, Todd Lipcon wrote: > > Sounds great to me! > > > > Todd > > > > On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: > > > >> I would like to volunteer to be the next release manager for an > >> upcoming Apache Impala 2.7 (incubating) release. I plan to: > >> > >> 1. Get a vote done adding to our bylaws the procedure for creating a > >> branch. (See thread from yesterday) > >> > >> 2. Create a release branch, possibly backdated a few commits from HEAD > >> to a commit that looks stable. > >> > >> 3. Maintain that branch by cherry-picking bugfix commits from "master" > >> as necessary to get the tests running cleanly. > >> > >> 4. Make a release candidate and call for a vote here, then on the IPMC > >> list (which is required for Incubator releases) > >> > >> Obviously, this glosses over some details about publishing and signing > >> releases, but I would welcome feedback on this outline. > >> >
Re: [DISCUSS] Branching for a release soon?
Thanks for volunteering to do the release Jim! The plan looks fine to me. Tom On Fri, Aug 19, 2016 at 4:42 PM, Todd Lipcon wrote: > Sounds great to me! > > Todd > > On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: > >> I would like to volunteer to be the next release manager for an >> upcoming Apache Impala 2.7 (incubating) release. I plan to: >> >> 1. Get a vote done adding to our bylaws the procedure for creating a >> branch. (See thread from yesterday) >> >> 2. Create a release branch, possibly backdated a few commits from HEAD >> to a commit that looks stable. >> >> 3. Maintain that branch by cherry-picking bugfix commits from "master" >> as necessary to get the tests running cleanly. >> >> 4. Make a release candidate and call for a vote here, then on the IPMC >> list (which is required for Incubator releases) >> >> Obviously, this glosses over some details about publishing and signing >> releases, but I would welcome feedback on this outline. >>
Re: [DISCUSS] Branching for a release soon?
Sounds great to me! Todd On Aug 19, 2016 8:41 AM, "Jim Apple" wrote: > I would like to volunteer to be the next release manager for an > upcoming Apache Impala 2.7 (incubating) release. I plan to: > > 1. Get a vote done adding to our bylaws the procedure for creating a > branch. (See thread from yesterday) > > 2. Create a release branch, possibly backdated a few commits from HEAD > to a commit that looks stable. > > 3. Maintain that branch by cherry-picking bugfix commits from "master" > as necessary to get the tests running cleanly. > > 4. Make a release candidate and call for a vote here, then on the IPMC > list (which is required for Incubator releases) > > Obviously, this glosses over some details about publishing and signing > releases, but I would welcome feedback on this outline. >
