Re: A modest proposal: use the gold linker by default

I'm in favour of the switch, assuming that the details can be worked out. Reducing the variability in the tools used to build Impala is worthwhile in and of itself. On 13 October 2016 at 08:52, Tim Armstrong wrote: > Oh interesting. It doesn't look like our toolchain

Re: A modest proposal: use the gold linker by default

You're right that ASAN+gold in our build system is wonky. It works but clang actually calls out to ld rather than gold. I think this is purely because we pass -Wl,-fuse-ld=gold instead of -fuse-ld=gold. I confirmed that clang can call out to gold correctly if you give it the right option:

Re: A modest proposal: use the gold linker by default

Oh interesting. It doesn't look like our toolchain version of binutils (2.26) has the fix, but 2.27 does have it. On Thu, Oct 13, 2016 at 8:48 AM, Todd Lipcon wrote: > There's one issue with older versions of gold that for shared objects it > doesn't handle weak symbols

Re: A modest proposal: use the gold linker by default

There's one issue with older versions of gold that for shared objects it doesn't handle weak symbols correctly: https://sourceware.org/bugzilla/show_bug.cgi?id=16979 This isn't a problem for static linking, but for dynamic linking causes problems like not seeing tcmalloc's version of malloc. Not

Re: A modest proposal: use the gold linker by default

I think clang doesn't have a CLI option to use gold. Does buildall.sh -asan interact well with gold? On Thu, Oct 13, 2016 at 8:25 AM, Tim Armstrong wrote: > The gold linker is much faster for building static binaries so will be much > friendlier for new developers. > >