Re: [jira] [Commented] (IOTDB-467) The CLI displays query results in a batch manner

2020-02-14 Thread Jialin Qiao
Hi,

Dawei closed his PR, which is very kindly. 
I have reviewed the new PR and it looks great :)

Thanks,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -原始邮件-
> 发件人: "Xiangdong Huang" 
> 发送时间: 2020-02-15 11:15:44 (星期六)
> 收件人: dev@iotdb.apache.org
> 抄送: 
> 主题: Re: [jira] [Commented] (IOTDB-467) The CLI displays query results in a 
> batch manner
> 
> Hi,
> 
> I notice a new contributor submit a PR to solve the same issue.
> It is good news that there are new contributors. And we need to encourage
> their works.
> Could you review it and finally we can merge one PR of you two.
> 
> Best,
> ---
> Xiangdong Huang
> School of Software, Tsinghua University
> 
>  黄向东
> 清华大学 软件学院
> 
> 
> atoildw (Jira)  于2020年2月14日周五 下午9:12写道:
> 
> >
> > [
> > https://issues.apache.org/jira/browse/IOTDB-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036967#comment-17036967
> > ]
> >
> > atoildw commented on IOTDB-467:
> > ---
> >
> > i'm working on this issue
> >
> > > The CLI displays query results in a batch manner
> > > 
> > >
> > > Key: IOTDB-467
> > > URL: https://issues.apache.org/jira/browse/IOTDB-467
> > > Project: Apache IoTDB
> > >  Issue Type: Improvement
> > >  Components: Client/Java
> > >Reporter: Jialin Qiao
> > >Assignee: atoildw
> > >Priority: Major
> > >  Labels: pull-request-available
> > >  Time Spent: 10m
> > >  Remaining Estimate: 0h
> > >
> > > The print function of CLI could be improved:
> > > If the query result set has too many lines. Each time CLI prints 1000
> > lines and waits for the command of the user. If the user enters an "ENTER",
> > the CLI prints another 1000 line. If the user enters a "q", the CLI stop to
> > print the Result and wait for the next command.
> >
> >
> >
> > --
> > This message was sent by Atlassian Jira
> > (v8.3.4#803005)
> >


Re: [jira] [Commented] (IOTDB-467) The CLI displays query results in a batch manner

2020-02-14 Thread Xiangdong Huang
Hi,

I notice a new contributor submit a PR to solve the same issue.
It is good news that there are new contributors. And we need to encourage
their works.
Could you review it and finally we can merge one PR of you two.

Best,
---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


atoildw (Jira)  于2020年2月14日周五 下午9:12写道:

>
> [
> https://issues.apache.org/jira/browse/IOTDB-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036967#comment-17036967
> ]
>
> atoildw commented on IOTDB-467:
> ---
>
> i'm working on this issue
>
> > The CLI displays query results in a batch manner
> > 
> >
> > Key: IOTDB-467
> > URL: https://issues.apache.org/jira/browse/IOTDB-467
> > Project: Apache IoTDB
> >  Issue Type: Improvement
> >  Components: Client/Java
> >Reporter: Jialin Qiao
> >Assignee: atoildw
> >Priority: Major
> >  Labels: pull-request-available
> >  Time Spent: 10m
> >  Remaining Estimate: 0h
> >
> > The print function of CLI could be improved:
> > If the query result set has too many lines. Each time CLI prints 1000
> lines and waits for the command of the user. If the user enters an "ENTER",
> the CLI prints another 1000 line. If the user enters a "q", the CLI stop to
> print the Result and wait for the next command.
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>