[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166682#comment-16166682
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 1b60ce18f28e7369364e5712c546f6da32099c6a in isis's branch 
refs/heads/master from [~hobrom]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1b60ce1 ]

Fix ISIS-1715 menuOrder Dewey Decimal format not honored

> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166681#comment-16166681
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 312ac31b770308a4dd14b115f30fcfc1cf2d45b4 in isis's branch 
refs/heads/master from [~hobrom]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=312ac31 ]

Fix ISIS-1715 menuOrder not honored

> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166687#comment-16166687
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 4de5824f98c8092c32a4a84ce3b0f691b65dc5b4 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4de5824 ]

ISIS-1715: adds unit test, removes commented out code.


> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166685#comment-16166685
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 40107995b25b05d1bc9d72a65cf5512290a7165d in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4010799 ]

Merge branch 'ISIS-1715_pr-84'


> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166570#comment-16166570
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 40107995b25b05d1bc9d72a65cf5512290a7165d in isis's branch 
refs/heads/pr-84 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4010799 ]

Merge branch 'ISIS-1715_pr-84'


> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166566#comment-16166566
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 312ac31b770308a4dd14b115f30fcfc1cf2d45b4 in isis's branch 
refs/heads/pr-84 from [~hobrom]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=312ac31 ]

Fix ISIS-1715 menuOrder not honored

> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166572#comment-16166572
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 4de5824f98c8092c32a4a84ce3b0f691b65dc5b4 in isis's branch 
refs/heads/pr-84 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4de5824 ]

ISIS-1715: adds unit test, removes commented out code.


> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166567#comment-16166567
 ] 

ASF subversion and git services commented on ISIS-1715:
---

Commit 1b60ce18f28e7369364e5712c546f6da32099c6a in isis's branch 
refs/heads/pr-84 from [~hobrom]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1b60ce1 ]

Fix ISIS-1715 menuOrder Dewey Decimal format not honored

> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
> Fix For: 1.15.1
>
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-12 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163165#comment-16163165
 ] 

Andi Huber commented on ISIS-1715:
--

It seems that @DomainServiceLayout#menuOrder and @DomainService#menuOrder do 
not honor *Dewey Decimal format*.

Possible fix provided: PR #84
https://github.com/apache/isis/pull/84

> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1715) Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

2017-09-12 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163036#comment-16163036
 ] 

Andi Huber commented on ISIS-1715:
--

Possible fix provided: PR #84 
https://github.com/apache/isis/pull/84

> Service priority as defined by @DomainServiceLayout#menuOrder or 
> @DomainService#menuOrder not honored.
> --
>
> Key: ISIS-1715
> URL: https://issues.apache.org/jira/browse/ISIS-1715
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>
> It seems menu contributing service's will not always produce submenus ordered 
> correctly:
> I found a case, where menuOrder was not honored while 2 menu-services were 
> both contributing to the same menu. The member sequence for each group was 
> correct, but the order of the groups was wrong.
> {code:java}
> @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.2")
> public class A {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getAProperty() {
> 
> }
> }
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainServiceLayout(named="TODO", menuOrder="30.1")
> public class B {
> @Action
> @MemberOrder(sequence = "1.1")
> public void getBProperty() {
> 
> }
> }
> {code}
> Menu group B should be positioned above group A, but it sometimes is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)