[jira] [Commented] (ISIS-1736) ConfigurationServiceDefault is inconsistent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384637#comment-16384637
 ] 

ASF subversion and git services commented on ISIS-1736:
---

Commit 624300e402512a8074aa357e84153e2f083b3ffc in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=624300e ]

ISIS-1736 make all property access unmodifiable

> ConfigurationServiceDefault is inconsistent
> ---
>
> Key: ISIS-1736
> URL: https://issues.apache.org/jira/browse/ISIS-1736
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Steve Cameron
>Assignee: Andi Huber
>Priority: Critical
> Fix For: 2.0.0-M1
>
>
> This class is confusing, it has its own properties Map which it uses for some 
> methods and then defers to an injected  ConfigurationServiceInternal 
> reference for others.
> I am using it in a fixture and it will not find a property using 
> getProperty(String) which is using ConfigurationServiceInternal reference but 
> will find it if I use getProperties() and loop through the entries returned 
> //doesn't find key
> String xml = 
> configurationService.getProperty("au.com.vuse.oneid.fixtures.companyinputfile");
> //does find key
> for (ConfigurationProperty str : configurationService.allProperties()) {
>   if (str.getKey().equals("au.com.vuse.oneid.fixtures.companyinputfile"))
>   xml = str.getValue();
>   }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1736) ConfigurationServiceDefault is inconsistent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384627#comment-16384627
 ] 

ASF subversion and git services commented on ISIS-1736:
---

Commit be0d47bebc80aac4bb6e0a127d6503887eea9040 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=be0d47b ]

ISIS-1736 consolidating properties

> ConfigurationServiceDefault is inconsistent
> ---
>
> Key: ISIS-1736
> URL: https://issues.apache.org/jira/browse/ISIS-1736
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Steve Cameron
>Priority: Critical
> Fix For: 2.0.0-M1
>
>
> This class is confusing, it has its own properties Map which it uses for some 
> methods and then defers to an injected  ConfigurationServiceInternal 
> reference for others.
> I am using it in a fixture and it will not find a property using 
> getProperty(String) which is using ConfigurationServiceInternal reference but 
> will find it if I use getProperties() and loop through the entries returned 
> //doesn't find key
> String xml = 
> configurationService.getProperty("au.com.vuse.oneid.fixtures.companyinputfile");
> //does find key
> for (ConfigurationProperty str : configurationService.allProperties()) {
>   if (str.getKey().equals("au.com.vuse.oneid.fixtures.companyinputfile"))
>   xml = str.getValue();
>   }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)