[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690969#comment-16690969 ] ASF subversion and git services commented on ISIS-1991: --- Commit cc98937e17c7ef0d0067b87cb76d17e898b12539 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=cc98937 ] ISIS-1991: polishing: no need for overriding immutable value getter Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690970#comment-16690970 ] ASF subversion and git services commented on ISIS-1991: --- Commit cc98937e17c7ef0d0067b87cb76d17e898b12539 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=cc98937 ] ISIS-1991: polishing: no need for overriding immutable value getter Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690844#comment-16690844 ] ASF subversion and git services commented on ISIS-1991: --- Commit 76fb7febe598f03cbf4945f9ba69f3757207465e in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=76fb7fe ] ISIS-1991: never show devutils in PRODUCTION Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690845#comment-16690845 ] ASF subversion and git services commented on ISIS-1991: --- Commit 76fb7febe598f03cbf4945f9ba69f3757207465e in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=76fb7fe ] ISIS-1991: never show devutils in PRODUCTION Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690836#comment-16690836 ] ASF subversion and git services commented on ISIS-1991: --- Commit 944aa70c31161f590516c1486d5217bad6797a21 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=944aa70 ] ISIS-1991: cleanup: use _Context.isPrototyping() everywhere (framework internal) this is exposed by IsisContext.getEnvironment() as part of the public API Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690837#comment-16690837 ] ASF subversion and git services commented on ISIS-1991: --- Commit 944aa70c31161f590516c1486d5217bad6797a21 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=944aa70 ] ISIS-1991: cleanup: use _Context.isPrototyping() everywhere (framework internal) this is exposed by IsisContext.getEnvironment() as part of the public API Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690835#comment-16690835 ] ASF subversion and git services commented on ISIS-1991: --- Commit 71a4b84f893736d092e3194c534294fdcabf7c0b in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=71a4b84 ] ISIS-1991: polishing the deploymentType decision logic Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690834#comment-16690834 ] ASF subversion and git services commented on ISIS-1991: --- Commit 71a4b84f893736d092e3194c534294fdcabf7c0b in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=71a4b84 ] ISIS-1991: polishing the deploymentType decision logic Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690610#comment-16690610 ] ASF subversion and git services commented on ISIS-1991: --- Commit 99b4e8481ba59005982dc2e144c90cc9ea5e7e31 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=99b4e84 ] ISIS-1991: another typo Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690611#comment-16690611 ] ASF subversion and git services commented on ISIS-1991: --- Commit 99b4e8481ba59005982dc2e144c90cc9ea5e7e31 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=99b4e84 ] ISIS-1991: another typo Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690591#comment-16690591 ] ASF subversion and git services commented on ISIS-1991: --- Commit 5f75ac1138229d057b871a766c3825e859e6d3b7 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=5f75ac1 ] ISIS-1991: adding back in the legacy behavior Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690607#comment-16690607 ] ASF subversion and git services commented on ISIS-1991: --- Commit b419c1ff718c9c13fe3e0f3818aaed3ad363060e in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b419c1f ] ISIS-1991: fixing property values Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690608#comment-16690608 ] ASF subversion and git services commented on ISIS-1991: --- Commit b419c1ff718c9c13fe3e0f3818aaed3ad363060e in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b419c1f ] ISIS-1991: fixing property values Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690603#comment-16690603 ] ASF subversion and git services commented on ISIS-1991: --- Commit b00177e942a19175cbaed68c7796508278b122b2 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b00177e ] ISIS-1991: add "isis.deploymentType" as a config option Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690602#comment-16690602 ] ASF subversion and git services commented on ISIS-1991: --- Commit b00177e942a19175cbaed68c7796508278b122b2 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b00177e ] ISIS-1991: add "isis.deploymentType" as a config option Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690598#comment-16690598 ] ASF subversion and git services commented on ISIS-1991: --- Commit 04e33979c159da293091b6871e69d999c2bb6441 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=04e3397 ] ISIS-1991: fix type in string format Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690597#comment-16690597 ] ASF subversion and git services commented on ISIS-1991: --- Commit 04e33979c159da293091b6871e69d999c2bb6441 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=04e3397 ] ISIS-1991: fix type in string format Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690592#comment-16690592 ] ASF subversion and git services commented on ISIS-1991: --- Commit 5f75ac1138229d057b871a766c3825e859e6d3b7 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=5f75ac1 ] ISIS-1991: adding back in the legacy behavior Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690576#comment-16690576 ] ASF subversion and git services commented on ISIS-1991: --- Commit eb6d4fb62629345ecfb1050aab179e6b516572f3 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=eb6d4fb ] ISIS-1991: removing debug code simple-app: updating mml approved Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690575#comment-16690575 ] ASF subversion and git services commented on ISIS-1991: --- Commit eb6d4fb62629345ecfb1050aab179e6b516572f3 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=eb6d4fb ] ISIS-1991: removing debug code simple-app: updating mml approved Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690564#comment-16690564 ] ASF subversion and git services commented on ISIS-1991: --- Commit 052e46edd434b65cc3c398608354ac9dab5887b4 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=052e46e ] ISIS-1991: major: removing the DeploymentCategory also rolling up RenderContext2-6 Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690565#comment-16690565 ] ASF subversion and git services commented on ISIS-1991: --- Commit 052e46edd434b65cc3c398608354ac9dab5887b4 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=052e46e ] ISIS-1991: major: removing the DeploymentCategory also rolling up RenderContext2-6 Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664421#comment-16664421 ] ASF subversion and git services commented on ISIS-1991: --- Commit 4ea76029e097e3e8b94f5602ca430dfcd6ee9dac in isis's branch refs/heads/v2 from danhaywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=4ea7602 ] ISIS-1991: primes config in IsisWebAppBootstrapper, so that isis.deploymentType is honoured if set. > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662822#comment-16662822 ] ASF subversion and git services commented on ISIS-1991: --- Commit e3e3c48667b5c77f75c0a763c154bb027b7a47e7 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=e3e3c48 ] ISIS-1991: allows for the Isis system environment to be primed from config values that is "isis.deploymentType=SERVER" or "isis.deploymentType=SERVER_PROTOTYPE" to prime the system environment one can use IsisContext.primeEnvironment(IsisConfiguration conf) > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626340#comment-16626340 ] ASF subversion and git services commented on ISIS-1991: --- Commit 22708a0dc774de459d69f636152aef1c526e5ba0 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=22708a0 ] ISIS-1991: removing all legacy code, that does advice on deployment type instead we use an environment variable and provide a 'backdoor' for integration testing Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1991) Determining the deployment type is broken
[ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626341#comment-16626341 ] ASF subversion and git services commented on ISIS-1991: --- Commit 22708a0dc774de459d69f636152aef1c526e5ba0 in isis's branch refs/heads/v2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=22708a0 ] ISIS-1991: removing all legacy code, that does advice on deployment type instead we use an environment variable and provide a 'backdoor' for integration testing Task-Url: https://issues.apache.org/jira/browse/ISIS-1991 > Determining the deployment type is broken > - > > Key: ISIS-1991 > URL: https://issues.apache.org/jira/browse/ISIS-1991 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 2.0.0-M1 >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M2 > > > We seem to have multiple classes within 'core' that act as advisors for > determining the application's deployment-type. > Maybe we need to rethink and cleanup. I think it should be sufficient to have > one and only one place to configure the deployment type. eg. simply via a > single environment variable. > To pick up this idea [1], we could introduce one layer of abstraction. Also > note: We need to have access to this variable very early in the bootstrapping > phase. > [1] > https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
