[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679844#comment-17679844 ] ASF subversion and git services commented on ISIS-3325: --- Commit 466cabc5c7bfb0a8908c6830c37576344379e2af in isis's branch refs/heads/spring6 from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=466cabc5c7 ] ISIS-3325: move nested classes from CausewayToWicketTreeAdapter to their own files > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679846#comment-17679846 ] ASF subversion and git services commented on ISIS-3325: --- Commit cd1a4e02b896b7c87e2f5a098fbdabdd4ed86c37 in isis's branch refs/heads/spring6 from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=cd1a4e02b8 ] ISIS-3325: adds some null safety - just in case > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679845#comment-17679845 ] ASF subversion and git services commented on ISIS-3325: --- Commit 840109855fcccf32d1bf4cb7dcbcdd1e6d533f42 in isis's branch refs/heads/spring6 from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=840109855f ] ISIS-3325: simplifies _TreeModel and renames it to _TreeNodeMemento > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679836#comment-17679836 ] ASF subversion and git services commented on ISIS-3325: --- Commit cd1a4e02b896b7c87e2f5a098fbdabdd4ed86c37 in isis's branch refs/heads/master from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=cd1a4e02b8 ] ISIS-3325: adds some null safety - just in case > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679818#comment-17679818 ] ASF subversion and git services commented on ISIS-3325: --- Commit 840109855fcccf32d1bf4cb7dcbcdd1e6d533f42 in isis's branch refs/heads/master from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=840109855f ] ISIS-3325: simplifies _TreeModel and renames it to _TreeNodeMemento > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679791#comment-17679791 ] ASF subversion and git services commented on ISIS-3325: --- Commit 466cabc5c7bfb0a8908c6830c37576344379e2af in isis's branch refs/heads/master from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=466cabc5c7 ] ISIS-3325: move nested classes from CausewayToWicketTreeAdapter to their own files > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679745#comment-17679745 ] Andi Huber commented on ISIS-3325: -- I believe a robust fix would be to rewrite the CausewayToWicketTreeAdapter such that ObjectMementos are used for the tree nodes, which are safely serializable. > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677732#comment-17677732 ] Andi Huber commented on ISIS-3325: -- Attachment: If I modify our demo app's tree showcase, that is, have the FileNodeVm reference some arbitrary entity node (held by the property favoriteChild) and we then let the FileNodeVm's title be dependent on presence of its favoriteChild, we then do see issues with creating the correct title. > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[
https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677729#comment-17677729
]
Andi Huber commented on ISIS-3325:
--
{code:java}
@DomainObject(logicalTypeName = "xxx.TypeA", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeA implements ITypeA {
@Property
@PropertyLayout(navigable = Navigable.PARENT, hidden =
Where.EVERYWHERE)
@Getter @Setter
private TypeB parent;
}
@DomainObject(logicalTypeName = "xxx.TypeB", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeB implements ITypeB {
}
public interface ITypeA {
ITypeB getParent();
}
{code}
> IsisToWicketTreeAdapter nodes result in "failed title" when
> collapsed/re-expanded.
> --
>
> Key: ISIS-3325
> URL: https://issues.apache.org/jira/browse/ISIS-3325
> Project: Isis
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-RC1
>
>
> as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
