[jira] [Comment Edited] (JCR-4301) get rid of JSR 305 dependency

2019-06-05 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCR-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526293#comment-16526293
 ] 

Julian Reschke edited comment on JCR-4301 at 6/5/19 6:08 AM:
-

[^JCR-4301-jackrabbit-projects.diff] is (was?) an attempt to define custom 
Jackrabbit annotations, preserving the non-qualified class name if the JSR-305 
annotations in order to minimize diffs.

I tried the customer o.a.j.annotations.CheckForNull annotation, and spotbugs 
won't use it. See also 
https://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java.

So maybe we should stick to the previously agreed upon approach and live with 
the fact that we'll have to touch lots of code lines.


was (Author: reschke):
[^JCR-4301-jackrabbit-projects.diff] is (was?) an attempt to define custom 
Jackrabbit annotations, preserving the non-qualified class name if the JSR-305 
annotations in order to minimize diffs.

I tried the customer o.a.j.annotations.CheckForNull annotation, and spotbugs 
won't use it. See 
alsohttps://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java.

So maybe we should stick to the previously agreed upon approach and live with 
the fact that we'll have to touch lots of code lines.

> get rid of JSR 305 dependency
> -
>
> Key: JCR-4301
> URL: https://issues.apache.org/jira/browse/JCR-4301
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: jackrabbit-api
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.18, 2.17.4, 2.16.3
>
> Attachments: JCR-4301-2.diff, JCR-4301-jackrabbit-projects.diff, 
> JCR-4301.diff, JCR-4301.diff, convert-annotations.sh
>
>
> We should consider getting rid of the JSR 305 dependency (see 
> ). Note that we only used the 
> annotations in a few recently changed APIs.
> Further note that we could use spotbugs as replacement for findbugs to detect 
> problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (JCR-4301) get rid of JSR 305 dependency

2018-06-28 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCR-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507870#comment-16507870
 ] 

Julian Reschke edited comment on JCR-4301 at 6/28/18 11:15 AM:
---

We recently discussed this on the phone, and [~anchela] suggested to introduce 
our own annotations (in a new top-level Jackrabbit project) so that we can keep 
the same annotation class names (and only have to update the import statements).

EDIT: note that there's no inheritance for annotations, so we'd need to rely on 
checkers to be either configurable or lax with respect to checking package 
names.


was (Author: reschke):
We recently discussed this on the phone, and [~anchela] suggested to introduce 
out own annotations (in a new top-level Jackrabbit project) so that we can keep 
the same annotation class names (and only have to update the import statements).

> get rid of JSR 305 dependency
> -
>
> Key: JCR-4301
> URL: https://issues.apache.org/jira/browse/JCR-4301
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: jackrabbit-api
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.18, 2.17.4
>
> Attachments: JCR-4301-2.diff, JCR-4301.diff, JCR-4301.diff
>
>
> We should consider getting rid of the JSR 305 dependency (see 
> ). Note that we only used the 
> annotations in a few recently changed APIs.
> Further note that we could use spotbugs as replacement for findbugs to detect 
> problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (JCR-4301) get rid of JSR 305 dependency

2018-05-23 Thread Konrad Windszus (JIRA) 

[ 
https://issues.apache.org/jira/browse/JCR-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487427#comment-16487427
 ] 

Konrad Windszus edited comment on JCR-4301 at 5/23/18 3:15 PM:
---

At least the SonarQube support for null annotations seems very broad now. For 
further details check 
https://github.com/SonarSource/sonar-java/blob/b4b5419753a2e635bfc53b65bc70e200786c6092/java-frontend/src/main/java/org/sonar/java/se/NullableAnnotationUtils.java#L38.
For spotbugs check 
https://github.com/spotbugs/spotbugs/blob/release-3.1/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java#L35.


was (Author: kwin):
At least the SonarQube support for null annotations seems very broad now. For 
further details check 
https://github.com/SonarSource/sonar-java/blob/b4b5419753a2e635bfc53b65bc70e200786c6092/java-frontend/src/main/java/org/sonar/java/se/NullableAnnotationUtils.java#L38.

> get rid of JSR 305 dependency
> -
>
> Key: JCR-4301
> URL: https://issues.apache.org/jira/browse/JCR-4301
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: jackrabbit-api
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: JCR-4301-2.diff, JCR-4301.diff, JCR-4301.diff
>
>
> We should consider getting rid of the JSR 305 dependency (see 
> ). Note that we only used the 
> annotations in a few recently changed APIs.
> Further note that we could use spotbugs as replacement for findbugs to detect 
> problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (JCR-4301) get rid of JSR 305 dependency

2018-05-23 Thread Konrad Windszus (JIRA) 

[ 
https://issues.apache.org/jira/browse/JCR-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487370#comment-16487370
 ] 

Konrad Windszus edited comment on JCR-4301 at 5/23/18 2:39 PM:
---

For Sling we only use {{javax.annotation.CheckForNull}} and 
{{javax.annotation.Nonnull}} because no annotation has the same meaning as 
{{javax.annotation.Nullable}} and nullable is not evaluated by any tools (for 
further information look at 
http://sling.apache.org/documentation/development/jsr-305.html#annotations).


was (Author: kwin):
For Sling we only use {{javax.annotation.CheckForNull}} and 
{{javax.annotation.Nonnull}} because no annotation has the same meaning as 
{{javax.annotation.Nullable}} (for further information look at 
http://sling.apache.org/documentation/development/jsr-305.html#annotations).

> get rid of JSR 305 dependency
> -
>
> Key: JCR-4301
> URL: https://issues.apache.org/jira/browse/JCR-4301
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: jackrabbit-api
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: JCR-4301-2.diff, JCR-4301.diff
>
>
> We should consider getting rid of the JSR 305 dependency (see 
> ). Note that we only used the 
> annotations in a few recently changed APIs.
> Further note that we could use spotbugs as replacement for findbugs to detect 
> problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)