[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[ https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331913#comment-16331913 ] Julian Reschke commented on JCR-4001: - trunk: [r1821597|http://svn.apache.org/r1821597] > When using Node.getProperties(String namePattern) also child nodes are > processed > > > Key: JCR-4001 > URL: https://issues.apache.org/jira/browse/JCR-4001 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr-commons >Reporter: Luca Tagliani >Assignee: Julian Reschke >Priority: Major > Labels: candidate_jcr_2_16 > Fix For: 2.18, 2.17.1 > > Attachments: JCR-4001-2.diff, JCR-4001.patch > > > Call to Node.getProperties(String namePattern) processed also child nodes and > not only properties. > This can deteriorate performance when there are lots of children. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[ https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331857#comment-16331857 ] Luca Tagliani commented on JCR-4001: Hi [~reschke]. The patch seems good to me. In fact is exactly how we workaround the problem without touching JR code. For me +1 to add to next release cycle. BR Luca > When using Node.getProperties(String namePattern) also child nodes are > processed > > > Key: JCR-4001 > URL: https://issues.apache.org/jira/browse/JCR-4001 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr-commons >Reporter: Luca Tagliani >Assignee: Julian Reschke >Priority: Major > Labels: candidate_jcr_2_16 > Fix For: 2.18 > > Attachments: JCR-4001-2.diff, JCR-4001.patch > > > Call to Node.getProperties(String namePattern) processed also child nodes and > not only properties. > This can deteriorate performance when there are lots of children. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[ https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330799#comment-16330799 ] Julian Reschke commented on JCR-4001: - https://issues.apache.org/jira/secure/attachment/12906671/JCR-4001-2.diff A slightly simpler patch that avoids the visitor pattern for properties altogether. [~luca.tagliani] - do you want to try that? > When using Node.getProperties(String namePattern) also child nodes are > processed > > > Key: JCR-4001 > URL: https://issues.apache.org/jira/browse/JCR-4001 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr-commons >Reporter: Luca Tagliani >Assignee: Julian Reschke >Priority: Major > Labels: candidate_jcr_2_16 > Fix For: 2.18 > > Attachments: JCR-4001-2.diff, JCR-4001.patch > > > Call to Node.getProperties(String namePattern) processed also child nodes and > not only properties. > This can deteriorate performance when there are lots of children. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[
https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330464#comment-16330464
]
Julian Reschke commented on JCR-4001:
-
applying this patch would require a version number bump:
{noformat}
[INFO] * org.apache.jackrabbit.util minor 2.4.0
2.4.0 2.5.0 Version increase required
[INFO] < class org.apache.jackrabbit.util.ChildrenCollectorFilter
[INFO] + method visit(javax.jcr.Node)
[INFO] + method visit(javax.jcr.Property)
{noformat}
> When using Node.getProperties(String namePattern) also child nodes are
> processed
>
>
> Key: JCR-4001
> URL: https://issues.apache.org/jira/browse/JCR-4001
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
>Reporter: Luca Tagliani
>Assignee: Julian Reschke
>Priority: Major
> Attachments: JCR-4001.patch
>
>
> Call to Node.getProperties(String namePattern) processed also child nodes and
> not only properties.
> This can deteriorate performance when there are lots of children.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[
https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316452#comment-16316452
]
Julian Reschke commented on JCR-4001:
-
I agree that this should be improved. The proposed patch essentially
re-implements {{TraversingItemVisitor.Default}} (which is part javax.jcr).
It might be simpler though to change the property collectors not to use the
visitor pattern at all.
> When using Node.getProperties(String namePattern) also child nodes are
> processed
>
>
> Key: JCR-4001
> URL: https://issues.apache.org/jira/browse/JCR-4001
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
>Reporter: Luca Tagliani
>Assignee: Julian Reschke
> Attachments: JCR-4001.patch
>
>
> Call to Node.getProperties(String namePattern) processed also child nodes and
> not only properties.
> This can deteriorate performance when there are lots of children.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[ https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316195#comment-16316195 ] Julian Reschke commented on JCR-4001: - I'll have a look, but I can't promise yet when... > When using Node.getProperties(String namePattern) also child nodes are > processed > > > Key: JCR-4001 > URL: https://issues.apache.org/jira/browse/JCR-4001 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-jcr-commons >Affects Versions: 2.12.2 >Reporter: Luca Tagliani >Assignee: Julian Reschke > Attachments: JCR-4001.patch > > > Call to Node.getProperties(String namePattern) processed also child nodes and > not only properties. > This can deteriorate performance when there are lots of children. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (JCR-4001) When using Node.getProperties(String namePattern) also child nodes are processed
[ https://issues.apache.org/jira/browse/JCR-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316168#comment-16316168 ] Luca Tagliani commented on JCR-4001: Are there any possibility that this patch could be merged on trunk for next release? > When using Node.getProperties(String namePattern) also child nodes are > processed > > > Key: JCR-4001 > URL: https://issues.apache.org/jira/browse/JCR-4001 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-jcr-commons >Affects Versions: 2.12.2 >Reporter: Luca Tagliani > Attachments: JCR-4001.patch > > > Call to Node.getProperties(String namePattern) processed also child nodes and > not only properties. > This can deteriorate performance when there are lots of children. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
