[jira] [Commented] (JCR-4267) ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
[
https://issues.apache.org/jira/browse/JCR-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531189#comment-17531189
]
Hans-Peter Stoerr commented on JCR-4267:
For the record: I had created https://issues.apache.org/jira/browse/JCRVLT-526
, which has been solved.
> ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
> ---
>
> Key: JCR-4267
> URL: https://issues.apache.org/jira/browse/JCR-4267
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
>Affects Versions: 2.17.1
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the ISO8601.parse
> (https://github.com/apache/jackrabbit/blob/86e15df24c68c8132361466c80f65862f8709880/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/ISO8601.java#L86)
> method only supports a subset of time designators being specified by ISO8601.
> Namely the ones {{±hhmm}} and {{±hh}} are missing.
> This is currently a problem for Jackrabbit Filevault Maven Package, as that
> is using these designators in
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f53c53102e97d0bb000794ee2976cabecf62e5ad/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L1038.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (JCR-4267) ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
[
https://issues.apache.org/jira/browse/JCR-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353058#comment-17353058
]
Konrad Windszus commented on JCR-4267:
--
[~hanspeterstoerr] Please rather create a new issue for FileVault to support
parsing those date formats. One has to figure out how to do that in FileVault
then. But ISO8601 is a general purpose class in Jackrabbit with clearly
documented limitations.
> ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
> ---
>
> Key: JCR-4267
> URL: https://issues.apache.org/jira/browse/JCR-4267
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
>Affects Versions: 2.17.1
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the ISO8601.parse
> (https://github.com/apache/jackrabbit/blob/86e15df24c68c8132361466c80f65862f8709880/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/ISO8601.java#L86)
> method only supports a subset of time designators being specified by ISO8601.
> Namely the ones {{±hhmm}} and {{±hh}} are missing.
> This is currently a problem for Jackrabbit Filevault Maven Package, as that
> is using these designators in
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f53c53102e97d0bb000794ee2976cabecf62e5ad/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L1038.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCR-4267) ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
[
https://issues.apache.org/jira/browse/JCR-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353019#comment-17353019
]
Hans-Peter Stoerr commented on JCR-4267:
This has quite nasty consequences.
com.day.jcr.vault:content-package-maven-plugin (I tried versions 0.0.12 and
0.5.4) write package properties (e.g. creation time) using the format +=hhmm .
If these packages are put into a filesystem registry, e.g.
org.apache.jackrabbit.vault.packaging.impl.PackagePropertiesImpl.getCreated()
returns null because it uses org.apache.jackrabbit.util.ISO8601.parse to parse
the date - and that fails. So right now one has to use nasty workarounds like
packageProps.getProperty(PackageProperties.NAME_CREATED) and parse it oneself.
:( So I'd strongly support allowing these timezone formats.
> ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
> ---
>
> Key: JCR-4267
> URL: https://issues.apache.org/jira/browse/JCR-4267
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
>Affects Versions: 2.17.1
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the ISO8601.parse
> (https://github.com/apache/jackrabbit/blob/86e15df24c68c8132361466c80f65862f8709880/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/ISO8601.java#L86)
> method only supports a subset of time designators being specified by ISO8601.
> Namely the ones {{±hhmm}} and {{±hh}} are missing.
> This is currently a problem for Jackrabbit Filevault Maven Package, as that
> is using these designators in
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f53c53102e97d0bb000794ee2976cabecf62e5ad/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L1038.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCR-4267) ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
[
https://issues.apache.org/jira/browse/JCR-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372763#comment-16372763
]
Julian Reschke commented on JCR-4267:
-
Not convinced.
Why does filevault use this format when it never has been supported by the
jackrabbit parser? How is including the timezone offset of any use here?
> ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
> ---
>
> Key: JCR-4267
> URL: https://issues.apache.org/jira/browse/JCR-4267
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
>Affects Versions: 2.17.1
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the ISO8601.parse
> (https://github.com/apache/jackrabbit/blob/86e15df24c68c8132361466c80f65862f8709880/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/ISO8601.java#L86)
> method only supports a subset of time designators being specified by ISO8601.
> Namely the ones {{±hhmm}} and {{±hh}} are missing.
> This is currently a problem for Jackrabbit Filevault Maven Package, as that
> is using these designators in
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f53c53102e97d0bb000794ee2976cabecf62e5ad/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L1038.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
