[jira] [Updated] (JCRVLT-285) IllegalStateException logged on INFO level when using PackagingService
[
https://issues.apache.org/jira/browse/JCRVLT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szymon Owczarzak updated JCRVLT-285:
Description:
When using:
{code:java}
PackagingService.getPackageManager(session)
{code}
Stack trace is logged on INFO level which is looking very awful. I think this
kind of information should not be logged on info level - it is more a debug
message from my point of view.
Please consider changing implementation.
{code:java}
public static JcrPackageManager getPackageManager(Session session) {
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Alternate package
roots will not be respected.", e);
// szymon: maybe better message should be used without whole stack
trace ?
}
// todo: should somehow pass the package roots
return new JcrPackageManagerImpl(session, new String[0]);
}
{code}
[https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
h2. Possible solution:
{code:java}
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Stack trace
logged on debug level.");
log.debug("JcrPackageManager acquired w/o service! Alternate
package roots will not be respected.", e);
}
{code}
was:
When using:
{code:java}
PackagingService.getPackageManager(session)
{code}
Stack trace is logged on INFO level which is looking very awful.
{code:java}
public static JcrPackageManager getPackageManager(Session session) {
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Alternate package
roots will not be respected.", e);
// szymon: maybe better message should be used without whole stack
trace ?
}
// todo: should somehow pass the package roots
return new JcrPackageManagerImpl(session, new String[0]);
}
{code}
[https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
Possible solution:
{code:java}
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Stack trace
logged on debug level.");
log.debug("JcrPackageManager acquired w/o service! Alternate
package roots will not be respected.", e);
}
{code}
> IllegalStateException logged on INFO level when using PackagingService
> --
>
> Key: JCRVLT-285
> URL: https://issues.apache.org/jira/browse/JCRVLT-285
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Reporter: Szymon Owczarzak
>Priority: Major
>
> When using:
> {code:java}
> PackagingService.getPackageManager(session)
> {code}
> Stack trace is logged on INFO level which is looking very awful. I think this
> kind of information should not be logged on info level - it is more a debug
> message from my point of view.
> Please consider changing implementation.
> {code:java}
> public static JcrPackageManager getPackageManager(Session session) {
> try {
> throw new IllegalStateException();
> } catch (IllegalStateException e) {
> log.info("JcrPackageManager acquired w/o service! Alternate
> package roots will not be respected.", e);
> // szymon: maybe better message should be used without whole
> stack trace ?
> }
> // todo: should somehow pass the package roots
> return new JcrPackageManagerImpl(session, new String[0]);
> }
> {code}
> [https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
> h2. Possible solution:
> {code:java}
> try {
> throw new IllegalStateException();
> } catch (IllegalStateException e) {
> log.info("JcrPackageManager acquired w/o service! Stack trace
> logged on debug level.");
> log.debug("JcrPackageManager acquired w/o service! Alternate
> package roots will not be respected.", e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (JCRVLT-285) IllegalStateException logged on INFO level when using PackagingService
[
https://issues.apache.org/jira/browse/JCRVLT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szymon Owczarzak updated JCRVLT-285:
Description:
When using:
{code:java}
PackagingService.getPackageManager(session)
{code}
Stack trace is logged on INFO level which is looking very awful.
{code:java}
public static JcrPackageManager getPackageManager(Session session) {
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Alternate package
roots will not be respected.", e);
// szymon: maybe better message should be used without whole stack
trace ?
}
// todo: should somehow pass the package roots
return new JcrPackageManagerImpl(session, new String[0]);
}
{code}
[https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
Possible solution:
{code:java}
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Stack trace
logged on debug level.");
log.debug("JcrPackageManager acquired w/o service! Alternate
package roots will not be respected.", e);
}
{code}
was:
When using:
{code:java}
PackagingService.getPackageManager(session)
{code}
Stack trace is logged on INFO level which is looking very awful.
{code:java}
public static JcrPackageManager getPackageManager(Session session) {
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Alternate package
roots will not be respected.", e);
// szymon: maybe better message should be used without whole stack
trace ?
}
// todo: should somehow pass the package roots
return new JcrPackageManagerImpl(session, new String[0]);
}
{code}
[https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
Possible solution:
> IllegalStateException logged on INFO level when using PackagingService
> --
>
> Key: JCRVLT-285
> URL: https://issues.apache.org/jira/browse/JCRVLT-285
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Reporter: Szymon Owczarzak
>Priority: Major
>
> When using:
> {code:java}
> PackagingService.getPackageManager(session)
> {code}
> Stack trace is logged on INFO level which is looking very awful.
> {code:java}
> public static JcrPackageManager getPackageManager(Session session) {
> try {
> throw new IllegalStateException();
> } catch (IllegalStateException e) {
> log.info("JcrPackageManager acquired w/o service! Alternate
> package roots will not be respected.", e);
> // szymon: maybe better message should be used without whole
> stack trace ?
> }
> // todo: should somehow pass the package roots
> return new JcrPackageManagerImpl(session, new String[0]);
> }
> {code}
> [https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
> Possible solution:
>
> {code:java}
> try {
> throw new IllegalStateException();
> } catch (IllegalStateException e) {
> log.info("JcrPackageManager acquired w/o service! Stack trace
> logged on debug level.");
> log.debug("JcrPackageManager acquired w/o service! Alternate
> package roots will not be respected.", e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (JCRVLT-285) IllegalStateException logged on INFO level when using PackagingService
[
https://issues.apache.org/jira/browse/JCRVLT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szymon Owczarzak updated JCRVLT-285:
Description:
When using:
{code:java}
PackagingService.getPackageManager(session)
{code}
Stack trace is logged on INFO level which is looking very awful.
{code:java}
public static JcrPackageManager getPackageManager(Session session) {
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Alternate package
roots will not be respected.", e);
// szymon: maybe better message should be used without whole stack
trace ?
}
// todo: should somehow pass the package roots
return new JcrPackageManagerImpl(session, new String[0]);
}
{code}
[https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
Possible solution:
was:
When using:
{code:java}
PackagingService.getPackageManager(session)
{code}
Stack trace is logged on INFO level.
{code:java}
public static JcrPackageManager getPackageManager(Session session) {
try {
throw new IllegalStateException();
} catch (IllegalStateException e) {
log.info("JcrPackageManager acquired w/o service! Alternate package
roots will not be respected.", e);
// szymon: maybe better message should be used without whole stack
trace ?
}
// todo: should somehow pass the package roots
return new JcrPackageManagerImpl(session, new String[0]);
}
{code}
[https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
> IllegalStateException logged on INFO level when using PackagingService
> --
>
> Key: JCRVLT-285
> URL: https://issues.apache.org/jira/browse/JCRVLT-285
> Project: Jackrabbit FileVault
> Issue Type: Bug
>Reporter: Szymon Owczarzak
>Priority: Major
>
> When using:
> {code:java}
> PackagingService.getPackageManager(session)
> {code}
> Stack trace is logged on INFO level which is looking very awful.
> {code:java}
> public static JcrPackageManager getPackageManager(Session session) {
> try {
> throw new IllegalStateException();
> } catch (IllegalStateException e) {
> log.info("JcrPackageManager acquired w/o service! Alternate
> package roots will not be respected.", e);
> // szymon: maybe better message should be used without whole
> stack trace ?
> }
> // todo: should somehow pass the package roots
> return new JcrPackageManagerImpl(session, new String[0]);
> }
> {code}
> [https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
> Possible solution:
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (JCRVLT-285) IllegalStateException logged on INFO level when using PackagingService
[
https://issues.apache.org/jira/browse/JCRVLT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szymon Owczarzak updated JCRVLT-285:
Issue Type: Improvement (was: Bug)
> IllegalStateException logged on INFO level when using PackagingService
> --
>
> Key: JCRVLT-285
> URL: https://issues.apache.org/jira/browse/JCRVLT-285
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Reporter: Szymon Owczarzak
>Priority: Major
>
> When using:
> {code:java}
> PackagingService.getPackageManager(session)
> {code}
> Stack trace is logged on INFO level which is looking very awful.
> {code:java}
> public static JcrPackageManager getPackageManager(Session session) {
> try {
> throw new IllegalStateException();
> } catch (IllegalStateException e) {
> log.info("JcrPackageManager acquired w/o service! Alternate
> package roots will not be respected.", e);
> // szymon: maybe better message should be used without whole
> stack trace ?
> }
> // todo: should somehow pass the package roots
> return new JcrPackageManagerImpl(session, new String[0]);
> }
> {code}
> [https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackagingService.java]
> Possible solution:
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
