Re: [VOTE] Release JMeter 2.5.1 RC3

2011-10-03 Thread sebb
On 29 September 2011 00:52, Milamber milam...@apache.org wrote: Hello, The third release candidate for JMeter 2.5.1 has been prepared, and your votes are solicited. This release fixes mainly some bugs appeared since JMeter 2.5, and contains few improvements. Tests (load tests and/or

Re: [VOTE] Release JMeter 2.5.1 RC3

2011-10-03 Thread Oleg Kalnichevski
On Mon, 2011-10-03 at 10:03 +0100, sebb wrote: On 29 September 2011 00:52, Milamber milam...@apache.org wrote: Hello, The third release candidate for JMeter 2.5.1 has been prepared, and your votes are solicited. This release fixes mainly some bugs appeared since JMeter 2.5, and

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread Rainer Jung
On 02.10.2011 23:17, Philippe Mouawad wrote: Ok, hope we can do the same. See https://issues.apache.org/jira/browse/XMLBEANS-447 We are not the only people, who doubt it's correct to include that class ... There was also a discussion some time ago in another ASF project, because the Sun

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread sebb
On 3 October 2011 12:15, Rainer Jung rainer.j...@kippdata.de wrote: On 02.10.2011 23:17, Philippe Mouawad wrote: Ok, hope we can do the same. See https://issues.apache.org/jira/browse/XMLBEANS-447 We are not the only people, who doubt it's correct to include that class ... There was also a

Re: [VOTE] Release JMeter 2.5.1 RC3

2011-10-03 Thread Rainer Jung
On 03.10.2011 11:03, sebb wrote: The 72 hours are up. Although some additional bugs have surfaced, as far as I know these aren't regressions, so users are no worse off running 2.5.1, and in many respects it is better than 2.5. Therefore I think we should continue with the release.

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread Philippe Mouawad
Hello, Just a little update on my test. I added a clear and gc before each Map instanciation and results are different: - HashMapput:645 - ConcurrentHashMapput:832 - ConcurrentReaderHashMapput:620 - HashMap get:17 - ConcurrentHashMap get:32 - ConcurrentReaderHashMap get:60 So

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread sebb
On 3 October 2011 13:14, Philippe Mouawad philippe.moua...@gmail.com wrote: Sebb, Do you want me to provide a patch with ConcurrentHashMap where I will have to handle null keys and values (not same behaviour as HashMap) or we forget about this approach ? I don't think we have yet decided how

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread Philippe Mouawad
You are right, Patch was just about quick fix before the more impacting fix. Here are my propositions regarding this more impacting fix: - Add an option to make conc download use or not cookie, default value will be false. - In AsyncSampler make a Clone with current cookies of Parent

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread sebb
On 3 October 2011 14:04, Philippe Mouawad philippe.moua...@gmail.com wrote: You are right, Patch was just about quick fix before the more impacting fix. Here are my propositions regarding this more impacting fix:   - Add an option to make conc download use or not cookie, default value  

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread Philippe Mouawad
On Mon, Oct 3, 2011 at 4:31 PM, sebb seb...@gmail.com wrote: On 3 October 2011 14:04, Philippe Mouawad philippe.moua...@gmail.com wrote: You are right, Patch was just about quick fix before the more impacting fix. Here are my propositions regarding this more impacting fix: - Add

Running ant test fails

2011-10-03 Thread Philippe Mouawad
Hello, I just updated and I get: BUILD FAILED */data/decathlon/workspace/jmeter/build.xml:1882: The following error occurred while executing this line: /data/decathlon/workspace/jmeter/build.xml:1875: Problem: failed to create task or type local Cause: The name is undefined. Action: Check the

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread sebb
On 3 October 2011 16:07, Shmuel Krakower shmul...@gmail.com wrote: Hi, Why isn't Cookie manager implemented the way Cache manager is (using a thread local hash map)? Probably mainly historical. Cookies are currently stored in an ArrayList, but one could perhaps use a HashMap instead. Though

Re: Running ant test fails

2011-10-03 Thread Philippe Mouawad
Apache Ant version 1.7.1 compiled on June 27 2008 On Mon, Oct 3, 2011 at 5:30 PM, sebb seb...@gmail.com wrote: On 3 October 2011 16:12, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello, I just updated and I get: BUILD FAILED */data/decathlon/workspace/jmeter/build.xml:1882: The

Re: Running ant test fails

2011-10-03 Thread sebb
On 3 October 2011 16:39, Philippe Mouawad philippe.moua...@gmail.com wrote: Apache Ant version 1.7.1 compiled on June 27 2008 You need to update to at least 1.8. I added a check for that for the download_jars target, but the check obviously needs to be done for other targets too. Or simpler, we

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread Philippe Mouawad
Hello, By the way I think there is also an issue in CacheManager due to the use of InheritableThreadLocal (which is not thread safe). Indeed this Map is shared by concurrent children thread, so Map is accessed concurrently but not thread-safe = ISSUE I made a little main sample that I can attach

Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download

2011-10-03 Thread Philippe Mouawad
I opened : https://issues.apache.org/bugzilla/show_bug.cgi?id=51942 and provided patch. Regards Philippe On Mon, Oct 3, 2011 at 6:16 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello, By the way I think there is also an issue in CacheManager due to the use of

Re: [VOTE] Release JMeter 2.5.1 RC3

2011-10-03 Thread Milamber
Le 03/10/2011 11:03, sebb a ecrit : On 29 September 2011 00:52, Milamber milam...@apache.org wrote: Hello, The third release candidate for JMeter 2.5.1 has been prepared, and your votes are solicited. This release fixes mainly some bugs appeared since JMeter 2.5, and contains few

[VOTE][RESULT] Release JMeter 2.5.1 based on 2.5.1RC3

2011-10-03 Thread Milamber
Hello, Thanks very much to all who voted. The votes were as follows: (*) binding +1 Milamber (*) Philippe Mouawad Peter Lin (*) Sebastian Bazley (*) Oleg Kalnichevski (*) There were no other votes, so the vote passes. Milamber

[ANNOUNCE] JMeter 2.5.1 is released

2011-10-03 Thread Milamber
The Apache JMeter team announces the availability of Apache JMeter 2.5.1 r1176908. This release corrects mainly a few bugs that were introduced in 2.5. Additional known bugs: Version 2.5 introduced a concurrent download feature for embedded HTML resources. Unfortunately this may result in