[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 Looks like a really nice extension to the current machinery! I notice there is a unit test for the assembler support but no unit tests for using some of these new features, would it be possible

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 Btw as you are now a committer you can follow the instructions at https://reference.apache.org/committer/github to get added to the Apache GitHub org so you'll show up as `Member` and not just as

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 @xristy Yes I don't think there is any harm in supporting both the explicit form as well as supporting literal datatypes directly ---

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread osma
Github user osma commented on the issue: https://github.com/apache/jena/pull/385 Wow, quite a big patch for a "straightforward" change :) Great work @xristy ! +1 to @rvesse's suggestion to simplify by making use of literal data types, if it's possible. Thanks for

[jira] [Comment Edited] (JENA-1506) Add configurable filters and tokenizers

2018-03-16 Thread Code Ferret (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401021#comment-16401021 ] Code Ferret edited comment on JENA-1506 at 3/16/18 1:56 PM: TheĀ 

[jira] [Commented] (JENA-1508) Update OSGi provisioning features

2018-03-16 Thread Aaron Coburn (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402394#comment-16402394 ] Aaron Coburn commented on JENA-1508: One item to note about this is that, in the Karaf 4.2.0.M2

[jira] [Created] (JENA-1508) Update OSGi provisioning features

2018-03-16 Thread Aaron Coburn (JIRA)
Aaron Coburn created JENA-1508: -- Summary: Update OSGi provisioning features Key: JENA-1508 URL: https://issues.apache.org/jira/browse/JENA-1508 Project: Apache Jena Issue Type: Improvement

[GitHub] jena pull request #386: JENA-1508 Update OSGi provisioning features

2018-03-16 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/386 JENA-1508 Update OSGi provisioning features This marks the `com.google.errorprone.annotations.concurrent` package as optional. It also adds the (currently missing) `commons-codec` dependency

[jira] [Commented] (JENA-1508) Update OSGi provisioning features

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402388#comment-16402388 ] ASF GitHub Bot commented on JENA-1508: -- GitHub user acoburn opened a pull request:

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/385 @rvesse On the matter of the tests, I just updated the ticket on that matter: > There are already a suite of tests associated with TestDatasetWithConfigurableAnalyzer that exercise the new

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060216 --- Diff: jena-arq/src/main/java/org/apache/jena/query/Query.java --- @@ -707,6 +719,8 @@ public void visit(QueryVisitor visitor)

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060320 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/JsonIterator.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175061201 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ResultSetFormatter.java --- @@ -516,6 +520,41 @@ static public void outputAsJSON(boolean booleanResult)

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060362 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/QueryExecutionBase.java --- @@ -335,7 +340,45 @@ public boolean execAsk() { }

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401763#comment-16401763 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401762#comment-16401762 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401766#comment-16401766 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060592 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 ![screenshot_2018-03-17_00-18-10](https://user-images.githubusercontent.com/304786/37518419-ec3b0fb4-2979-11e8-8c70-32666946d00b.png)

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401764#comment-16401764 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401765#comment-16401765 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401768#comment-16401768 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on the issue: