Re: When should we use Java's UUID, and when should we use Jena's JenaUUIDs?

2018-08-11 Thread Bruno P. Kinoshita
Oohh. I love when explanations like this contains bits of history about the project. As well as the sense of humour in some of our logging messages :)

[jira] [Commented] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577337#comment-16577337 ] ASF subversion and git services commented on JENA-1590: --- Commit

[GitHub] jena issue #460: JENA-1590: fix if statement in RDFWriter#output

2018-08-11 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/460 Merging (amended my e-mail in the commit, replacing the no-reply from GitHub by my apache.org one) ---

[GitHub] jena pull request #460: JENA-1590: fix if statement in RDFWriter#output

2018-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/460 ---

[jira] [Commented] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577336#comment-16577336 ] ASF GitHub Bot commented on JENA-1590: -- Github user kinow commented on the issue:

[jira] [Commented] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577339#comment-16577339 ] ASF GitHub Bot commented on JENA-1590: -- Github user asfgit closed the pull request at:

[jira] [Commented] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577338#comment-16577338 ] ASF subversion and git services commented on JENA-1590: --- Commit

[jira] [Resolved] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved JENA-1590. -- Resolution: Fixed > Fix if statement in RDFWriter#output(String) >

[GitHub] jena pull request #461: JENA-1591: use boolean value in if expression

2018-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/461 ---

[jira] [Commented] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577341#comment-16577341 ] ASF GitHub Bot commented on JENA-1591: -- Github user kinow commented on the issue:

[GitHub] jena issue #461: JENA-1591: use boolean value in if expression

2018-08-11 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/461 Rebased and amended to use my apache e-mail in the commits. Merging. Thanks!!! ---

[jira] [Commented] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577343#comment-16577343 ] ASF subversion and git services commented on JENA-1591: --- Commit

[jira] [Commented] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577342#comment-16577342 ] ASF subversion and git services commented on JENA-1591: --- Commit

[jira] [Commented] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577344#comment-16577344 ] ASF GitHub Bot commented on JENA-1591: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved JENA-1591. -- Resolution: Fixed > DBOE TransactionCoordinator#finishActiveTransaction has an invalid

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209421919 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/DataService.java --- @@ -151,50 +151,24 @@ public long getRequestsBad() {

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209422526 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/sys/TDBInternal.java --- @@ -176,6 +176,23 @@ public static synchronized void expel(DatasetGraph

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209422540 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/IO.java --- @@ -364,4 +369,31 @@ public static String uniqueFilename(String directory, String base,

Transaction listener?

2018-08-11 Thread Claude Warren
Disclaimer first: I have not looked at any of the transaction code. Is there a mechanism within Jena/Fuseki to listen for/be notified of transaction states. I am particularly interested in detecting commits. I am hoping for something like the graph/model listeners. Claude

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209424635 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/sys/TDBInternal.java --- @@ -176,6 +176,23 @@ public static synchronized void expel(DatasetGraph

[jira] [Commented] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577174#comment-16577174 ] ASF GitHub Bot commented on JENA-1590: -- GitHub user kinow opened a pull request:

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209421904 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/HttpAction.java --- @@ -270,30 +269,50 @@ public boolean isTransactional()

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209421906 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/HttpAction.java --- @@ -18,8 +18,8 @@ package

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209421902 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Upload.java --- @@ -20,35 +20,39 @@ import static

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209421898 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Upload.java --- @@ -20,35 +20,39 @@ import static

When should we use Java's UUID, and when should we use Jena's JenaUUIDs?

2018-08-11 Thread Bruno P. Kinoshita
Hi! Regarding changes in Jena code, not talking about SPARQL uuid or struuid functions... Does anyone here know when one would use Java's UUID in Jena over JenaUUID implementations, or vice versa? I wrote one of those brain-dump posts, with several notes to myself, about what happens when

[GitHub] jena pull request #460: JENA-1590: fix if statement in RDFWriter#output

2018-08-11 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/jena/pull/460 JENA-1590: fix if statement in RDFWriter#output Eclipse alerted for some Dead code in this class, and after having a look, I thought we actually had to check the `lang` in the second `if`, not `ct`?

[jira] [Created] (JENA-1590) Fix if statement in RDFWriter#output(String)

2018-08-11 Thread Bruno P. Kinoshita (JIRA)
Bruno P. Kinoshita created JENA-1590: Summary: Fix if statement in RDFWriter#output(String) Key: JENA-1590 URL: https://issues.apache.org/jira/browse/JENA-1590 Project: Apache Jena Issue

[jira] [Created] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread Bruno P. Kinoshita (JIRA)
Bruno P. Kinoshita created JENA-1591: Summary: DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object Key: JENA-1591 URL: https://issues.apache.org/jira/browse/JENA-1591

[GitHub] jena pull request #461: JENA-1591: use boolean value in if expression

2018-08-11 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/jena/pull/461 JENA-1591: use boolean value in if expression Another one found in Eclipse while I was reading some other code for UUID's. The value returned from the `Set` object will be a `boolean`, so the `==

[jira] [Commented] (JENA-1591) DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a boolean/Object

2018-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577176#comment-16577176 ] ASF GitHub Bot commented on JENA-1591: -- GitHub user kinow opened a pull request:

Re: Transaction listener?

2018-08-11 Thread Andy Seaborne
https://afs.github.io/rdf-delta/ On 11/08/18 11:32, Claude Warren wrote: Disclaimer first: I have not looked at any of the transaction code. > Is there a mechanism within Jena/Fuseki to listen for/be notified of transaction states. I am particularly interested in detecting commits. I am

Re: When should we use Java's UUID, and when should we use Jena's JenaUUIDs?

2018-08-11 Thread Andy Seaborne
JenaUUID predates UUID. Yep - it is really old. V1 UUIDs used to be the more encouraged form ... nowadays they aren't - they don't even work really. Why? devices don't have a guaranteed 48 bit address or anything else to seed the device unique part. Fine, when everything was a computer