[GitHub] jena pull request: JENA-878 Avoid exposing xerces.impl.dv

2015-02-19 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/31#discussion_r24980025 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/datatypes/xsd/XSDDatatype.java --- @@ -251,7 +269,7 @@ public XSDDatatype(String typeName, Class? javaClass

[GitHub] jena pull request: JENA-878 Avoid exposing xerces.impl.dv

2015-02-18 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/31#discussion_r24904627 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/datatypes/xsd/XSDDatatype.java --- @@ -18,34 +18,52 @@ package com.hp.hpl.jena.datatypes.xsd

[GitHub] jena pull request: JENA-878 Avoid exposing xerces.impl.dv

2015-02-18 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/31#discussion_r24904425 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/datatypes/xsd/impl/XSDGenericType.java --- @@ -1,66 +0,0 @@ -/* --- End diff -- Why

[GitHub] jena pull request: Guava as shaded dependency

2015-03-22 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/45#discussion_r26902175 --- Diff: jena-shadowed-ext/pom.xml --- @@ -0,0 +1,107 @@ +?xml version=1.0 encoding=utf-8? +!-- + Licensed to the Apache Software Foundation (ASF

[GitHub] jena pull request: Guava as shaded dependency

2015-03-22 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/45#discussion_r26902155 --- Diff: jena-shadowed-ext/pom.xml --- @@ -0,0 +1,107 @@ +?xml version=1.0 encoding=utf-8? +!-- + Licensed to the Apache Software Foundation (ASF

[GitHub] jena pull request: JENA-901 Upper bound on LPDRuleEngine cache

2015-03-20 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/44#discussion_r26858470 --- Diff: jena-core/pom.xml --- @@ -45,6 +45,13 @@ scopetest/scope /dependency + dependency + groupIdcom.carrotsearch

[GitHub] jena pull request: JENA-901 Upper bound on LPDRuleEngine cache

2015-03-20 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/44#discussion_r26859236 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/util/BoundedLRUMap.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] jena pull request: Guava as shaded dependency

2015-03-23 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/45#discussion_r26977608 --- Diff: jena-shadowed-ext/pom.xml --- @@ -0,0 +1,107 @@ +?xml version=1.0 encoding=utf-8? +!-- + Licensed to the Apache Software Foundation (ASF

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98178582 Looks good. If it would be helpful to you, we can break this up into several steps in anyway so as to make it progressive improvement? e.g. even as specific as as rename

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98217891 FYI: For iterators see `Iter` (in jena-base). Again, pre-java8 but has a use in applying stream-list functions to iterators, instead of converting iterator to stream

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98231727 OK - to confirm this PR is not draft any more but proposed final. `ExtendedIterator` is different because it is in the `Graph` interface from `find`. That means

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98218286 Looks like a good plan. The last point (manipulations) is possibly open-ended than the first two. --- If your project is set up for it, you can reply to this email and have

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98221746 History! It's used in jena-sdb and jena-tdb. It originated out of work on SDB (pre-iterables) and needed to work on general iterators, not (just) ExtendedIterators. It has

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-98085046 Hi - this is looking good. Merge conflicts arise because of the Jena3 migration. Any packages com.hp.hpl.jena have become org.apache.jena. Don't worry about that, we

[GitHub] jena pull request: JENA-909 - Docker image for Fuseki 2

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/50#issuecomment-98122275 It would be great if this could be tested by someone. The README describes a registry.hub.docker.com image stain/jena-fuseki and the document says stain/jena-fuseki

[GitHub] jena pull request: JENA-901 LPDRuleEngine cache Guava from jena-sh...

2015-05-01 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/47#discussion_r29499092 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/reasoner/rulesys/impl/LPBRuleEngine.java --- @@ -52,16 +66,22 @@ protected boolean recordDerivations

[GitHub] jena pull request: JENA-901 LPDRuleEngine cache Guava from jena-sh...

2015-05-01 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/47#discussion_r29499213 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/reasoner/rulesys/impl/LPBRuleEngine.java --- @@ -252,19 +272,31 @@ public synchronized void tablePredicate(Node

[GitHub] jena pull request: JENA-901 LPDRuleEngine cache Guava from jena-sh...

2015-05-01 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/47#discussion_r29499192 --- Diff: jena-core/src/main/java/com/hp/hpl/jena/reasoner/rulesys/impl/LPBRuleEngine.java --- @@ -252,19 +272,31 @@ public synchronized void tablePredicate(Node

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98128625 Looks good but I'm having a problem with {{OntResourceImpl.AsMapper}}. This is removed in {{OntResourceImpl}] but still in use in {{OntClassImpl}}, {{EnumeratedClassImpl

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129164 Created JENA-929 to help track this long-term. Just mention JENA-929 in comments and the JIRA wil be updated automatically. --- If your project is set up for it, you can reply

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98133080 Got it - it's clean now. I remove unused imports, replaced Statement.Util and some Triple statics by rewriting the few uses in place e.g. Statement::getSubject. --- If your

[GitHub] jena pull request: Jena base to java8

2015-05-06 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99403016 I'll look again but the NodeTransform and the Closeable issues seem to be the main things and after that the size is due to the number of places that Java8 improves things

[GitHub] jena pull request: Jena base to java8

2015-05-05 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99120861 The vast majority of the PR looks good including converting code in passing. MultiMap?mulitSet are unlikely to have leaked (and can be restored if need be); I've already

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938759 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -33,7 +33,7 @@ /** Create a null cache */ public static

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938565 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements CacheK

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29939141 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements CacheK

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29957079 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements CacheK

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29957731 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29958189 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29957286 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100894301 I fixed the bug while I was looking at it :-) I'll review and try out the current state and merge it if there are no further comments. --- If your project is set up

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-09 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29995826 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements CacheK

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-09 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29995830 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101012215 Thrift is another Apache project. In the Thrift case, all Jena adds the `@SuppressWarnings(all)` at the top. As the warnings also depend on the local compiler settings, its

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-101007860 Good suggestion. I'll add that as I do #59. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101010157 The files in package thrift/wire starting `RDF_` are autogenerated by the Thrift code generator. They'll get uncleaned if that's remade. (Thrift code generation is not part

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/63#discussion_r30086187 --- Diff: jena-core/src/main/java/jena/rdfcompare.java --- @@ -108,11 +105,6 @@ protected static void usage() { protected static void read(Model

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-101003455 Thank you. Merged into code base, and reflecting the conversion here: Keep Cache0 (avoid nulls!) and keep the general CacheSet over a Cache due to otherwise changing

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101013671 Please, if it's easy to do that; ditto the javacc overwrites. (sparql_10 are sparql_11 actually code directly from SPARQL spec so anything touching them gets special

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101015106 Yes. (Sorry about assuming that was clear - over-familiarity with the code layout) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938058 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -33,7 +33,7 @@ /** Create a null cache */ public static

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938061 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -43,7 +43,7 @@ /** One slot cache */ public static Key

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938052 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/Cache1.java --- @@ -1,127 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101212657 Another code generated batch : org/apache/jena/iri/impl/Lexer* are JFlex generated (these files do all say autogenerated in them) --- If your project is set up

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101221776 This PR looks easier to process (it does not mix a lot of modules; sometimes that mix means several people are going to be interested, but in different parts). How

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101213856 JENA-938 (using this PR to cover #60, #61, #62, #63) Some of these are style points: Unthrown checked exceptions: many (not all but most in my sampling

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101215479 One possibility is to keep Java8-isms out of Elephas (on a practical basis) for the moment so backporting to 2.13.0 is a low barrier. Obviously, bug fixes that go into 3.0.0

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-13 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101780114 Generally yes - fixes are better when possible. In this case though (on `.factory`) there is a coding pattern than was fine at the time and now isn't. The hiding effect

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-14 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-102169543 I've picked out as much material from the PR as I can and applied according to the discussions (so not removing interface declarations when the base type includes it, left

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101256776 Good point. I wasn't able to catch on this PR before the JENA-938 ones emerged over the weekend so you have got ahead of me and everyone else. My apologies. Finding

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-18 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103207166 jena-elephas, querybuilder, and the rest (Fuseki's) would be great. (Actually, looking at the querybuilder file, I wonder if that is a style for a purpose ... @Claudenw

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101214478 Actually, it looks like there is quite an impetus to get Hadoop on Java8 (even if Java6/7 bytecodes). EOL is making it a focus of attention. --- If your project is set up

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101322670 When I applied the changes, I get a lot of hiding warnings. Seems to me the root cause is the hiding in the first place, not the use of `@SuppressWarnings(hiding)` which

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-17 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-102834531 Would it be an easy task to possible to split this into jena-elephas related changes and changas related to other modules? I'm not so familiar with jena-elephas but I could

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-17 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-102834572 Would it be an easy task to possible to split this into jena-jdbc related changes and changes related to other modules? (If it's not an easy task, I can take a patch and edit

[GitHub] jena pull request: jena-text multilingual indexing

2015-04-09 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/51#issuecomment-91190852 Hi Alexis, I see that Comète is GPL3-licensed. That means that the project can incorporate source code licenced under the Apache License and still make the overall

[GitHub] jena pull request: Re-enable jena-osgi-tests

2015-04-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/49#issuecomment-88641136 I did try mvn in apache-jena-osgi which by dependency linkage should not need the install. But it seems OSGi is different, or the lifecycle isn't aligned, and it now works

[GitHub] jena pull request: Re-enable jena-osgi-tests

2015-04-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/49#issuecomment-88628699 After pulling this, I get errors with mvn clean verify in jena-osgi-test (ditto a top level rebuild). ``` Running org.apache.jena.osgi.test.JenaOSGITest

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103564682 Good to be precise! 2 PRs would be fantastic - (1) jena-jdbc and everything below it; they all go to make up jena-jdbc and (2) the rest. --- If your project is set

[GitHub] jena pull request: Kill dead things

2015-05-20 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-103970036 Changes based the ideas here have been applied to the codebase (See JENA-938). --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-20 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103970644 Thanks for the splitting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jena pull request: Enhance Javadocs for QueryEngineFactory

2015-06-05 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/75#issuecomment-109324133 Thanks - I've used this with clarifications. Normally, only query execution process would call the factory operations. --- If your project is set up for it, you can reply

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-06-03 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-108237260 Sorry your having problems - that should have worked when you press commit. Just send the modified markdown to me directly and I'll merge the files. --- If your project

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-06-03 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-108387604 That works great - thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-06-02 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-108096782 @amiara514 -- I'm not seeing a message from you on dev@. Did it get sent? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd

2015-06-19 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/77#issuecomment-113557412 Thank you. Code merged with some changes: * Version was used elsewhere (jena-elephas) so I put it back. * Didn't update rdfcat; the `BiConsumer` additions are only

[GitHub] jena pull request: Lucene index synchro on triple deletion (jena-t...

2015-06-18 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/53#issuecomment-113289019 Great - I'll integrate it as soon as I have a moment free to do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/76#discussion_r32211834 --- Diff: jena-core/src/main/java/jena/RuleMap.java --- @@ -50,7 +53,7 @@ * /p */ public class RuleMap { -static { setLog4jConfiguration

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/76#discussion_r32212217 --- Diff: jena-core/src/test/java/org/apache/jena/test/TestPackage.java --- @@ -32,7 +33,7 @@ public class TestPackage extends TestCase { --- End diff

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/76#discussion_r32212133 --- Diff: jena-core/pom.xml --- @@ -56,12 +56,24 @@ groupIdxerces/groupId artifactIdxercesImpl/artifactId

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/76#issuecomment-111221573 Thanks for clearing it up. I've just pulled it into the codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jena pull request:

2015-06-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/commit/21b37d1b8a4359de8f69786a57aa7d4283f3b779#commitcomment-11639747 I'll go look in my Eclipse settings though I thought I had the defaults in this area. Paradoxically, I get the opposite effect

[GitHub] jena pull request: Lucene index synchro on triple deletion (jena-t...

2015-06-16 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/53#issuecomment-112564393 Ack! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd

2015-06-16 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/77#issuecomment-112548845 Moving into jena-base is probably the best first step. It separates it from gathering all the commands which may well not be good idea anyway, or at least, a pointless

[GitHub] jena pull request: Fix jena-querybuilder test

2015-06-17 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/78#issuecomment-112943863 It would be better to be robust as to which form is produced. Both are correct. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jena pull request:

2015-06-17 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11733865 I only ran mvn -Pdev locally. As per comment on the PR - the test code should be robust to either correct form being produced

[GitHub] jena pull request: Lucene index synchro on triple deletion (jena-t...

2015-06-17 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/53#issuecomment-112947756 PR merged. Many thanks for working on this. Please could we have some documentation for the feature? --- If your project is set up for it, you can reply

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-05-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-106861440 @osma - I'll find some time to review this but To your points: 1. I dont think that change is a problem and \@Deprecated isn't needed because (a) Jena3 allows us

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-06-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-107605937 Hmm indeed. I'll trying making a small change to see if it flushes the correct mdtext file. --- If your project is set up for it, you can reply to this email and have your

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-06-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-107516262 Re: Map1Iterator -- yes is it similar (and older). `Iter` works on any iterators, not just `ExtendedIterator`. Re: naming of search - your choice. It is alwayss

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-06-01 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-107519936 Thank for pointing that out. The direct reflection of `site/trunk` is http://jena.staging.apache.org/ and the button should work there as well. The website gets published

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-05-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-106875094 Yes - adding the version info is more nice than essential. (Really, we ought to undo references to really old stuff.) --- If your project is set up for it, you can

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-05-31 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/72#discussion_r31388532 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -18,7 +18,9 @@ package org.apache.jena.query.text

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-05-31 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/72#discussion_r31388541 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -165,37 +176,48 @@ public QueryIterator exec(Binding binding, PropFuncArg

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-05-31 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/72#discussion_r31388513 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextHitConverter.java --- @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-05-31 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-107149537 There are a few `// *** score` markers left - presumably these can all go now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-05-31 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-107150565 Other than the point-wise comments above, all looks good and the tests pass for me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-06-02 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-107944800 Merge done! Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-06-02 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-107947521 An update for http://jena.staging.apache.org/documentation/query/text-query.html would be good. Either via through the CMS UI or a diff to https://svn.apache.org/repos/asf

[GitHub] jena pull request: Removing out-of-date comment and empty @Overrid...

2015-07-03 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/83#issuecomment-118392410 I've removed the comment and left the pulled down redeclarations. Transactions are central to datasets sop this makes it clearer. And it gets into the javadoc directly

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116589665 /documentation/fuseki2/fuseki-server-protocol.html will need updating but it is quite a small change. --- If your project is set up for it, you can reply to this email

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116601250 Indeed - etags are one example of a server driven mechanism. They need more machinery than this PR has though. HTTP headers are not always easy to deal with in client

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116589395 I disagree a bit about POST - yes, it's not nice REST but it is pragmatically useful to ensure up-to-date information (the client can force it even if the server or proxies

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116609093 Here, the client browser is an admin interface.The read-information operations are not a performance pain-point. Helpers presume how they are being used in Fuseki

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116628492 We are agreed that it's not related to this PR. Let's discuss it on dev@ and not tangle this PR with that discussion. --- If your project is set up for it, you can reply

[GitHub] jena pull request: pull master to begin

2015-05-24 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/71#issuecomment-104994252 A good place to start is with the changes needed for master.jj. If you want to discuss how to use javacc, which you may not have used before, then let's talk on the dev

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-05-25 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-105223531 PR merged and I've added back the constructors to align to the original `EntityDefinition`. This isn't to say that it is better - just maximised the compatibility with any

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-05-22 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104784383 git apply didn't see those! No matter - the PR is otherwise fine. When the `EntityDefinition` the migration constructor (which can be @Deprecated -- just trying

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-05-22 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104760829 The diff and patch are supposed to be the same end result, even if cumulative commits. The patch does not seem to have the later deletes. A bug(let) in github perhaps

[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-05-22 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-104755152 I'm working from the pull request (`.../64.patch`). Strange indeed : the `.diff` is good, the `.patch` is bad. The website is at https://svn.apache.org/repos/asf/jena

  1   2   3   4   5   6   7   8   9   10   >