[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-04-30 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/54 Deprecating Map1 in favor of Java8 Function Deprecating Map1 in favor of Java8 Function. I believe I have managed to avoid mangling any public contracts presented by Jena. You can merge

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98179500 Totally up to you. It's all clear to me and I don't require to parcel it out, but that's because I've been knee-deep in it. {grin} If you think it would make for a clearer

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98172820 NOT TO BE MERGED YET. This is just a first draft. There is clearly more to do to use Java 8 syntax to clarify filtered iteration and I just wanted to get something out

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/55 First draft of migrating Filter to Java 8 Predicate Continued work on JENA-929. Specifically, we now begin to migrate o.a.j.util.iterator.Filter and associated machinery to Java 8's new

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98222682 Ah, history. {grin} Okay, sounds like we should leave this current PR alone, if you feel that you can accept it as is. I'll send another which moves through

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98221169 Actually, there's also `org.apache.jena.atlas.iterator.FilterT`, which seems to be superseded by Java 8's `Predicate`. Maybe another PR is due here. --- If your project

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98220199 Okay-- thanks for pointing out `Iter`! It's a bit strange, though. It doesn't seem to be used all that much. For example, `NiceIterator.toSet()` doesn't use `Iter.toSet

[GitHub] jena pull request: First draft of migrating Filter to Java 8 Predi...

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/55#issuecomment-98220608 It looks like `Iter` makes use of some types that also have nice Java 8 replacements. Would a migration from `org.apache.jena.atlas.iterator.TransformT, R` to `Function

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98128730 Hm. That does sound weird. I'll take a look and straighten it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129632 Yep-- Git weirdness. I think that should square it. I'm not mentioning the Jira issue here because Git mistakes don't seem like part of the long-term record. --- If your

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129734 Right-- I just amended the commit to fully excise AsMapper. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

2015-05-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98133375 Thanks! P.S. Sorry about unused imports and the like. That was sloppy. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jena pull request: Jena base to java8

2015-05-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99121831 Okay, I'll plug `NodeTransform` back in at oaj.sparql.graph, since that is where it was: minimal disruption. I've got the JavaDocs square and re-separated the two `Closeable

[GitHub] jena pull request: Jena base to java8

2015-05-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99085428 I'm definitely up for breaking this down. :) The major moves here are: - I replaced any interface inside oaj.atlas for which I could find a functionally

[GitHub] jena pull request: Jena base to java8

2015-05-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99100248 Actually, for `NodeTransform`, perhaps it could be even more tightly scoped to just `org.apache.jena.sparql.algebra.optimize`? --- If your project is set up for it, you can

[GitHub] jena pull request: Jena base to java8

2015-05-06 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99466597 Sounds good. After this, wherever goes the conversation about Java 8, the Streams API, Commons RDF, etc., I will keep PRs much smaller. I felt comfortable trying to get away

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29946244 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29939173 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -43,7 +43,7 @@ /** One slot cache */ public static

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938812 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -33,7 +33,7 @@ /** Create a null cache */ public

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29939353 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29941387 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -33,7 +33,7 @@ /** Create a null cache */ public

[GitHub] jena pull request: Kill dead things

2015-05-08 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/58 Kill dead things NOT FOR MERGING. This PR is just a resource for selecting smaller, more carefully-examined packages of changes. You can merge this pull request into a Git repository

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938434 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -43,7 +43,7 @@ /** One slot cache */ public static

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938708 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29957586 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29955075 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29958012 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29958256 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29958374 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29957143 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java --- @@ -37,120 +37,81 @@ public class CacheSimpleK,V implements

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r30033794 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100894484 Sounds good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r30033649 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100901273 Because the comment disappeared-- clearly something else was going on, as @afs later indicated he already fixed the bug. What is the problem? --- If your project is set up

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100901958 Oh, cool. Yeah, there's a number of message-emitting sources here, eh? Asynchronous transactions are tricky. {grin} --- If your project is set up for it, you can reply

[GitHub] jena pull request: Remove caching gear from jena-core and use inst...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/59 Remove caching gear from jena-core and use instead that in jena-base You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/60 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from jena-arq, jena-base, jena-core, jena-csv, jena-iri, an jena-permissions. Includes removals for: Unthrown

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100955353 One last thing: it seems like a good idea to me to put a note in `CacheSimple` about the slot-replacement and fixed-size qualities that are demanded there. Or maybe instead

[GitHub] jena pull request: Jena base to java8

2015-05-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/56#issuecomment-99141455 `NodeTransform` is back-- I think that's all the emendation we wanted, yes? Did you have thoughts about dividing out this large PR? --- If your project is set up

[GitHub] jena pull request: Jena base to java8

2015-05-04 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/56 Jena base to java8 Work for https://issues.apache.org/jira/browse/JENA-931 Using Java 8 types and removing code that duplicates functionality found inside the current footprint. You can merge

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-101004445 Cool. Maybe there should be a comment on `CacheSetImpl` explaining why it must inherit the eviction policy from the wrapped `Cache`. It's not obvious to someone who doesn't

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/63 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from the src/main resources in jena-core and jena-base, including: Unnecessary @SuppressWarnings annotations

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101011238 Hm. Do you think it's worth taking a look at those Thrift tools to see if I can get them to gen cleaner code? (It has to be said that I've never used Thrift.) --- If your

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101012864 Yeah, I know what Thrift is, but I have no direct experience with it. I've worked with a few code generating frameworks (mostly for WSDL-related stuff) that gave relatively

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101014513 Okay, I will make that happen, but I'm not sure what you mean by javacc overwrites. You mean methods `sparql_10` and `sparql_11`? --- If your project is set up for it, you

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-08 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r29938256 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java --- @@ -33,7 +33,7 @@ /** Create a null cache */ public

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/61 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from jena-elephas and its submodules, jena-querybuilder, and jena-fuseki1 and jena-fuseki2, including: Unthrown

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/62 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from jena-jdbc and its submodules, jena-sdb, jena-spatial, jena-tdb and jena-text, including: Unthrown checked

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101236372 This is all good info, although I feel a bit unfortunate for having done these speculative PRs to get it. Can some kind of policy be published for these rules-of-thumb? Even

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-12 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101235688 They are, I hope, okay to merge in arbitrary order. I made these PRs based on the idea that each covers enough ground to be substantive without being too large

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-13 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101780453 Okay, whatever is useful is hopefully there for you without too much trouble. Let me know if I can help-- part of my personal motive for these wild-swinging clean up PRs

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103158636 See my comment [here](https://github.com/apache/jena/pull/61#issuecomment-102834531). Same question applies. --- If your project is set up for it, you can reply

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103158295 I don't know if my Git-fu is up to splitting it, but I could certainly just regenerate a new PR that is more restricted. Do you want to see one module : one PR? Or can all

[GitHub] jena pull request: JENA-941: Upgrading code quality plugin version...

2015-05-13 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/65 JENA-941: Upgrading code quality plugin versions This patch upgrades the code quality reporting plugins in use to versions that will work with Java 8, re-enabling `mvn site`. You can merge this pull

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-13 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101722026 I didn't see any such expansion of warnings, but that may have to do with my IDE settings. Generally, my take is that it's better to remove the warnings by fixing

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101273013 I don't think you owe me any apologies. It's just a case of a new guy showing up to an open source project who has to spend some time getting to know the rhythm before

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103505735 Meaning split it into changes to - jena-jdbc and its submodules - all other modules ? For a total of two new PRs? Sorry to be so precise-- I just want to make

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103520470 Should I wait for comment from @Claudenw or move to make three new PRs: - `jena-elephas` - `jena-querybuilder` - everything else that was included here

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-elephas

2015-05-19 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/67 JENA-938: Nonfunctional cleanup in jena-elephas You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupElephas Alternatively you can

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-querybu...

2015-05-19 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/68 JENA-938: Nonfunctional cleanup in jena-querybuilder You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupQueryBuilder Alternatively

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-fuseki*

2015-05-19 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/69 JENA-938: Nonfunctional cleanup in jena-fuseki* You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupFuseki Alternatively you can

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103629462 Closed in favor of #67, #68, #69. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/70 JENA-938: Nonfunctional cleanup in various modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupMisc Alternatively you can

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-19 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103632078 Okay, I've split this guy between this PR and #70. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-19 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103566657 Cool. I'll get on that. Might take a day or two, because I'm going to use it as a chance to improve my Gitcraft and try to understand how to split commits on a condition

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-20 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103971350 No problemo. Because it was a single commit, it was no harder than a `git reset` to before that commit and then some tap dancing between `git add`ing changes, committing

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-09 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/76 Eliminate jena-core/jena.cmdline, deprecate rdfcat https://issues.apache.org/jira/browse/JENA-962 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] jena pull request:

2015-06-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11746591 Oh, I see you added a different commit-- cool! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] jena pull request:

2015-06-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11746416 Okay, but isn't the build broken now? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-24 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/79#issuecomment-114963573 Closed in favor of #80 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-24 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/79#issuecomment-114963486 Closed in favor of #80 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jena pull request: Deprecating and removing some iterators from je...

2015-06-24 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/80 Deprecating and removing some iterators from jena-core https://issues.apache.org/jira/browse/JENA-966 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-24 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] jena pull request:

2015-06-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/21b37d1b8a4359de8f69786a57aa7d4283f3b779#commitcomment-11639466 Those warnings were there because without them, those inner class throw new deprecation warnings that don't really tell us anything

[GitHub] jena pull request:

2015-06-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/21b37d1b8a4359de8f69786a57aa7d4283f3b779#commitcomment-11639777 It's so good that Java is so deterministic. I really don't know-- maybe it's better to not have them. Maybe we should take a vote

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/76#discussion_r32220648 --- Diff: jena-core/src/main/java/jena/RuleMap.java --- @@ -50,7 +53,7 @@ * /p */ public class RuleMap { -static { setLog4jConfiguration

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/76#discussion_r32220860 --- Diff: jena-core/src/test/java/org/apache/jena/test/TestPackage.java --- @@ -32,7 +33,7 @@ public class TestPackage extends TestCase { --- End

[GitHub] jena pull request: Eliminate jena-core/jena.cmdline, deprecate r...

2015-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/76#discussion_r32220786 --- Diff: jena-core/pom.xml --- @@ -56,12 +56,24 @@ groupIdxerces/groupId artifactIdxercesImpl/artifactId

[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd

2015-06-16 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/77 Move arq.cmd.* to jena-base's jena.cmd https://issues.apache.org/jira/browse/JENA-961 This is a multi-module PR, but I could find no other way to do it: since several Jena modules depend

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-17 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/79 JENA-966: Eliminating some unnecessary iterator types You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-966 Alternatively you can

[GitHub] jena pull request:

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11730739 @afs Did you have any problems with `jena-querybuilder` after this? It's looking for the full type URI in some tests

[GitHub] jena pull request: Fix jena-querybuilder test

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/78#issuecomment-112912669 https://issues.apache.org/jira/browse/JENA-969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] jena pull request: Fix jena-querybuilder test

2015-06-17 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/78 Fix jena-querybuilder test The change to how rdf:type is serialized seems to have zonked a test in `jena-querybuilder`. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/77#issuecomment-112795366 Sorry, @afs, when you say Moving into jena-base is probably the best first step. are you referring to `ArqCmdGeneral`/`CmdGeneral`? --- If your project is set up

[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/77#issuecomment-112862578 Okay, I've got `ModVersion` out to `jena-base` and moved `Version` into it as an inner class (since `ModVersion` is the only client of `Version`). We are still doing

[GitHub] jena pull request: Enhance Javadocs for QueryEngineFactory

2015-06-04 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/75 Enhance Javadocs for QueryEngineFactory Based on remarks by Claude Warren at http://markmail.org/message/tingkcxzs3sf2xz4 You can merge this pull request into a Git repository by running: $ git

[GitHub] jena pull request: Add (?uri ?score) to jena-text

2015-06-01 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/72#issuecomment-107519784 `Iter` is also a good choice because it provides access to transform-behavior as well as many other forms of iterator-processing. `Map1Iterator` is more of an implementation

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/82#discussion_r33451617 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionBackupList.java --- @@ -0,0 +1,98 @@ +/** + * Licensed

[GitHub] jena pull request: Removing out-of-date comment and empty @Overrid...

2015-06-29 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/83 Removing out-of-date comment and empty @Overrides from Dataset A comment in `Dataset` indicated that it did not implement `Transactional` when in fact it now does. I removed that comment and the now

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/82#discussion_r33457733 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionBackupList.java --- @@ -0,0 +1,98 @@ +/** + * Licensed

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116597497 `POST` is one way to enable a force up-to-date`, but it should also be possible to supply an ETag, which is a little more to the exact need. Perhaps Fuseki has helpers

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116603288 Okay-- do you think it's worth a separate ticket and PR for some helpers for ETags, so that future new Fuseki HTTP functions could offer them at low cost? --- If your

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116628538 Okay, sorry to cloud the waters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116612135 I meant something as simple as a method that accepts an identifier and response and adds the correctly-formatted tag. --- If your project is set up for it, you can reply

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-104258333 Okay, that's cool. If you're confident that that stuff is real, only not currently interesting, then we need it. I would have removed it and retrieved it when wanted from VC

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/90#discussion_r35807971 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java --- @@ -29,6 +29,14 @@ import org.apache.jena.atlas.lib.Closeable ; import

[GitHub] jena pull request: Merge confidencesun/master (Merged from JENA-49...

2015-07-30 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/89#discussion_r35870389 --- Diff: jena-arq/src-examples/arq/examples/constructquads/ExampleConstructQuads.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-30 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/90#discussion_r35869523 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java --- @@ -29,6 +29,14 @@ import org.apache.jena.atlas.lib.Closeable ; import

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-30 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/90#discussion_r35871940 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java --- @@ -29,6 +29,14 @@ import org.apache.jena.atlas.lib.Closeable ; import

  1   2   3   4   5   6   7   8   >