Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r84577738
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java
---
@@ -111,8 +110,6 @@ protected JsonValue
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r84549447
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java
---
@@ -111,8 +110,6 @@ protected JsonValue
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r84518062
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java
---
@@ -111,8 +110,6 @@ protected JsonValue
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r84518192
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java
---
@@ -102,7 +102,8 @@ protected String
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r84518512
--- Diff:
jena-base/src/test/java/org/apache/jena/atlas/io/AbstractTestPeekInputStream.java
---
@@ -153,7 +152,7 @@
@Test public void unread3()
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r84510072
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/async/AsyncPool.java
---
@@ -53,7 +53,7 @@ public AsyncTask submit(Runnable task,
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511823
--- Diff:
jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java
---
@@ -299,7 +299,7 @@ public String toString() throws
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511824
--- Diff:
jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java
---
@@ -312,7 +312,7 @@ private Boolean cacheGet(final CacheKey
Github user Claudenw commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511612
--- Diff:
jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java
---
@@ -312,7 +312,7 @@ private Boolean cacheGet(final
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511008
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java
---
@@ -101,33 +95,6 @@ protected JsonObject
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511001
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java
---
@@ -162,10 +162,6 @@
}
}
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511004
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java
---
@@ -371,19 +367,6 @@ else if ( ! dir.isDirectory())
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510986
--- Diff: jena-base/src/test/java/org/apache/jena/atlas/lib/TestHex.java ---
@@ -85,7 +85,7 @@ private static void testStr2Val(String str, int expected)
{
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511000
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java
---
@@ -371,19 +367,6 @@ else if ( ! dir.isDirectory())
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510977
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterTopN.java
---
@@ -74,7 +74,7 @@ public QueryIterTopN(QueryIterator qIter,
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510973
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java
---
@@ -227,11 +220,6 @@ else if ( ch <= 0x7FFF )
}
//int
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510971
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java
---
@@ -154,11 +152,6 @@ else if ( (x & 0xF8) == 0xF0 )
}
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510373
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterTopN.java
---
@@ -74,7 +74,7 @@ public QueryIterTopN(QueryIterator qIter,
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510665
--- Diff:
jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java
---
@@ -261,18 +260,10 @@ public void query_describe_conneg() {
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510358
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java
---
@@ -227,11 +220,6 @@ else if ( ch <= 0x7FFF )
}
//int
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510610
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/async/AsyncPool.java
---
@@ -53,7 +53,7 @@ public AsyncTask submit(Runnable task,
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510619
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java
---
@@ -162,10 +162,6 @@
}
}
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510444
--- Diff:
jena-base/src/test/java/org/apache/jena/atlas/io/AbstractTestPeekInputStream.java
---
@@ -140,7 +139,7 @@
{
PeekInputStream in =
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510625
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java
---
@@ -101,33 +95,6 @@ protected JsonObject
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510455
--- Diff:
jena-base/src/test/java/org/apache/jena/atlas/lib/cache/TestCacheSimple.java ---
@@ -43,7 +43,6 @@ public void testFixedSize() {
@Test
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510331
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java
---
@@ -154,11 +152,6 @@ else if ( (x & 0xF8) == 0xF0 )
}
}
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510652
--- Diff:
jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestAdmin.java
---
@@ -309,11 +310,6 @@
}
}
-
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510645
--- Diff:
jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/FileSender.java
---
@@ -79,8 +79,8 @@ public void send(String method) {
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510433
--- Diff: jena-base/src/test/java/org/apache/jena/atlas/lib/TestHex.java ---
@@ -85,7 +85,7 @@ private static void testStr2Val(String str, int expected)
{
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82510609
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/FusekiServer.java
---
@@ -371,19 +367,6 @@ else if ( ! dir.isDirectory())
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/176
Minor cleanup
Just removing dead code and variables that don't get used, adding `static`
here or there to clarify tests a bit, that sort of thing. Pruning.
You can merge this pull request into a Git
32 matches
Mail list logo
