[jira] [Commented] (JENA-1483) Allow different promote() modes.
[
https://issues.apache.org/jira/browse/JENA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360465#comment-16360465
]
ASF GitHub Bot commented on JENA-1483:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/355
> Allow different promote() modes.
>
>
> Key: JENA-1483
> URL: https://issues.apache.org/jira/browse/JENA-1483
> Project: Apache Jena
> Issue Type: Improvement
>Reporter: Andy Seaborne
>Priority: Major
>
> This follows on from JENA-1458.
> In the previous work, there is one promote operation, {{promote()}}, that
> takes the transaction type to determine whether to promote with or without
> "read commits" effects.
> This ticket introduces {{promote(Promote mode)}} where the mode can be given
> explicitly.
> {{promote()}} becomes a default method of the interface that chooses the
> promote mode based on the way the transaction was started.
> This ticket also changes {{promote}} to return boolean false, and leave the
> transaction still valid, if an attempt is made to promote a read-only
> transaction. This is more uniform between the transaction type and any
> intermediate writer blocking promotion in READ_PROMOTE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1483) Allow different promote() modes.
[
https://issues.apache.org/jira/browse/JENA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360463#comment-16360463
]
ASF subversion and git services commented on JENA-1483:
---
Commit 48c6dc64539c4af3427017a656993f5e034728e4 in jena's branch
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=48c6dc6 ]
JENA-1483: Merge commit 'refs/pull/355/head' of https://github.com/apache/jena
This closes #355.
> Allow different promote() modes.
>
>
> Key: JENA-1483
> URL: https://issues.apache.org/jira/browse/JENA-1483
> Project: Apache Jena
> Issue Type: Improvement
>Reporter: Andy Seaborne
>Priority: Major
>
> This follows on from JENA-1458.
> In the previous work, there is one promote operation, {{promote()}}, that
> takes the transaction type to determine whether to promote with or without
> "read commits" effects.
> This ticket introduces {{promote(Promote mode)}} where the mode can be given
> explicitly.
> {{promote()}} becomes a default method of the interface that chooses the
> promote mode based on the way the transaction was started.
> This ticket also changes {{promote}} to return boolean false, and leave the
> transaction still valid, if an attempt is made to promote a read-only
> transaction. This is more uniform between the transaction type and any
> intermediate writer blocking promotion in READ_PROMOTE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1483) Allow different promote() modes.
[
https://issues.apache.org/jira/browse/JENA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359054#comment-16359054
]
ASF GitHub Bot commented on JENA-1483:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/355#discussion_r167362604
--- Diff: pom.xml ---
@@ -735,6 +735,7 @@
maven-compiler-plugin
3.7.0
+false
--- End diff --
This crept in. We don't build with `-Xlint:deprecation` and all the output
is
```
[INFO] java: Some input files use or override a deprecated API.
[INFO] java: Recompile with -Xlint:deprecation for details.
```
so it does not given much information. Being an old codebase, and valuing
legacy continuity, using/overriding deprecation happens.
> Allow different promote() modes.
>
>
> Key: JENA-1483
> URL: https://issues.apache.org/jira/browse/JENA-1483
> Project: Apache Jena
> Issue Type: Improvement
>Reporter: Andy Seaborne
>Priority: Major
>
> This follows on from JENA-1458.
> In the previous work, there is one promote operation, {{promote()}}, that
> takes the transaction type to determine whether to promote with or without
> "read commits" effects.
> This ticket introduces {{promote(Promote mode)}} where the mode can be given
> explicitly.
> {{promote()}} becomes a default method of the interface that chooses the
> promote mode based on the way the transaction was started.
> This ticket also changes {{promote}} to return boolean false, and leave the
> transaction still valid, if an attempt is made to promote a read-only
> transaction. This is more uniform between the transaction type and any
> intermediate writer blocking promotion in READ_PROMOTE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1483) Allow different promote() modes.
[
https://issues.apache.org/jira/browse/JENA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359050#comment-16359050
]
ASF GitHub Bot commented on JENA-1483:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/355
JENA-1483: Promote with explicit promotion mode.
Includes a fix for JENA-1478.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena promote-arg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
commit d8306ce261fe0bd07ede33426b9850ecd16f8b6e
Author: Andy Seaborne
Date: 2018-02-03T15:03:41Z
promote(TxnType)
commit 5f99f5f3bb1a0e34d71048d1cec97f6b81bdbb64
Author: Andy Seaborne
Date: 2018-02-06T12:36:52Z
promote(Promote mode)
commit e44ca811387b457b9bf1227ca87f07c6ac6fecf2
Author: Andy Seaborne
Date: 2018-02-09T21:54:24Z
JENA-1478: Fix for contains(g,s,p,o)
> Allow different promote() modes.
>
>
> Key: JENA-1483
> URL: https://issues.apache.org/jira/browse/JENA-1483
> Project: Apache Jena
> Issue Type: Improvement
>Reporter: Andy Seaborne
>Priority: Major
>
> This follows on from JENA-1458.
> In the previous work, there is one promote operation, {{promote()}}, that
> takes the transaction type to determine whether to promote with or without
> "read commits" effects.
> This ticket introduces {{promote(Promote mode)}} where the mode can be given
> explicitly.
> {{promote()}} becomes a default method of the interface that chooses the
> promote mode based on the way the transaction was started.
> This ticket also changes {{promote}} to return boolean false, and leave the
> transaction still valid, if an attempt is made to promote a read-only
> transaction. This is more uniform between the transaction type and any
> intermediate writer blocking promotion in READ_PROMOTE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
